From: Patrice CHOTARD <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/5] usb: host: replace printf() by error() in ehci-generic
Date: Mon, 15 May 2017 08:00:15 +0000 [thread overview]
Message-ID: <898ebc8a-ec25-bb9f-bcb2-632574f87f34@st.com> (raw)
In-Reply-To: <3aa08585-ac59-2cd0-4cee-5b90eecc2225@denx.de>
Hi Marek
On 05/12/2017 10:51 PM, Marek Vasut wrote:
> On 05/12/2017 07:27 PM, patrice.chotard at st.com wrote:
>> From: Patrice Chotard <patrice.chotard@st.com>
>
> Commit message does not explain WHY this change is needed. In fact ...
> commit message is missing altogether ...
Yes, my bad i forget it, i will add it in the v3
Thanks
Patrice
>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> ---
>>
>> v2: _ create this independant path for printf() replacement
>>
>> drivers/usb/host/ehci-generic.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c
>> index 0000808..39b56de 100644
>> --- a/drivers/usb/host/ehci-generic.c
>> +++ b/drivers/usb/host/ehci-generic.c
>> @@ -74,7 +74,7 @@ static int ehci_usb_probe(struct udevice *dev)
>> if (ret < 0)
>> break;
>> if (clk_enable(&clk)) {
>> - printf("failed to enable clock %d\n", i);
>> + error("failed to enable clock %d\n", i);
>> clk_free(&clk);
>> goto clk_err;
>> }
>> @@ -88,7 +88,7 @@ static int ehci_usb_probe(struct udevice *dev)
>> if (ret < 0)
>> break;
>> if (reset_deassert(&reset)) {
>> - printf("failed to deassert reset %d\n", i);
>> + error("failed to deassert reset %d\n", i);
>> reset_free(&reset);
>> goto reset_err;
>> }
>>
>
>
next prev parent reply other threads:[~2017-05-15 8:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 17:27 [U-Boot] [PATCH v2 0/5] usb: Extend ehci and ohci generic drivers patrice.chotard at st.com
2017-05-12 17:27 ` [U-Boot] [PATCH v2 1/5] reset: add reset_request() patrice.chotard at st.com
2017-05-15 3:03 ` Simon Glass
2017-05-12 17:27 ` [U-Boot] [PATCH v2 2/5] usb: host: add error path and remove callback in ehci-generic patrice.chotard at st.com
2017-05-12 20:50 ` Marek Vasut
2017-05-15 7:56 ` Patrice CHOTARD
2017-05-15 3:03 ` Simon Glass
2017-05-15 8:02 ` Patrice CHOTARD
2017-05-12 17:27 ` [U-Boot] [PATCH v2 3/5] usb: host: extend generic EHCI driver with PHY patrice.chotard at st.com
2017-05-12 20:50 ` Marek Vasut
2017-05-15 7:59 ` Patrice CHOTARD
2017-05-15 3:03 ` Simon Glass
2017-05-15 8:03 ` Patrice CHOTARD
2017-05-12 17:27 ` [U-Boot] [PATCH v2 4/5] usb: host: replace printf() by error() in ehci-generic patrice.chotard at st.com
2017-05-12 20:51 ` Marek Vasut
2017-05-15 3:27 ` Simon Glass
2017-05-15 8:00 ` Patrice CHOTARD [this message]
2017-05-12 17:27 ` [U-Boot] [PATCH v2 5/5] usb: host: extend generic OHCI with CLOCK, RESET and PHY patrice.chotard at st.com
2017-05-15 3:27 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=898ebc8a-ec25-bb9f-bcb2-632574f87f34@st.com \
--to=patrice.chotard@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.