All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joao.Pinto@synopsys.com (Joao Pinto)
To: linux-arm-kernel@lists.infradead.org
Subject: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"
Date: Thu, 23 Mar 2017 10:56:55 +0000	[thread overview]
Message-ID: <89948183-5dba-af4e-8fd1-2a6add6750c8@synopsys.com> (raw)
In-Reply-To: <5c305629-0b61-88e5-5c48-4616cd687d9f@st.com>

?s 10:51 AM de 3/23/2017, Giuseppe CAVALLARO escreveu:
> On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote:
>> Hello
>>
>> On 3/23/2017 11:20 AM, Corentin Labbe wrote:
>>>> I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression.
>>>> >Could you please share the iperf cmds you are using in order for me to
>>>> reproduce
>>>> >in my side?
>>
>> Joao, you have a really powerful HW integration with multiple channels for
>> both RX and TX.
>> Often this is not the same for other setup where, usually just a DMA0 is
>> present or, sometime, there
>> is just one RX extra channel.
>>
>> My question is, what happens on this kind of configurations? Are we still
>> guarantying the best performances?
>>
>> Also we have to guarantee, that the TSO and SG are always working. Another
>> point is the buffer sizes that
>> can be different among platforms.
>>
>> The problem  below reported by Corentin push me to think that there is a bug,
>> so we should
>> understand when this has been introduced and if likely fixed by some
>> configuration we are
>> not take care right now.
>>
>> ndesc_get_rx_status: Oversized frame spanned multiple buffers"
> 
> I wonder if this could be easily triggered by getting a big file via FTP. So not
> properly related on performance benchs

I am going to do that test and check it out and also run iperf a couple of
times. I am counting on doing this today and send you later the results. If
anyone gets results sooner please share.

> 
> peppe
> 
>>
>>
>> Best Regards
>> Peppe
>>
> 

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: <alexandre.torgue@st.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"
Date: Thu, 23 Mar 2017 10:56:55 +0000	[thread overview]
Message-ID: <89948183-5dba-af4e-8fd1-2a6add6750c8@synopsys.com> (raw)
In-Reply-To: <5c305629-0b61-88e5-5c48-4616cd687d9f@st.com>

Às 10:51 AM de 3/23/2017, Giuseppe CAVALLARO escreveu:
> On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote:
>> Hello
>>
>> On 3/23/2017 11:20 AM, Corentin Labbe wrote:
>>>> I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression.
>>>> >Could you please share the iperf cmds you are using in order for me to
>>>> reproduce
>>>> >in my side?
>>
>> Joao, you have a really powerful HW integration with multiple channels for
>> both RX and TX.
>> Often this is not the same for other setup where, usually just a DMA0 is
>> present or, sometime, there
>> is just one RX extra channel.
>>
>> My question is, what happens on this kind of configurations? Are we still
>> guarantying the best performances?
>>
>> Also we have to guarantee, that the TSO and SG are always working. Another
>> point is the buffer sizes that
>> can be different among platforms.
>>
>> The problem  below reported by Corentin push me to think that there is a bug,
>> so we should
>> understand when this has been introduced and if likely fixed by some
>> configuration we are
>> not take care right now.
>>
>> ndesc_get_rx_status: Oversized frame spanned multiple buffers"
> 
> I wonder if this could be easily triggered by getting a big file via FTP. So not
> properly related on performance benchs

I am going to do that test and check it out and also run iperf a couple of
times. I am counting on doing this today and send you later the results. If
anyone gets results sooner please share.

> 
> peppe
> 
>>
>>
>> Best Regards
>> Peppe
>>
> 

Thanks.

  reply	other threads:[~2017-03-23 10:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 10:08 stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers" Corentin Labbe
2017-03-23 10:08 ` Corentin Labbe
2017-03-23 10:12 ` Joao Pinto
2017-03-23 10:12   ` Joao Pinto
2017-03-23 10:20   ` Corentin Labbe
2017-03-23 10:20     ` Corentin Labbe
2017-03-23 10:40     ` Joao Pinto
2017-03-23 10:40       ` Joao Pinto
2017-03-23 10:48       ` Giuseppe CAVALLARO
2017-03-23 10:48         ` Giuseppe CAVALLARO
2017-03-23 10:48         ` Giuseppe CAVALLARO
2017-03-23 10:51         ` Giuseppe CAVALLARO
2017-03-23 10:51           ` Giuseppe CAVALLARO
2017-03-23 10:51           ` Giuseppe CAVALLARO
2017-03-23 10:56           ` Joao Pinto [this message]
2017-03-23 10:56             ` Joao Pinto
2017-03-23 12:55             ` Joao Pinto
2017-03-23 12:55               ` Joao Pinto
2017-03-23 10:54         ` Joao Pinto
2017-03-23 10:54           ` Joao Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89948183-5dba-af4e-8fd1-2a6add6750c8@synopsys.com \
    --to=joao.pinto@synopsys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.