From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
DT <devicetree@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Disable coresight by default
Date: Thu, 03 Oct 2019 20:51:46 +0530 [thread overview]
Message-ID: <89f5f76ae26682e902faa1b06379cc0f@codeaurora.org> (raw)
In-Reply-To: <aecbc7a2-05fd-f30f-81c7-81947dc31c9f@free.fr>
On 2019-10-03 18:23, Marc Gonzalez wrote:
> On 03/10/2019 08:44, Sai Prakash Ranjan wrote:
>
>> Boot failure has been reported on MSM8998 based laptop when
>> coresight is enabled. This is most likely due to lack of
>> firmware support for coresight on production device when
>> compared to debug device like MTP where this issue is not
>> observed. So disable coresight by default for MSM8998 and
>> enable it only for MSM8998 MTP.
>>
>> Reported-and-tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>> Fixes: 783abfa2249a ("arm64: dts: qcom: msm8998: Add Coresight
>> support")
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 68
>> +++++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 51 +++++++++++------
>> 2 files changed, 102 insertions(+), 17 deletions(-)
>
> Just wanted to toss an alternative, based on Suzuki's suggestion
> (i.e. move the coresight nodes to a separate file)
>
>
I believe this is a better approach.
Initially I had coresight components in a separate file like this but
Bjorn had some concerns about having 2 separate files. If he is OK with
this,
Acked-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Mark Rutland <mark.rutland@arm.com>,
DT <devicetree@vger.kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
MSM <linux-arm-msm@vger.kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Disable coresight by default
Date: Thu, 03 Oct 2019 20:51:46 +0530 [thread overview]
Message-ID: <89f5f76ae26682e902faa1b06379cc0f@codeaurora.org> (raw)
In-Reply-To: <aecbc7a2-05fd-f30f-81c7-81947dc31c9f@free.fr>
On 2019-10-03 18:23, Marc Gonzalez wrote:
> On 03/10/2019 08:44, Sai Prakash Ranjan wrote:
>
>> Boot failure has been reported on MSM8998 based laptop when
>> coresight is enabled. This is most likely due to lack of
>> firmware support for coresight on production device when
>> compared to debug device like MTP where this issue is not
>> observed. So disable coresight by default for MSM8998 and
>> enable it only for MSM8998 MTP.
>>
>> Reported-and-tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>> Fixes: 783abfa2249a ("arm64: dts: qcom: msm8998: Add Coresight
>> support")
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 68
>> +++++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 51 +++++++++++------
>> 2 files changed, 102 insertions(+), 17 deletions(-)
>
> Just wanted to toss an alternative, based on Suzuki's suggestion
> (i.e. move the coresight nodes to a separate file)
>
>
I believe this is a better approach.
Initially I had coresight components in a separate file like this but
Bjorn had some concerns about having 2 separate files. If he is OK with
this,
Acked-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Mark Rutland <mark.rutland@arm.com>,
DT <devicetree@vger.kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
MSM <linux-arm-msm@vger.kernel.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Disable coresight by default
Date: Thu, 03 Oct 2019 20:51:46 +0530 [thread overview]
Message-ID: <89f5f76ae26682e902faa1b06379cc0f@codeaurora.org> (raw)
In-Reply-To: <aecbc7a2-05fd-f30f-81c7-81947dc31c9f@free.fr>
On 2019-10-03 18:23, Marc Gonzalez wrote:
> On 03/10/2019 08:44, Sai Prakash Ranjan wrote:
>
>> Boot failure has been reported on MSM8998 based laptop when
>> coresight is enabled. This is most likely due to lack of
>> firmware support for coresight on production device when
>> compared to debug device like MTP where this issue is not
>> observed. So disable coresight by default for MSM8998 and
>> enable it only for MSM8998 MTP.
>>
>> Reported-and-tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>> Fixes: 783abfa2249a ("arm64: dts: qcom: msm8998: Add Coresight
>> support")
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 68
>> +++++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 51 +++++++++++------
>> 2 files changed, 102 insertions(+), 17 deletions(-)
>
> Just wanted to toss an alternative, based on Suzuki's suggestion
> (i.e. move the coresight nodes to a separate file)
>
>
I believe this is a better approach.
Initially I had coresight components in a separate file like this but
Bjorn had some concerns about having 2 separate files. If he is OK with
this,
Acked-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-10-03 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 6:44 [PATCH] arm64: dts: qcom: msm8998: Disable coresight by default Sai Prakash Ranjan
2019-10-03 6:44 ` Sai Prakash Ranjan
2019-10-03 12:53 ` Marc Gonzalez
2019-10-03 12:53 ` Marc Gonzalez
2019-10-03 12:53 ` Marc Gonzalez
2019-10-03 15:21 ` Sai Prakash Ranjan [this message]
2019-10-03 15:21 ` Sai Prakash Ranjan
2019-10-03 15:21 ` Sai Prakash Ranjan
2019-10-03 16:23 ` Bjorn Andersson
2019-10-03 16:23 ` Bjorn Andersson
2019-10-03 16:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f5f76ae26682e902faa1b06379cc0f@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.