From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Unbind the bo if the user requests a different alignment
Date: Mon, 12 Apr 2010 18:23:22 +0100 [thread overview]
Message-ID: <89khjo$f4ssom@orsmga002.jf.intel.com> (raw)
In-Reply-To: <87ljcswq9t.fsf@pollan.anholt.net>
On Mon, 12 Apr 2010 10:10:22 -0700, Eric Anholt <eric@anholt.net> wrote:
> On Sun, 4 Apr 2010 22:35:19 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > If the buffer is currently bound and does not meet the requested
> > alignment, then unbind it and repin.
>
> Do we have any users legitimately requesting an alignment? I thought
> they never existed or only lied when they did.
Yes, I invented one. ;-) Reusing surfaces within a batch with different
per-surface tiling parameters on pre-i965, without informing the kernel
that the buffer is tiled [so we can get away with reusing the surface
multiple times in the batch with different parameters...], and so having
to manually request the minimal legal alignment for the relocated bo.
Given the transient nature of clip masks, glyph masks and intermediate
back buffers, we can reuse a lot of buffers within a single batch and
avoid catastrophic aperture thrashing.
-ickle
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-04-12 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1270416921-25483-1-git-send-email-chris@chris-wilson.co.uk>
2010-04-12 17:10 ` [PATCH 1/3] drm/i915: Unbind the bo if the user requests a different alignment Eric Anholt
2010-04-12 17:23 ` Chris Wilson [this message]
2010-04-13 23:49 ` Eric Anholt
2010-04-14 9:29 ` Chris Wilson
2010-04-14 10:23 ` Daniel Vetter
2010-04-14 21:19 ` Eric Anholt
2010-04-19 4:07 ` Owain Ainsworth
[not found] ` <1270417973-6795-1-git-send-email-chris@chris-wilson.co.uk>
2010-04-19 0:16 ` [PATCH] drm/i915: Remove spurious warning "Failure to install fence" Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89khjo$f4ssom@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.