From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()
Date: Fri, 28 May 2010 10:36:55 +0100 [thread overview]
Message-ID: <89khjo$fhq87i@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20100528092849.GB3612@viiv.ffwll.ch>
On Fri, 28 May 2010 11:28:50 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote:
> > Since we now get_user_pages() outside of the mutex prior to performing
> > the copy, we kmap() the page inside the copy routine and so need to
> > perform an ordinary memcpy() and not copy_from_user().
>
> Patches look sane and will definitely help in (someday) fixing up the racy
> pwrite/pread locking.
Now who's being optimistic... ;-)
All I am trying to do is find some way to explain
https://bugs.freedesktop.org/show_bug.cgi?id=26645#c5
-ickle
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-05-28 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 13:15 [PATCH 1/2] drm/i915: Use non-atomic kmap for slow copy paths Chris Wilson
2010-05-27 13:15 ` [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write() Chris Wilson
2010-05-28 9:28 ` Daniel Vetter
2010-05-28 9:36 ` Chris Wilson [this message]
2010-05-28 18:06 ` [PATCH 1/2] drm/i915: Use non-atomic kmap for slow copy paths Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='89khjo$fhq87i@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.