From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
airlied@linux.ie, robh+dt@kernel.org, tomi.valkeinen@ti.com,
dri-devel@lists.freedesktop.org, kernel@collabora.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional
Date: Mon, 15 Jun 2020 11:38:07 +0200 [thread overview]
Message-ID: <8ad9a397a5fa6cebd2a4e0170dfa96ad73907faf.camel@collabora.com> (raw)
In-Reply-To: <20200611160817.GA6031@pendragon.ideasonboard.com>
Hi Laurent,
Thanks for reviewing the patch
On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > Make the ports node optional, since there are some DTs that don't define
> > any ports for ti,tfp410.
> >
> > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
>
> Shouldn't we fix those DTs instead ? What's the point of a TFP410
> without ports in DT ?
This comes from the discussion in the previous version of this series.
In the DTs that don't define any ports (it's dove-sbc-a510.dts only, actually)
it's not clear how to define the ports (I'm not familiar with this board).
Initially I defined a set of empty ports just to comply with the binding
requirements, but Rob suggested that we might as well declare them as optional,
since having an empty port definition with no remote endpoints is no better than
having no ports at all.
I understand both opinions but I just don't know which is the best option at
this point.
Cheers,
Ricardo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, tomi.valkeinen@ti.com, kernel@collabora.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional
Date: Mon, 15 Jun 2020 11:38:07 +0200 [thread overview]
Message-ID: <8ad9a397a5fa6cebd2a4e0170dfa96ad73907faf.camel@collabora.com> (raw)
In-Reply-To: <20200611160817.GA6031@pendragon.ideasonboard.com>
Hi Laurent,
Thanks for reviewing the patch
On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > Make the ports node optional, since there are some DTs that don't define
> > any ports for ti,tfp410.
> >
> > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
>
> Shouldn't we fix those DTs instead ? What's the point of a TFP410
> without ports in DT ?
This comes from the discussion in the previous version of this series.
In the DTs that don't define any ports (it's dove-sbc-a510.dts only, actually)
it's not clear how to define the ports (I'm not familiar with this board).
Initially I defined a set of empty ports just to comply with the binding
requirements, but Rob suggested that we might as well declare them as optional,
since having an empty port definition with no remote endpoints is no better than
having no ports at all.
I understand both opinions but I just don't know which is the best option at
this point.
Cheers,
Ricardo
WARNING: multiple messages have this Message-ID (diff)
From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
airlied@linux.ie, robh+dt@kernel.org, tomi.valkeinen@ti.com,
dri-devel@lists.freedesktop.org, kernel@collabora.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional
Date: Mon, 15 Jun 2020 11:38:07 +0200 [thread overview]
Message-ID: <8ad9a397a5fa6cebd2a4e0170dfa96ad73907faf.camel@collabora.com> (raw)
In-Reply-To: <20200611160817.GA6031@pendragon.ideasonboard.com>
Hi Laurent,
Thanks for reviewing the patch
On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > Make the ports node optional, since there are some DTs that don't define
> > any ports for ti,tfp410.
> >
> > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
>
> Shouldn't we fix those DTs instead ? What's the point of a TFP410
> without ports in DT ?
This comes from the discussion in the previous version of this series.
In the DTs that don't define any ports (it's dove-sbc-a510.dts only, actually)
it's not clear how to define the ports (I'm not familiar with this board).
Initially I defined a set of empty ports just to comply with the binding
requirements, but Rob suggested that we might as well declare them as optional,
since having an empty port definition with no remote endpoints is no better than
having no ports at all.
I understand both opinions but I just don't know which is the best option at
this point.
Cheers,
Ricardo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-15 9:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:23 [PATCH v3 0/5] dt-bindings: display: ti,tfp410.txt: convert to yaml Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 1/5] " Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 2/5] dt-bindings: display: ti, tfp410.yaml: Redefine ti, deskew property Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 2/5] dt-bindings: display: ti,tfp410.yaml: Redefine ti,deskew property Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 3/5] drm/bridge: tfp410: fix de-skew value retrieval from DT Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 4/5] drm/bridge: tfp410: Fix setup and hold time calculation Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 5/5] dt-bindings: display: ti, tfp410.yaml: make the ports node optional Ricardo Cañuelo
2020-06-11 10:23 ` Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: " Ricardo Cañuelo
2020-06-11 16:08 ` Laurent Pinchart
2020-06-11 16:08 ` Laurent Pinchart
2020-06-11 16:08 ` Laurent Pinchart
2020-06-15 9:38 ` Ricardo Cañuelo [this message]
2020-06-15 9:38 ` Ricardo Cañuelo
2020-06-15 9:38 ` Ricardo Cañuelo
2020-06-16 1:51 ` Laurent Pinchart
2020-06-16 1:51 ` Laurent Pinchart
2020-06-16 1:51 ` Laurent Pinchart
2020-06-16 6:42 ` Ricardo Cañuelo
2020-06-16 6:42 ` Ricardo Cañuelo
2020-06-16 6:42 ` Ricardo Cañuelo
2020-06-17 22:37 ` Rob Herring
2020-06-17 22:37 ` Rob Herring
2020-06-17 22:37 ` Rob Herring
2020-06-17 22:34 ` Rob Herring
2020-06-17 22:34 ` Rob Herring
2020-06-17 22:34 ` Rob Herring
2020-06-17 22:43 ` Laurent Pinchart
2020-06-17 22:43 ` Laurent Pinchart
2020-06-17 22:43 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad9a397a5fa6cebd2a4e0170dfa96ad73907faf.camel@collabora.com \
--to=ricardo.canuelo@collabora.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason@lakedaemon.net \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.