All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Charkov <alchark@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	"Jacobe Zang" <jacobe.zang@wesion.com>
Cc: nick@khadas.com, efectn@protonmail.com, jagan@edgeble.ai,
	dsimic@manjaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: Add cpufreq support to Khadas Edge2
Date: Mon, 17 Jun 2024 13:09:00 +0400	[thread overview]
Message-ID: <8ae179e6-3aee-415b-9dc4-298e162fbcad@gmail.com> (raw)
In-Reply-To: <5475817.tWeucmBOSa@diego>


On 17/06/2024 11:33, Heiko Stübner wrote:
> Hi Jacobe Zang,
>
> Am Montag, 17. Juni 2024, 09:11:12 CEST schrieb Jacobe Zang:
>> This adjust CPU nodes on Khadas Edge2.
>>
>> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
>> ---
>>   .../arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>> index 7d7cc3e76838c..5fb15d3dc23e9 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>> @@ -160,34 +160,42 @@ vdd_3v3_sd: vdd-3v3-sd-regulator {
>>   
>>   &cpu_b0 {
>>   	cpu-supply = <&vdd_cpu_big0_s0>;
>> +	mem-supply = <&vdd_cpu_big0_mem_s0>;
> as far as I remember there has not been any binding merged that declares
> this supply. Thankfully following the double phandle below, the Edge2 is
> designed to use the same regulator for the mem-supply, so special handling
> isn't even needed.

Indeed, currently there isn't any user in the mainline tree (neither 
bindings nor drivers) for this separate regulator. Mainline cpufreq-dt 
only expects a single regulator, and as Heiko pointed out Edge2 uses the 
same physical regulator to power both the CPU core and its SRAM, so 
adding a separate mem-supply here isn't helpful.

Best regards, Alexey


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Charkov <alchark@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	"Jacobe Zang" <jacobe.zang@wesion.com>
Cc: nick@khadas.com, efectn@protonmail.com, jagan@edgeble.ai,
	dsimic@manjaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: Add cpufreq support to Khadas Edge2
Date: Mon, 17 Jun 2024 13:09:00 +0400	[thread overview]
Message-ID: <8ae179e6-3aee-415b-9dc4-298e162fbcad@gmail.com> (raw)
In-Reply-To: <5475817.tWeucmBOSa@diego>


On 17/06/2024 11:33, Heiko Stübner wrote:
> Hi Jacobe Zang,
>
> Am Montag, 17. Juni 2024, 09:11:12 CEST schrieb Jacobe Zang:
>> This adjust CPU nodes on Khadas Edge2.
>>
>> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
>> ---
>>   .../arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>> index 7d7cc3e76838c..5fb15d3dc23e9 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
>> @@ -160,34 +160,42 @@ vdd_3v3_sd: vdd-3v3-sd-regulator {
>>   
>>   &cpu_b0 {
>>   	cpu-supply = <&vdd_cpu_big0_s0>;
>> +	mem-supply = <&vdd_cpu_big0_mem_s0>;
> as far as I remember there has not been any binding merged that declares
> this supply. Thankfully following the double phandle below, the Edge2 is
> designed to use the same regulator for the mem-supply, so special handling
> isn't even needed.

Indeed, currently there isn't any user in the mainline tree (neither 
bindings nor drivers) for this separate regulator. Mainline cpufreq-dt 
only expects a single regulator, and as Heiko pointed out Edge2 uses the 
same physical regulator to power both the CPU core and its SRAM, so 
adding a separate mem-supply here isn't helpful.

Best regards, Alexey



  reply	other threads:[~2024-06-17  9:09 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  7:11 [PATCH v2 0/5] arm64: dts: Add board support for Khadas Edge2 Jacobe Zang
2024-06-17  7:11 ` Jacobe Zang
2024-06-17  7:11 ` [PATCH v2 1/5] arm64: dts: rockchip: Add USB-C to Khadas Edge 2 Jacobe Zang
2024-06-17  7:11   ` Jacobe Zang
2024-06-17  7:11 ` [PATCH v2 2/5] arm64: dts: rockchip: Add bluetooth rfkill to Khadas Edge2 Jacobe Zang
2024-06-17  7:11   ` Jacobe Zang
2024-06-17  9:19   ` Alexey Charkov
2024-06-17  9:19     ` Alexey Charkov
2024-06-17  9:55     ` Jacobe Zang
2024-06-17  9:55       ` Jacobe Zang
2024-06-17 10:20       ` Alexey Charkov
2024-06-17 10:20         ` Alexey Charkov
2024-06-17 11:22         ` Jacobe Zang
2024-06-17 11:22           ` Jacobe Zang
2024-06-18  0:13           ` Sebastian Reichel
2024-06-18  0:13             ` Sebastian Reichel
2024-06-18  2:34             ` Jacobe Zang
2024-06-18  2:34               ` Jacobe Zang
2024-06-17  7:11 ` [PATCH v2 3/5] arm64: dts: rockchip: Add HDMI & VOP2 to Khadas Edge 2 Jacobe Zang
2024-06-17  7:11   ` Jacobe Zang
2024-06-17 20:27   ` Heiko Stübner
2024-06-17 20:27     ` Heiko Stübner
2024-06-18  2:46     ` Jacobe Zang
2024-06-18  2:46       ` Jacobe Zang
2024-06-17  7:11 ` [PATCH v2 4/5] arm64: dts: rockchip: Add AP6275P wireless support " Jacobe Zang
2024-06-17  7:11   ` Jacobe Zang
2024-06-17  9:44   ` Alexey Charkov
2024-06-17  9:44     ` Alexey Charkov
2024-06-17 10:57     ` Jacobe Zang
2024-06-17 10:57       ` Jacobe Zang
2024-06-17 11:17       ` Alexey Charkov
2024-06-17 11:17         ` Alexey Charkov
2024-06-18  0:10         ` Sebastian Reichel
2024-06-18  0:10           ` Sebastian Reichel
2024-06-18  3:27         ` Jacobe Zang
2024-06-18  3:27           ` Jacobe Zang
2024-06-17  7:11 ` [PATCH v2 5/5] arm64: dts: rockchip: Add cpufreq support to Khadas Edge2 Jacobe Zang
2024-06-17  7:11   ` Jacobe Zang
2024-06-17  8:33   ` Heiko Stübner
2024-06-17  8:33     ` Heiko Stübner
2024-06-17  9:09     ` Alexey Charkov [this message]
2024-06-17  9:09       ` Alexey Charkov
2024-06-17  9:41       ` Jacobe Zang
2024-06-17  9:41         ` Jacobe Zang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ae179e6-3aee-415b-9dc4-298e162fbcad@gmail.com \
    --to=alchark@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=efectn@protonmail.com \
    --cc=heiko@sntech.de \
    --cc=jacobe.zang@wesion.com \
    --cc=jagan@edgeble.ai \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=nick@khadas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.