Re: [PATCH next] phy: tegra: xusb: remove a stray unlock

From: Jon Hunter <jonathanh@nvidia.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	Wayne Chang <waynec@nvidia.com>, Vinod Koul <vkoul@kernel.org>
Cc: JC Kuo <jckuo@nvidia.com>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] phy: tegra: xusb: remove a stray unlock
Date: Wed, 7 May 2025 09:47:45 +0100	[thread overview]
Message-ID: <8b152449-06fe-41f6-a56e-e5f451d60382@nvidia.com> (raw)
In-Reply-To: <a153d595-cc77-4996-a9d5-9ac0497b9e82@nvidia.com>

Hi Vinod,

On 24/04/2025 08:30, Jon Hunter wrote:
> 
> On 23/04/2025 14:08, Dan Carpenter wrote:
>> We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we
>> have moved the lock into the caller.  Unfortunately, when we moved the
>> lock this unlock was left behind and it results in a double unlock.
>> Delete it now.
>>
>> Fixes: b47158fb4295 ("phy: tegra: xusb: Use a bitmask for UTMI pad 
>> power state tracking")
>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>> ---
>>   drivers/phy/tegra/xusb-tegra186.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/ 
>> xusb-tegra186.c
>> index cc7b8a6a999f..23a23f2d64e5 100644
>> --- a/drivers/phy/tegra/xusb-tegra186.c
>> +++ b/drivers/phy/tegra/xusb-tegra186.c
>> @@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct 
>> tegra_xusb_padctl *padctl)
>>       } else {
>>           clk_disable_unprepare(priv->usb2_trk_clk);
>>       }
>> -
>> -    mutex_unlock(&padctl->lock);
>>   }
>>   static void tegra186_utmi_bias_pad_power_off(struct 
>> tegra_xusb_padctl *padctl)
> 
> 
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> 
> Thanks for catching and fixing this!

Can you pick this up please?

Thanks
Jon

-- 
nvpublic