Re: [PATCH v1 4/5] PCI: endpoint: Add NVMe endpoint function driver

[Damien Le Moal <dlemoal@kernel.org>]

On 10/7/24 19:12, Niklas Cassel wrote:
> On Mon, Oct 07, 2024 at 01:43:50PM +0900, Damien Le Moal wrote:
>> From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> 
> (snip)
> 
>> Early versions of this driver code were based on an RFC submission by
>> Alan Mikhak <alan.mikhak@sifive.com> (https://lwn.net/Articles/804369/).
>> The code however has since been completely rewritten.
> 
> Here you state that the code has been completely rewritten...
> 
> 
>>
>> Co-developed-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
>> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>> ---
>>  MAINTAINERS                                   |    7 +
>>  drivers/pci/endpoint/functions/Kconfig        |    9 +
>>  drivers/pci/endpoint/functions/Makefile       |    1 +
>>  drivers/pci/endpoint/functions/pci-epf-nvme.c | 2489 +++++++++++++++++
>>  4 files changed, 2506 insertions(+)
>>  create mode 100644 drivers/pci/endpoint/functions/pci-epf-nvme.c
> 
> (snip)
> 
>> --- /dev/null
>> +++ b/drivers/pci/endpoint/functions/pci-epf-nvme.c
>> @@ -0,0 +1,2489 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * NVMe function driver for PCI Endpoint Framework
>> + *
>> + * Copyright (C) 2019 SiFive
> 
> ...yet here you claim Copyright (C) SiFive.
> 
> *If* the code has been completely rewritten, then you probably should
> put yourself and/or your current employeer as the copyright holder.

Oops. One thing I forgot to rewrite :)
Will change the copyright in v2.

> 
> 
> Kind regards,
> Niklas


-- 
Damien Le Moal
Western Digital Research