All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-nvme@lists.infradead.org, "Keith Busch" <kbusch@kernel.org>,
	"Christoph Hellwig" <hch@lst.de>,
	"Sagi Grimberg" <sagi@grimberg.me>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	linux-pci@vger.kernel.org,
	"Rick Wertenbroek" <rick.wertenbroek@gmail.com>
Subject: Re: [PATCH v1 4/5] PCI: endpoint: Add NVMe endpoint function driver
Date: Mon, 7 Oct 2024 12:12:47 +0200	[thread overview]
Message-ID: <ZwO0H0WCnORq9EzQ@ryzen> (raw)
In-Reply-To: <20241007044351.157912-5-dlemoal@kernel.org>

On Mon, Oct 07, 2024 at 01:43:50PM +0900, Damien Le Moal wrote:
> From: Damien Le Moal <damien.lemoal@opensource.wdc.com>

(snip)

> Early versions of this driver code were based on an RFC submission by
> Alan Mikhak <alan.mikhak@sifive.com> (https://lwn.net/Articles/804369/).
> The code however has since been completely rewritten.

Here you state that the code has been completely rewritten...


> 
> Co-developed-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
>  MAINTAINERS                                   |    7 +
>  drivers/pci/endpoint/functions/Kconfig        |    9 +
>  drivers/pci/endpoint/functions/Makefile       |    1 +
>  drivers/pci/endpoint/functions/pci-epf-nvme.c | 2489 +++++++++++++++++
>  4 files changed, 2506 insertions(+)
>  create mode 100644 drivers/pci/endpoint/functions/pci-epf-nvme.c

(snip)

> --- /dev/null
> +++ b/drivers/pci/endpoint/functions/pci-epf-nvme.c
> @@ -0,0 +1,2489 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * NVMe function driver for PCI Endpoint Framework
> + *
> + * Copyright (C) 2019 SiFive

...yet here you claim Copyright (C) SiFive.

*If* the code has been completely rewritten, then you probably should
put yourself and/or your current employeer as the copyright holder.


Kind regards,
Niklas


  reply	other threads:[~2024-10-07 10:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-07  4:43 [PATCH v1 0/5] NVMe PCI endpoint function driver Damien Le Moal
2024-10-07  4:43 ` [PATCH v1 1/5] nvmet: rename and move nvmet_get_log_page_len() Damien Le Moal
2024-10-10  8:27   ` Christoph Hellwig
2024-10-20 23:55   ` Sagi Grimberg
2024-10-07  4:43 ` [PATCH v1 2/5] nvmef: export nvmef_create_ctrl() Damien Le Moal
2024-10-07  4:43 ` [PATCH v1 3/5] nvmef: Introduce the NVME_OPT_HIDDEN_NS option Damien Le Moal
2024-10-07  4:43 ` [PATCH v1 4/5] PCI: endpoint: Add NVMe endpoint function driver Damien Le Moal
2024-10-07 10:12   ` Niklas Cassel [this message]
2024-10-07 10:26     ` Damien Le Moal
2024-10-09  7:28       ` Rick Wertenbroek
2024-10-09  8:16         ` Damien Le Moal
2024-10-10  1:10   ` kernel test robot
2024-10-10  3:33   ` kernel test robot
2024-10-07  4:43 ` [PATCH v1 5/5] PCI: endpoint: Document the " Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwO0H0WCnORq9EzQ@ryzen \
    --to=cassel@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=rick.wertenbroek@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.