[alobakin:idpf-libie-new 60/74] drivers/net/ethernet/intel/libeth/rx.c:180:11-12: WARNING kvmalloc is used to allocate this memory at line 164 (fwd)

[alobakin:idpf-libie-new 60/74] drivers/net/ethernet/intel/libeth/rx.c:180:11-12: WARNING kvmalloc is used to allocate this memory at line 164 (fwd)

[Julia Lawall]

It looks like kvfree should be used.

---------- Forwarded message ----------
Date: Sun, 31 Mar 2024 06:12:57 +0800
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: [alobakin:idpf-libie-new 60/74]
    drivers/net/ethernet/intel/libeth/rx.c:180:11-12: WARNING kvmalloc is used
    to allocate this memory at line 164

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Alexander Lobakin <aleksander.lobakin@intel.com>

tree:   https://github.com/alobakin/linux idpf-libie-new
head:   f7e5ff9972ee9afd57afebedbc55c37173d39dd3
commit: 1529de47fcee1dc7805a0ddfd8c8d75bd4a99c36 [60/74] libie: support native XDP and register memory model
:::::: branch date: 29 hours ago
:::::: commit date: 2 days ago
config: i386-randconfig-052-20240329 (https://download.01.org/0day-ci/archive/20240331/202403310626.XY01b0CL-lkp@intel.com/config)
compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202403310626.XY01b0CL-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/intel/libeth/rx.c:180:11-12: WARNING kvmalloc is used to allocate this memory at line 164

vim +180 drivers/net/ethernet/intel/libeth/rx.c

e5e39cdea755af Alexander Lobakin 2023-12-04  128
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  129  /**
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  130   * libeth_rx_fq_create - create a PP with the default libeth settings
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  131   * @fq: buffer queue struct to fill
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  132   * @napi: &napi_struct covering this PP (no usage outside its poll loops)
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  133   *
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  134   * Return: %0 on success, -%errno on failure.
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  135   */
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  136  int libeth_rx_fq_create(struct libeth_fq *fq, struct napi_struct *napi)
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  137  {
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  138  	struct page_pool_params pp = {
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  139  		.flags		= PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  140  		.order		= LIBETH_RX_PAGE_ORDER,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  141  		.pool_size	= fq->count,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  142  		.nid		= NUMA_NO_NODE,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  143  		.dev		= napi->dev->dev.parent,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  144  		.netdev		= napi->dev,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  145  		.napi		= napi,
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  146  	};
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  147  	struct libeth_fqe *fqes;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  148  	struct page_pool *pool;
1529de47fcee1d Alexander Lobakin 2023-12-08  149  	int ret;
1529de47fcee1d Alexander Lobakin 2023-12-08  150
1529de47fcee1d Alexander Lobakin 2023-12-08  151  	pp.dma_dir = fq->xdp ? DMA_BIDIRECTIONAL : DMA_FROM_DEVICE;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  152
e5e39cdea755af Alexander Lobakin 2023-12-04  153  	if (!fq->hsplit)
e5e39cdea755af Alexander Lobakin 2023-12-04  154  		ret = libeth_rx_page_pool_params(fq, &pp);
e5e39cdea755af Alexander Lobakin 2023-12-04  155  	else
e5e39cdea755af Alexander Lobakin 2023-12-04  156  		ret = libeth_rx_page_pool_params_zc(fq, &pp);
e5e39cdea755af Alexander Lobakin 2023-12-04  157  	if (!ret)
e5e39cdea755af Alexander Lobakin 2023-12-04  158  		return -EINVAL;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  159
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  160  	pool = page_pool_create(&pp);
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  161  	if (IS_ERR(pool))
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  162  		return PTR_ERR(pool);
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  163
4fe2fda36b31e0 Alexander Lobakin 2023-06-20 @164  	fqes = kvcalloc(fq->count, sizeof(*fqes), GFP_KERNEL);
1529de47fcee1d Alexander Lobakin 2023-12-08  165  	if (!fqes) {
1529de47fcee1d Alexander Lobakin 2023-12-08  166  		ret = -ENOMEM;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  167  		goto err_buf;
1529de47fcee1d Alexander Lobakin 2023-12-08  168  	}
1529de47fcee1d Alexander Lobakin 2023-12-08  169
1529de47fcee1d Alexander Lobakin 2023-12-08  170  	ret = xdp_reg_page_pool(pool);
1529de47fcee1d Alexander Lobakin 2023-12-08  171  	if (ret)
1529de47fcee1d Alexander Lobakin 2023-12-08  172  		goto err_mem;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  173
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  174  	fq->fqes = fqes;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  175  	fq->pp = pool;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  176
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  177  	return 0;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  178
1529de47fcee1d Alexander Lobakin 2023-12-08  179  err_mem:
1529de47fcee1d Alexander Lobakin 2023-12-08 @180  	kfree(fqes);
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  181  err_buf:
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  182  	page_pool_destroy(pool);
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  183
1529de47fcee1d Alexander Lobakin 2023-12-08  184  	return ret;
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  185  }
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  186  EXPORT_SYMBOL_NS_GPL(libeth_rx_fq_create, LIBETH);
4fe2fda36b31e0 Alexander Lobakin 2023-06-20  187

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [alobakin:idpf-libie-new 60/74] drivers/net/ethernet/intel/libeth/rx.c:180:11-12: WARNING kvmalloc is used to allocate this memory at line 164 (fwd)

[Alexander Lobakin]

From: Julia Lawall <julia.lawall@inria.fr>
Date: Sat, 30 Mar 2024 18:54:52 -0400 (EDT)

> It looks like kvfree should be used.

Fixed in the current tree, thanks for spotting.

> 
> ---------- Forwarded message ----------
> Date: Sun, 31 Mar 2024 06:12:57 +0800
> From: kernel test robot <lkp@intel.com>
> To: oe-kbuild@lists.linux.dev
> Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
> Subject: [alobakin:idpf-libie-new 60/74]
>     drivers/net/ethernet/intel/libeth/rx.c:180:11-12: WARNING kvmalloc is used
>     to allocate this memory at line 164

[...]

Thanks,
Olek