* [PATCH] altera_jtaguart: Use dev_err() to report error attaching IRQ
@ 2024-10-29 13:03 Tobias Klauser
2024-10-30 5:16 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2024-10-29 13:03 UTC (permalink / raw)
To: linux-serial; +Cc: Greg Kroah-Hartman, Jiri Slaby
In case of multiple Altera JTAG UART ports available on the system, the
error message will contain information about the port for which
attaching the IRQ handler failed.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/tty/serial/altera_jtaguart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
index 6162108c758e..4c7bde5dd856 100644
--- a/drivers/tty/serial/altera_jtaguart.c
+++ b/drivers/tty/serial/altera_jtaguart.c
@@ -175,7 +175,7 @@ static int altera_jtaguart_startup(struct uart_port *port)
ret = request_irq(port->irq, altera_jtaguart_interrupt, 0,
DRV_NAME, port);
if (ret) {
- pr_err(DRV_NAME ": unable to attach Altera JTAG UART %d "
+ dev_err(port->dev, "unable to attach Altera JTAG UART %d "
"interrupt vector=%d\n", port->line, port->irq);
return ret;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] altera_jtaguart: Use dev_err() to report error attaching IRQ
2024-10-29 13:03 [PATCH] altera_jtaguart: Use dev_err() to report error attaching IRQ Tobias Klauser
@ 2024-10-30 5:16 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2024-10-30 5:16 UTC (permalink / raw)
To: Tobias Klauser, linux-serial; +Cc: Greg Kroah-Hartman
On 29. 10. 24, 14:03, Tobias Klauser wrote:
> In case of multiple Altera JTAG UART ports available on the system, the
> error message will contain information about the port for which
> attaching the IRQ handler failed.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-30 5:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 13:03 [PATCH] altera_jtaguart: Use dev_err() to report error attaching IRQ Tobias Klauser
2024-10-30 5:16 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.