From: "Maxime Ripard" <mripard@kernel.org>
To: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Alexey Brodkin" <abrodkin@synopsys.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Hui Pu" <Hui.Pu@gehealthcare.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Corbet" <corbet@lwn.net>,
"Kevin Hilman" <khilman@baylibre.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Liu Ying" <victor.liu@nxp.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Phong LE" <ple@baylibre.com>, "Robert Foss" <rfoss@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH v3 15/22] drm/bridge: imx8qxp-pxl2dpi: imx8qxp_pxl2dpi_find_next_bridge: return int, not ERR_PTR
Date: Wed, 17 Dec 2025 10:20:14 +0000 [thread overview]
Message-ID: <8c0e9399c1f8bb388eb3f0ee2cf37089@kernel.org> (raw)
In-Reply-To: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-15-b5165fab8058@bootlin.com>
On Tue, 16 Dec 2025 18:58:48 +0100, Luca Ceresoli wrote:
> In preparation for using bridge->next_bridge, we need to ensure that it
> will never contain anything but NULL or a valid bridge pointer. Current
> code stores an ERR_PTR when imx8qxp_pxl2dpi_find_next_bridge() errors
> out. Instead of fixing that after the facts in the caller, change the
> function to internally set the next_pointer and just return an int error
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Maxime Ripard" <mripard@kernel.org>
To: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Alexey Brodkin" <abrodkin@synopsys.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Hui Pu" <Hui.Pu@gehealthcare.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Corbet" <corbet@lwn.net>,
"Kevin Hilman" <khilman@baylibre.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Liu Ying" <victor.liu@nxp.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Phong LE" <ple@baylibre.com>, "Robert Foss" <rfoss@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH v3 15/22] drm/bridge: imx8qxp-pxl2dpi: imx8qxp_pxl2dpi_find_next_bridge: return int, not ERR_PTR
Date: Wed, 17 Dec 2025 10:20:14 +0000 [thread overview]
Message-ID: <8c0e9399c1f8bb388eb3f0ee2cf37089@kernel.org> (raw)
In-Reply-To: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-15-b5165fab8058@bootlin.com>
On Tue, 16 Dec 2025 18:58:48 +0100, Luca Ceresoli wrote:
> In preparation for using bridge->next_bridge, we need to ensure that it
> will never contain anything but NULL or a valid bridge pointer. Current
> code stores an ERR_PTR when imx8qxp_pxl2dpi_find_next_bridge() errors
> out. Instead of fixing that after the facts in the caller, change the
> function to internally set the next_pointer and just return an int error
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-12-17 10:20 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 17:58 [PATCH v3 00/22] drm/bridge: add of_drm_find_and_get_bridge() and a managed *next_bridge, deprecate of_drm_find_bridge() Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-16 17:58 ` [PATCH v3 01/22] drm/bridge: add of_drm_find_and_get_bridge() Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:15 ` Maxime Ripard
2025-12-17 10:15 ` Maxime Ripard
2025-12-17 14:31 ` Luca Ceresoli
2025-12-17 14:31 ` Luca Ceresoli
2025-12-18 12:50 ` Maxime Ripard
2025-12-18 12:50 ` Maxime Ripard
2025-12-18 14:23 ` Luca Ceresoli
2025-12-18 14:23 ` Luca Ceresoli
2025-12-16 17:58 ` [PATCH v3 02/22] drm/bridge: deprecate of_drm_find_bridge() Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-16 17:58 ` [PATCH v3 03/22] drm/todo: add entry about converting to of_drm_find_and_get_bridge() Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-16 17:58 ` [PATCH v3 04/22] drm/bridge: make of_drm_find_bridge() a wrapper of of_drm_find_and_get_bridge() Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:16 ` Maxime Ripard
2025-12-17 10:16 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 05/22] drm/arcpgu: convert to of_drm_find_and_get_bridge() Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:16 ` Maxime Ripard
2025-12-17 10:16 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 06/22] drm/bridge: add next_bridge pointer to struct drm_bridge Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:17 ` Maxime Ripard
2025-12-17 10:17 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 07/22] drm/bridge: ite-it66121: get/put the next bridge Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:17 ` Maxime Ripard
2025-12-17 10:17 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 08/22] drm/bridge: imx8qxp-pixel-combiner: " Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:17 ` Maxime Ripard
2025-12-17 10:17 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 09/22] drm/bridge: simple-bridge: " Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:41 ` Maxime Ripard
2025-12-17 10:41 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 10/22] drm/meson: encoder_cvbs: " Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:17 ` Maxime Ripard
2025-12-17 10:17 ` Maxime Ripard
2025-12-21 21:50 ` Martin Blumenstingl
2025-12-21 21:50 ` Martin Blumenstingl
2025-12-16 17:58 ` [PATCH v3 11/22] drm/meson: encoder_dsi: " Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:18 ` Maxime Ripard
2025-12-17 10:18 ` Maxime Ripard
2025-12-21 21:50 ` Martin Blumenstingl
2025-12-21 21:50 ` Martin Blumenstingl
2025-12-16 17:58 ` [PATCH v3 12/22] drm/meson: encoder_hdmi: " Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:18 ` Maxime Ripard
2025-12-17 10:18 ` Maxime Ripard
2025-12-21 21:51 ` Martin Blumenstingl
2025-12-21 21:51 ` Martin Blumenstingl
2025-12-22 7:30 ` Luca Ceresoli
2025-12-22 7:30 ` Luca Ceresoli
2025-12-22 10:38 ` Martin Blumenstingl
2025-12-22 10:38 ` Martin Blumenstingl
2025-12-16 17:58 ` [PATCH v3 13/22] drm/bridge: imx8qxp-pxl2dpi: simplify put of device_node pointers Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:18 ` Maxime Ripard
2025-12-17 10:18 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 14/22] drm/bridge: imx8qxp-pxl2dpi: remove excess error message Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:19 ` Maxime Ripard
2025-12-17 10:19 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 15/22] drm/bridge: imx8qxp-pxl2dpi: imx8qxp_pxl2dpi_find_next_bridge: return int, not ERR_PTR Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:20 ` Maxime Ripard [this message]
2025-12-17 10:20 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 16/22] drm/bridge: imx8qxp-pxl2dpi: get/put the next bridge Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:20 ` Maxime Ripard
2025-12-17 10:20 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 17/22] drm/bridge: imx8qxp-pxl2dpi: get/put the companion bridge Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:20 ` Maxime Ripard
2025-12-17 10:20 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 18/22] drm/bridge: imx8qxp-pixel-link: simplify logic to find next bridge Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-16 17:58 ` [PATCH v3 19/22] drm/bridge: imx8qxp-pixel-link: simplify freeing of the remote device_node Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:25 ` Maxime Ripard
2025-12-17 10:25 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 20/22] drm/bridge: imx8qxp-pixel-link: remove excess error message Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:20 ` Maxime Ripard
2025-12-17 10:20 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 21/22] drm/bridge: imx8qxp-pixel-link: imx8qxp_pixel_link_find_next_bridge: return int, not ERR_PTR Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:25 ` Maxime Ripard
2025-12-17 10:25 ` Maxime Ripard
2025-12-16 17:58 ` [PATCH v3 22/22] drm/bridge: imx8qxp-pixel-link: get/put the next bridge Luca Ceresoli
2025-12-16 17:58 ` Luca Ceresoli
2025-12-17 10:25 ` Maxime Ripard
2025-12-17 10:25 ` Maxime Ripard
2025-12-30 9:17 ` [PATCH v3 00/22] drm/bridge: add of_drm_find_and_get_bridge() and a managed *next_bridge, deprecate of_drm_find_bridge() Luca Ceresoli
2025-12-30 9:17 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c0e9399c1f8bb388eb3f0ee2cf37089@kernel.org \
--to=mripard@kernel.org \
--cc=Hui.Pu@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=ple@baylibre.com \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.