Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

["Mittal, Anuj" <anuj.mittal@intel.com>]

On Tue, 2023-10-31 at 19:33 -0700, Tim Orling wrote:
> 
> 
> On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com>
> wrote:
> > On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
> > > Thank you for your submission. Patchtest identified one
> > > or more issues with the patch. Please see the log below for
> > > more information:
> > > 
> > > ---
> > > Testing patch /home/patchtest/share/mboxes/patchtest-shorten-
> > > test-
> > > result-outputs.patch
> > > 
> > > FAIL: test CVE presence in commit message: A CVE tag should be
> > > provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
> > > (test_mbox.TestMbox.test_cve_presence_in_commit_message)
> > 
> > Is this a requirement to have this in commit message in this
> > format? I
> > don't think this was being followed until now. A lot of patches
> > seem to
> > be failing this test as a result.
> > 
> 
> 
> This was required when patchtest was running previously. It has been
> ignored for a while now, but that does not mean we should not enforce
> it. It should be documented as required.
> 
> The tags allow for machines to parse the relevant info. Anything else
> is purely random and chaos.

The tag is already required to be present in the CVE patch itself which
is/can be parsed by scripts which actually I think is a better way of
detecting whether a CVE is patched rather than looking at commit
messages.

If having it in a specific format in commit message as well helps,
sure. It shouldn't take time to add it but we seem to be adding too
many rules ...

Thanks,

Anuj

> 
> > 
> > The wiki just mentions that CVE number should be in commit message.
> > 
> > Thanks,
> > 
> > Anuj
> > 
> > > 
> > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> > > PASS: test Signed-off-by presence
> > > (test_mbox.TestMbox.test_signed_off_by_presence)
> > > PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> > > PASS: test commit message presence
> > > (test_mbox.TestMbox.test_commit_message_presence)
> > > PASS: test max line length
> > > (test_metadata.TestMetadata.test_max_line_length)
> > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> > > PASS: test non-AUH upgrade
> > > (test_mbox.TestMbox.test_non_auh_upgrade)
> > > PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> > > PASS: test shortlog format
> > > (test_mbox.TestMbox.test_shortlog_format)
> > > PASS: test shortlog length
> > > (test_mbox.TestMbox.test_shortlog_length)
> > > 
> > > SKIP: pretest lic files chksum modified not mentioned: No
> > > modified
> > > recipes, skipping pretest
> > > (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not
> > > _men
> > > tioned)
> > > SKIP: pretest src uri left files: No modified recipes, skipping
> > > pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
> > > SKIP: test CVE tag format: No new CVE patches introduced
> > > (test_patch.TestPatch.test_cve_tag_format)
> > > SKIP: test Signed-off-by presence: No new CVE patches introduced
> > > (test_patch.TestPatch.test_signed_off_by_presence)
> > > SKIP: test Upstream-Status presence: No new CVE patches
> > > introduced
> > > (test_patch.TestPatch.test_upstream_status_presence_format)
> > > SKIP: test bugzilla entry format: No bug ID found
> > > (test_mbox.TestMbox.test_bugzilla_entry_format)
> > > SKIP: test lic files chksum modified not mentioned: No modified
> > > recipes, skipping test
> > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_me
> > > ntio
> > > ned)
> > > SKIP: test lic files chksum presence: No added recipes, skipping
> > > test
> > > (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> > > SKIP: test license presence: No added recipes, skipping test
> > > (test_metadata.TestMetadata.test_license_presence)
> > > SKIP: test series merge on head: Merge test is disabled for now
> > > (test_mbox.TestMbox.test_series_merge_on_head)
> > > SKIP: test src uri left files: No modified recipes, skipping
> > > pretest
> > > (test_metadata.TestMetadata.test_src_uri_left_files)
> > > SKIP: test summary presence: No added recipes, skipping test
> > > (test_metadata.TestMetadata.test_summary_presence)
> > > SKIP: test target mailing list: Series merged, no reason to check
> > > other mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> > > 
> > > ---
> > > 
> > > Please address the issues identified and
> > > submit a new revision of the patch, or alternatively, reply to
> > > this
> > > email with an explanation of why the patch should be accepted. If
> > > you
> > > believe these results are due to an error in patchtest, please
> > > submit
> > > a
> > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest'
> > > category
> > > under 'Yocto Project Subprojects'). For more information on
> > > specific
> > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest.
> > > Thank
> > > you!
> > > 
> > > 
> > > 
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#189893):
> > https://lists.openembedded.org/g/openembedded-core/message/189893
> > Mute This Topic: https://lists.openembedded.org/mt/102275009/924729
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub
> > [ticotimo@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >