Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[patchtest]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

FAIL: test CVE presence in commit message: A CVE tag should be provided in the commit message with format: "CVE: CVE-YYYY-XXXX" (test_mbox.TestMbox.test_cve_presence_in_commit_message)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest lic files chksum modified not mentioned: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_mentioned)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Michael Opdenacker]

Hi Trevor,

On 31.10.23 at 15:20, Trevor Gamblin wrote:
> Thank you for your submission. Patchtest identified one
> or more issues with the patch. Please see the log below for
> more information:
>
> ---
> Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

Thanks for this very useful service!

However, could the replies have an "In-Reply-To" header so that e-mail 
clients can put the reply in the same thread as the patch?

Happy to create an entry in Bugzilla if this helps.
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Trevor Gamblin]

On 2023-10-31 10:54, Michael Opdenacker wrote:
> Hi Trevor,
>
> On 31.10.23 at 15:20, Trevor Gamblin wrote:
>> Thank you for your submission. Patchtest identified one
>> or more issues with the patch. Please see the log below for
>> more information:
>>
>> ---
>> Testing patch 
>> /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch
>
> Thanks for this very useful service!
>
> However, could the replies have an "In-Reply-To" header so that e-mail 
> clients can put the reply in the same thread as the patch?

Hi Michael,

There is actually already a bug open: 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15270

I'm looking at it now, but still figuring out the implementation.

- Trevor

>
> Happy to create an entry in Bugzilla if this helps.
> Cheers
> Michael.
>

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Mittal, Anuj]

On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
> Thank you for your submission. Patchtest identified one
> or more issues with the patch. Please see the log below for
> more information:
> 
> ---
> Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-
> result-outputs.patch
> 
> FAIL: test CVE presence in commit message: A CVE tag should be
> provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
> (test_mbox.TestMbox.test_cve_presence_in_commit_message)

Is this a requirement to have this in commit message in this format? I
don't think this was being followed until now. A lot of patches seem to
be failing this test as a result.

The wiki just mentions that CVE number should be in commit message.

Thanks,

Anuj

> 
> PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> PASS: test Signed-off-by presence
> (test_mbox.TestMbox.test_signed_off_by_presence)
> PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> PASS: test commit message presence
> (test_mbox.TestMbox.test_commit_message_presence)
> PASS: test max line length
> (test_metadata.TestMetadata.test_max_line_length)
> PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
> PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
> 
> SKIP: pretest lic files chksum modified not mentioned: No modified
> recipes, skipping pretest
> (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_men
> tioned)
> SKIP: pretest src uri left files: No modified recipes, skipping
> pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
> SKIP: test CVE tag format: No new CVE patches introduced
> (test_patch.TestPatch.test_cve_tag_format)
> SKIP: test Signed-off-by presence: No new CVE patches introduced
> (test_patch.TestPatch.test_signed_off_by_presence)
> SKIP: test Upstream-Status presence: No new CVE patches introduced
> (test_patch.TestPatch.test_upstream_status_presence_format)
> SKIP: test bugzilla entry format: No bug ID found
> (test_mbox.TestMbox.test_bugzilla_entry_format)
> SKIP: test lic files chksum modified not mentioned: No modified
> recipes, skipping test
> (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentio
> ned)
> SKIP: test lic files chksum presence: No added recipes, skipping test
> (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> SKIP: test license presence: No added recipes, skipping test
> (test_metadata.TestMetadata.test_license_presence)
> SKIP: test series merge on head: Merge test is disabled for now
> (test_mbox.TestMbox.test_series_merge_on_head)
> SKIP: test src uri left files: No modified recipes, skipping pretest
> (test_metadata.TestMetadata.test_src_uri_left_files)
> SKIP: test summary presence: No added recipes, skipping test
> (test_metadata.TestMetadata.test_summary_presence)
> SKIP: test target mailing list: Series merged, no reason to check
> other mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> 
> ---
> 
> Please address the issues identified and
> submit a new revision of the patch, or alternatively, reply to this
> email with an explanation of why the patch should be accepted. If you
> believe these results are due to an error in patchtest, please submit
> a
> bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest'
> category
> under 'Yocto Project Subprojects'). For more information on specific
> failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> you!
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#189845):
> https://lists.openembedded.org/g/openembedded-core/message/189845
> Mute This Topic: https://lists.openembedded.org/mt/102275009/3616702
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> anuj.mittal@intel.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Tim Orling]

[-- Attachment #1: Type: text/plain, Size: 4734 bytes --]

On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com> wrote:

> On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
> > Thank you for your submission. Patchtest identified one
> > or more issues with the patch. Please see the log below for
> > more information:
> >
> > ---
> > Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-
> > result-outputs.patch
> >
> > FAIL: test CVE presence in commit message: A CVE tag should be
> > provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
> > (test_mbox.TestMbox.test_cve_presence_in_commit_message)
>
> Is this a requirement to have this in commit message in this format? I
> don't think this was being followed until now. A lot of patches seem to
> be failing this test as a result.
>

This was required when patchtest was running previously. It has been
ignored for a while now, but that does not mean we should not enforce it.
It should be documented as required.

The tags allow for machines to parse the relevant info. Anything else is
purely random and chaos.


> The wiki just mentions that CVE number should be in commit message.
>
> Thanks,
>
> Anuj
>
> >
> > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> > PASS: test Signed-off-by presence
> > (test_mbox.TestMbox.test_signed_off_by_presence)
> > PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> > PASS: test commit message presence
> > (test_mbox.TestMbox.test_commit_message_presence)
> > PASS: test max line length
> > (test_metadata.TestMetadata.test_max_line_length)
> > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> > PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
> > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
> >
> > SKIP: pretest lic files chksum modified not mentioned: No modified
> > recipes, skipping pretest
> > (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_men
> > tioned)
> > SKIP: pretest src uri left files: No modified recipes, skipping
> > pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
> > SKIP: test CVE tag format: No new CVE patches introduced
> > (test_patch.TestPatch.test_cve_tag_format)
> > SKIP: test Signed-off-by presence: No new CVE patches introduced
> > (test_patch.TestPatch.test_signed_off_by_presence)
> > SKIP: test Upstream-Status presence: No new CVE patches introduced
> > (test_patch.TestPatch.test_upstream_status_presence_format)
> > SKIP: test bugzilla entry format: No bug ID found
> > (test_mbox.TestMbox.test_bugzilla_entry_format)
> > SKIP: test lic files chksum modified not mentioned: No modified
> > recipes, skipping test
> > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentio
> > ned)
> > SKIP: test lic files chksum presence: No added recipes, skipping test
> > (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> > SKIP: test license presence: No added recipes, skipping test
> > (test_metadata.TestMetadata.test_license_presence)
> > SKIP: test series merge on head: Merge test is disabled for now
> > (test_mbox.TestMbox.test_series_merge_on_head)
> > SKIP: test src uri left files: No modified recipes, skipping pretest
> > (test_metadata.TestMetadata.test_src_uri_left_files)
> > SKIP: test summary presence: No added recipes, skipping test
> > (test_metadata.TestMetadata.test_summary_presence)
> > SKIP: test target mailing list: Series merged, no reason to check
> > other mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> >
> > ---
> >
> > Please address the issues identified and
> > submit a new revision of the patch, or alternatively, reply to this
> > email with an explanation of why the patch should be accepted. If you
> > believe these results are due to an error in patchtest, please submit
> > a
> > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest'
> > category
> > under 'Yocto Project Subprojects'). For more information on specific
> > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> > you!
> >
> >
> >
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#189893):
> https://lists.openembedded.org/g/openembedded-core/message/189893
> Mute This Topic: https://lists.openembedded.org/mt/102275009/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 6418 bytes --]

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Mittal, Anuj]

On Tue, 2023-10-31 at 19:33 -0700, Tim Orling wrote:
> 
> 
> On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com>
> wrote:
> > On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
> > > Thank you for your submission. Patchtest identified one
> > > or more issues with the patch. Please see the log below for
> > > more information:
> > > 
> > > ---
> > > Testing patch /home/patchtest/share/mboxes/patchtest-shorten-
> > > test-
> > > result-outputs.patch
> > > 
> > > FAIL: test CVE presence in commit message: A CVE tag should be
> > > provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
> > > (test_mbox.TestMbox.test_cve_presence_in_commit_message)
> > 
> > Is this a requirement to have this in commit message in this
> > format? I
> > don't think this was being followed until now. A lot of patches
> > seem to
> > be failing this test as a result.
> > 
> 
> 
> This was required when patchtest was running previously. It has been
> ignored for a while now, but that does not mean we should not enforce
> it. It should be documented as required.
> 
> The tags allow for machines to parse the relevant info. Anything else
> is purely random and chaos.

The tag is already required to be present in the CVE patch itself which
is/can be parsed by scripts which actually I think is a better way of
detecting whether a CVE is patched rather than looking at commit
messages.

If having it in a specific format in commit message as well helps,
sure. It shouldn't take time to add it but we seem to be adding too
many rules ...

Thanks,

Anuj

> 
> > 
> > The wiki just mentions that CVE number should be in commit message.
> > 
> > Thanks,
> > 
> > Anuj
> > 
> > > 
> > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> > > PASS: test Signed-off-by presence
> > > (test_mbox.TestMbox.test_signed_off_by_presence)
> > > PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> > > PASS: test commit message presence
> > > (test_mbox.TestMbox.test_commit_message_presence)
> > > PASS: test max line length
> > > (test_metadata.TestMetadata.test_max_line_length)
> > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> > > PASS: test non-AUH upgrade
> > > (test_mbox.TestMbox.test_non_auh_upgrade)
> > > PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> > > PASS: test shortlog format
> > > (test_mbox.TestMbox.test_shortlog_format)
> > > PASS: test shortlog length
> > > (test_mbox.TestMbox.test_shortlog_length)
> > > 
> > > SKIP: pretest lic files chksum modified not mentioned: No
> > > modified
> > > recipes, skipping pretest
> > > (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not
> > > _men
> > > tioned)
> > > SKIP: pretest src uri left files: No modified recipes, skipping
> > > pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
> > > SKIP: test CVE tag format: No new CVE patches introduced
> > > (test_patch.TestPatch.test_cve_tag_format)
> > > SKIP: test Signed-off-by presence: No new CVE patches introduced
> > > (test_patch.TestPatch.test_signed_off_by_presence)
> > > SKIP: test Upstream-Status presence: No new CVE patches
> > > introduced
> > > (test_patch.TestPatch.test_upstream_status_presence_format)
> > > SKIP: test bugzilla entry format: No bug ID found
> > > (test_mbox.TestMbox.test_bugzilla_entry_format)
> > > SKIP: test lic files chksum modified not mentioned: No modified
> > > recipes, skipping test
> > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_me
> > > ntio
> > > ned)
> > > SKIP: test lic files chksum presence: No added recipes, skipping
> > > test
> > > (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> > > SKIP: test license presence: No added recipes, skipping test
> > > (test_metadata.TestMetadata.test_license_presence)
> > > SKIP: test series merge on head: Merge test is disabled for now
> > > (test_mbox.TestMbox.test_series_merge_on_head)
> > > SKIP: test src uri left files: No modified recipes, skipping
> > > pretest
> > > (test_metadata.TestMetadata.test_src_uri_left_files)
> > > SKIP: test summary presence: No added recipes, skipping test
> > > (test_metadata.TestMetadata.test_summary_presence)
> > > SKIP: test target mailing list: Series merged, no reason to check
> > > other mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> > > 
> > > ---
> > > 
> > > Please address the issues identified and
> > > submit a new revision of the patch, or alternatively, reply to
> > > this
> > > email with an explanation of why the patch should be accepted. If
> > > you
> > > believe these results are due to an error in patchtest, please
> > > submit
> > > a
> > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest'
> > > category
> > > under 'Yocto Project Subprojects'). For more information on
> > > specific
> > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest.
> > > Thank
> > > you!
> > > 
> > > 
> > > 
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#189893):
> > https://lists.openembedded.org/g/openembedded-core/message/189893
> > Mute This Topic: https://lists.openembedded.org/mt/102275009/924729
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub
> > [ticotimo@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Marta Rybczynska]

[-- Attachment #1: Type: text/plain, Size: 2397 bytes --]

On Wed, 1 Nov 2023, 11:48 Anuj Mittal, <anuj.mittal@intel.com> wrote:

> On Tue, 2023-10-31 at 19:33 -0700, Tim Orling wrote:
> >
> >
> > On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com>
> > wrote:
> > > On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
> > > > Thank you for your submission. Patchtest identified one
> > > > or more issues with the patch. Please see the log below for
> > > > more information:
> > > >
> > > > ---
> > > > Testing patch /home/patchtest/share/mboxes/patchtest-shorten-
> > > > test-
> > > > result-outputs.patch
> > > >
> > > > FAIL: test CVE presence in commit message: A CVE tag should be
> > > > provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
> > > > (test_mbox.TestMbox.test_cve_presence_in_commit_message)
> > >
> > > Is this a requirement to have this in commit message in this
> > > format? I
> > > don't think this was being followed until now. A lot of patches
> > > seem to
> > > be failing this test as a result.
> > >
> >
> >
> > This was required when patchtest was running previously. It has been
> > ignored for a while now, but that does not mean we should not enforce
> > it. It should be documented as required.
> >
> > The tags allow for machines to parse the relevant info. Anything else
> > is purely random and chaos.
>
> The tag is already required to be present in the CVE patch itself which
> is/can be parsed by scripts which actually I think is a better way of
> detecting whether a CVE is patched rather than looking at commit
> messages.
>
> If having it in a specific format in commit message as well helps,
> sure. It shouldn't take time to add it but we seem to be adding too
> many rules ...
>
>
(adding Steve)

I agree with Anuj, and I do not remember seeing a rule to put the
CVE number in the commit message. We already have it in the
patch file name (recommended) and inside the patch file itself.
Those two places are enough in my opinion. In fact, it will likely
be there in the commit message (its title), so repeating it does
not make much logical sense.

In fact, I have an update of the manual with more detailed information
on submitting CVE fixes and looking for a resolution of this question
to submit it :)

Steve, does such additional tag in the commit message make it
easier for you?

Kind regards,
Marta

[-- Attachment #2: Type: text/html, Size: 3477 bytes --]

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Steve Sakoman]

On Tue, Oct 31, 2023 at 7:31 PM Marta Rybczynska <rybczynska@gmail.com> wrote:
>
>
>
>
> On Wed, 1 Nov 2023, 11:48 Anuj Mittal, <anuj.mittal@intel.com> wrote:
>>
>> On Tue, 2023-10-31 at 19:33 -0700, Tim Orling wrote:
>> >
>> >
>> > On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com>
>> > wrote:
>> > > On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
>> > > > Thank you for your submission. Patchtest identified one
>> > > > or more issues with the patch. Please see the log below for
>> > > > more information:
>> > > >
>> > > > ---
>> > > > Testing patch /home/patchtest/share/mboxes/patchtest-shorten-
>> > > > test-
>> > > > result-outputs.patch
>> > > >
>> > > > FAIL: test CVE presence in commit message: A CVE tag should be
>> > > > provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
>> > > > (test_mbox.TestMbox.test_cve_presence_in_commit_message)
>> > >
>> > > Is this a requirement to have this in commit message in this
>> > > format? I
>> > > don't think this was being followed until now. A lot of patches
>> > > seem to
>> > > be failing this test as a result.
>> > >
>> >
>> >
>> > This was required when patchtest was running previously. It has been
>> > ignored for a while now, but that does not mean we should not enforce
>> > it. It should be documented as required.
>> >
>> > The tags allow for machines to parse the relevant info. Anything else
>> > is purely random and chaos.
>>
>> The tag is already required to be present in the CVE patch itself which
>> is/can be parsed by scripts which actually I think is a better way of
>> detecting whether a CVE is patched rather than looking at commit
>> messages.
>>
>> If having it in a specific format in commit message as well helps,
>> sure. It shouldn't take time to add it but we seem to be adding too
>> many rules ...
>>
>
> (adding Steve)
>
> I agree with Anuj, and I do not remember seeing a rule to put the
> CVE number in the commit message. We already have it in the
> patch file name (recommended) and inside the patch file itself.
> Those two places are enough in my opinion. In fact, it will likely
> be there in the commit message (its title), so repeating it does
> not make much logical sense.
>
> In fact, I have an update of the manual with more detailed information
> on submitting CVE fixes and looking for a resolution of this question
> to submit it :)
>
> Steve, does such additional tag in the commit message make it
> easier for you?

No.  In most cases it seems to add no value, since the cve number is
already in the shortlog, the filename of the patch(es), and the CVE
tag in the patch file(s).

I haven't been requiring it, so have no issue with removing that test
in patchtest.

Steve

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Trevor Gamblin]

On 2023-11-01 09:48, Steve Sakoman wrote:
> On Tue, Oct 31, 2023 at 7:31 PM Marta Rybczynska <rybczynska@gmail.com> wrote:
>>
>>
>>
>> On Wed, 1 Nov 2023, 11:48 Anuj Mittal, <anuj.mittal@intel.com> wrote:
>>> On Tue, 2023-10-31 at 19:33 -0700, Tim Orling wrote:
>>>>
>>>> On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com>
>>>> wrote:
>>>>> On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
>>>>>> Thank you for your submission. Patchtest identified one
>>>>>> or more issues with the patch. Please see the log below for
>>>>>> more information:
>>>>>>
>>>>>> ---
>>>>>> Testing patch /home/patchtest/share/mboxes/patchtest-shorten-
>>>>>> test-
>>>>>> result-outputs.patch
>>>>>>
>>>>>> FAIL: test CVE presence in commit message: A CVE tag should be
>>>>>> provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
>>>>>> (test_mbox.TestMbox.test_cve_presence_in_commit_message)
>>>>> Is this a requirement to have this in commit message in this
>>>>> format? I
>>>>> don't think this was being followed until now. A lot of patches
>>>>> seem to
>>>>> be failing this test as a result.
>>>>>
>>>>
>>>> This was required when patchtest was running previously. It has been
>>>> ignored for a while now, but that does not mean we should not enforce
>>>> it. It should be documented as required.
>>>>
>>>> The tags allow for machines to parse the relevant info. Anything else
>>>> is purely random and chaos.
>>> The tag is already required to be present in the CVE patch itself which
>>> is/can be parsed by scripts which actually I think is a better way of
>>> detecting whether a CVE is patched rather than looking at commit
>>> messages.
>>>
>>> If having it in a specific format in commit message as well helps,
>>> sure. It shouldn't take time to add it but we seem to be adding too
>>> many rules ...
>>>
>> (adding Steve)
>>
>> I agree with Anuj, and I do not remember seeing a rule to put the
>> CVE number in the commit message. We already have it in the
>> patch file name (recommended) and inside the patch file itself.
>> Those two places are enough in my opinion. In fact, it will likely
>> be there in the commit message (its title), so repeating it does
>> not make much logical sense.
>>
>> In fact, I have an update of the manual with more detailed information
>> on submitting CVE fixes and looking for a resolution of this question
>> to submit it :)
>>
>> Steve, does such additional tag in the commit message make it
>> easier for you?
> No.  In most cases it seems to add no value, since the cve number is
> already in the shortlog, the filename of the patch(es), and the CVE
> tag in the patch file(s).
>
> I haven't been requiring it, so have no issue with removing that test
> in patchtest.
I've got a patch ready to do this, just letting the selftests run to 
ensure nothing's broken before submission.
>
> Steve
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#189913): https://lists.openembedded.org/g/openembedded-core/message/189913
> Mute This Topic: https://lists.openembedded.org/mt/102275009/7611679
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [tgamblin@baylibre.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[Marta Rybczynska]

On Wed, Nov 1, 2023 at 6:31 AM Marta Rybczynska via
lists.openembedded.org <rybczynska=gmail.com@lists.openembedded.org>
wrote:
>
>
>
>
> On Wed, 1 Nov 2023, 11:48 Anuj Mittal, <anuj.mittal@intel.com> wrote:
>>
>> On Tue, 2023-10-31 at 19:33 -0700, Tim Orling wrote:
>> >
>> >
>> > On Tue, Oct 31, 2023 at 7:26 PM Anuj Mittal <anuj.mittal@intel.com>
>> > wrote:
>> > > On Tue, 2023-10-31 at 14:20 +0000, Trevor Gamblin wrote:
>> > > > Thank you for your submission. Patchtest identified one
>> > > > or more issues with the patch. Please see the log below for
>> > > > more information:
>> > > >
>> > > > ---
>> > > > Testing patch /home/patchtest/share/mboxes/patchtest-shorten-
>> > > > test-
>> > > > result-outputs.patch
>> > > >
>> > > > FAIL: test CVE presence in commit message: A CVE tag should be
>> > > > provided in the commit message with format: "CVE: CVE-YYYY-XXXX"
>> > > > (test_mbox.TestMbox.test_cve_presence_in_commit_message)
>> > >
>> > > Is this a requirement to have this in commit message in this
>> > > format? I
>> > > don't think this was being followed until now. A lot of patches
>> > > seem to
>> > > be failing this test as a result.
>> > >
>> >
>> >
>> > This was required when patchtest was running previously. It has been
>> > ignored for a while now, but that does not mean we should not enforce
>> > it. It should be documented as required.
>> >
>> > The tags allow for machines to parse the relevant info. Anything else
>> > is purely random and chaos.
>>
>> The tag is already required to be present in the CVE patch itself which
>> is/can be parsed by scripts which actually I think is a better way of
>> detecting whether a CVE is patched rather than looking at commit
>> messages.
>>
>> If having it in a specific format in commit message as well helps,
>> sure. It shouldn't take time to add it but we seem to be adding too
>> many rules ...
>>
>
> (adding Steve)
>
> I agree with Anuj, and I do not remember seeing a rule to put the
> CVE number in the commit message. We already have it in the
> patch file name (recommended) and inside the patch file itself.
> Those two places are enough in my opinion. In fact, it will likely
> be there in the commit message (its title), so repeating it does
> not make much logical sense.
>
> In fact, I have an update of the manual with more detailed information
> on submitting CVE fixes and looking for a resolution of this question
> to submit it :)
>
> Steve, does such additional tag in the commit message make it
> easier for you?
>

Here is what I have for the documentation:
https://lists.yoctoproject.org/g/docs/message/4544

Kind regards,
Marta

Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3201 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

FAIL: test CVE presence in commit message: A CVE tag should be provided in the commit message with format: "CVE: CVE-YYYY-XXXX" (test_mbox.TestMbox.test_cve_presence_in_commit_message)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest lic files chksum modified not mentioned: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_mentioned)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3201 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

FAIL: test CVE presence in commit message: A CVE tag should be provided in the commit message with format: "CVE: CVE-YYYY-XXXX" (test_mbox.TestMbox.test_cve_presence_in_commit_message)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest lic files chksum modified not mentioned: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_mentioned)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3201 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

FAIL: test CVE presence in commit message: A CVE tag should be provided in the commit message with format: "CVE: CVE-YYYY-XXXX" (test_mbox.TestMbox.test_cve_presence_in_commit_message)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest lic files chksum modified not mentioned: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_mentioned)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[patchtest]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

FAIL: test lic files chksum modified not mentioned: LIC_FILES_CHKSUM changed without "License-Update:" tag and description in commit message (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest lic files chksum modified not mentioned: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_mentioned)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE presence in commit message: No new patches introduced (test_mbox.TestMbox.test_cve_presence_in_commit_message)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Patchtest results for [OE-core][PATCH] patchtest: shorten test result outputs

[patchtest]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/patchtest-shorten-test-result-outputs.patch

FAIL: test lic files chksum modified not mentioned: LIC_FILES_CHKSUM changed without "License-Update:" tag and description in commit message (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest lic files chksum modified not mentioned: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_lic_files_chksum_modified_not_mentioned)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE presence in commit message: No new patches introduced (test_mbox.TestMbox.test_cve_presence_in_commit_message)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch format should be accepted. If
you believe these results are due to an error in patchtest, please
submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest'
category under 'Yocto Project Subprojects'). Thank you!