All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-kernel-dev@aliel.fr,
	Guillaume La Roque <glaroque@baylibre.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: thermal: amlogic: describe bus clock for t7-thermal
Date: Wed, 23 Sep 2026 14:02:51 +0200	[thread overview]
Message-ID: <8c93d281-981f-40ea-839e-6dd24964fbce@kernel.org> (raw)
In-Reply-To: <20260923-fix-t7-thermal-clock-v1-1-7d4c4682f182@aliel.fr>

On 23/09/2026 13:51, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> The t7 thermal sensor needs a bus clock, in addition to the existing
> functional clock, to gate register access to the sensor. This bus
> clock is specific to each sensor, unlike the functional clock which
> is shared between sensors. The current binding only describes a
> single unnamed clock and therefore cannot represent this hardware
> requirement, so add clock-names to disambiguate "bus" from "core" and

Index distinguishes, not the clock-names because items have strict
order. That part of sentence is redundant and more important - if I ack
this patch, people will use it as an argument in the future review
discussions.

Drop this part of sentence. clock-names are fine if you need them, but
still the disambiguation is provided by indices.

> make the second clock mandatory for the t7-thermal compatible only


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux-kernel-dev@aliel.fr,
	Guillaume La Roque <glaroque@baylibre.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: thermal: amlogic: describe bus clock for t7-thermal
Date: Wed, 23 Sep 2026 14:02:51 +0200	[thread overview]
Message-ID: <8c93d281-981f-40ea-839e-6dd24964fbce@kernel.org> (raw)
In-Reply-To: <20260923-fix-t7-thermal-clock-v1-1-7d4c4682f182@aliel.fr>

On 23/09/2026 13:51, Ronald Claveau via B4 Relay wrote:
> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> The t7 thermal sensor needs a bus clock, in addition to the existing
> functional clock, to gate register access to the sensor. This bus
> clock is specific to each sensor, unlike the functional clock which
> is shared between sensors. The current binding only describes a
> single unnamed clock and therefore cannot represent this hardware
> requirement, so add clock-names to disambiguate "bus" from "core" and

Index distinguishes, not the clock-names because items have strict
order. That part of sentence is redundant and more important - if I ack
this patch, people will use it as an argument in the future review
discussions.

Drop this part of sentence. clock-names are fine if you need them, but
still the disambiguation is provided by indices.

> make the second clock mandatory for the t7-thermal compatible only


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>


Best regards,
Krzysztof

  parent reply	other threads:[~2026-09-23 12:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 11:51 [PATCH 0/2] Add bus clock for t7-thermal sensor Ronald Claveau
2026-09-23 11:51 ` Ronald Claveau via B4 Relay
2026-09-23 11:51 ` Ronald Claveau via B4 Relay
2026-09-23 11:51 ` [PATCH 1/2] dt-bindings: thermal: amlogic: describe bus clock for t7-thermal Ronald Claveau
2026-09-23 11:51   ` Ronald Claveau via B4 Relay
2026-09-23 11:51   ` Ronald Claveau via B4 Relay
2026-09-23 12:00   ` sashiko-bot
2026-09-23 12:00     ` sashiko-bot
2026-09-23 12:02   ` Krzysztof Kozlowski [this message]
2026-09-23 12:02     ` Krzysztof Kozlowski
2026-09-23 12:17     ` linux-kernel-dev
2026-09-23 12:17       ` linux-kernel-dev
2026-09-23 11:51 ` [PATCH 2/2] thermal/drivers/amlogic: switch to clk_bulk API to support multiple clocks Ronald Claveau
2026-09-23 11:51   ` Ronald Claveau via B4 Relay
2026-09-23 11:51   ` Ronald Claveau via B4 Relay
2026-09-23 12:00   ` sashiko-bot
2026-09-23 12:00     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c93d281-981f-40ea-839e-6dd24964fbce@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=glaroque@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel-dev@aliel.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.