From: Frank Rowand <frowand.list@gmail.com>
To: Andrew Davis <afd@ti.com>, Shawn Guo <shawnguo@kernel.org>,
Li Yang <leoyang.li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] kbuild: Allow DTB overlays to built from .dtso named source files
Date: Mon, 24 Oct 2022 17:01:38 -0500 [thread overview]
Message-ID: <8cc34d10-a087-5ccf-ec0e-df87ff0d95f9@gmail.com> (raw)
In-Reply-To: <20221024173434.32518-2-afd@ti.com>
On 10/24/22 12:34, Andrew Davis wrote:
> Currently DTB Overlays (.dtbo) are build from source files with the same
> extension (.dts) as the base DTs (.dtb). This may become confusing and
> even lead to wrong results. For example, a composite DTB (created from a
> base DTB and a set of overlays) might have the same name as one of the
> overlays that create it.
>
> Different files should be generated from differently named sources.
> .dtb <-> .dts
> .dtbo <-> .dtso
>
> We do not remove the ability to compile DTBO files from .dts files here,
> only add a new rule allowing the .dtso file name. The current .dts named
> overlays can be renamed with time. After all have been renamed we can
> remove the other rule.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Tested-by: Frank Rowand <frowand.list@gmail.com>
-Frank
> scripts/Makefile.lib | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 3aa384cec76b8..0376a6f18bfb1 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -408,6 +408,9 @@ $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> +$(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> + $(call if_changed_dep,dtc)
> +
> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>
> # Bzip2
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Andrew Davis <afd@ti.com>, Shawn Guo <shawnguo@kernel.org>,
Li Yang <leoyang.li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] kbuild: Allow DTB overlays to built from .dtso named source files
Date: Mon, 24 Oct 2022 17:01:38 -0500 [thread overview]
Message-ID: <8cc34d10-a087-5ccf-ec0e-df87ff0d95f9@gmail.com> (raw)
In-Reply-To: <20221024173434.32518-2-afd@ti.com>
On 10/24/22 12:34, Andrew Davis wrote:
> Currently DTB Overlays (.dtbo) are build from source files with the same
> extension (.dts) as the base DTs (.dtb). This may become confusing and
> even lead to wrong results. For example, a composite DTB (created from a
> base DTB and a set of overlays) might have the same name as one of the
> overlays that create it.
>
> Different files should be generated from differently named sources.
> .dtb <-> .dts
> .dtbo <-> .dtso
>
> We do not remove the ability to compile DTBO files from .dts files here,
> only add a new rule allowing the .dtso file name. The current .dts named
> overlays can be renamed with time. After all have been renamed we can
> remove the other rule.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
Tested-by: Frank Rowand <frowand.list@gmail.com>
-Frank
> scripts/Makefile.lib | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 3aa384cec76b8..0376a6f18bfb1 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -408,6 +408,9 @@ $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> +$(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> + $(call if_changed_dep,dtc)
> +
> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>
> # Bzip2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-24 23:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 17:34 [PATCH v2 0/7] Rename DTB overlay source files Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-10-24 17:34 ` [PATCH v2 1/7] kbuild: Allow DTB overlays to built from .dtso named " Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-10-24 22:01 ` Frank Rowand [this message]
2022-10-24 22:01 ` Frank Rowand
2022-10-24 17:34 ` [PATCH v2 2/7] kbuild: Allow DTB overlays to built into .dtso.S files Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-10-24 22:01 ` Frank Rowand
2022-10-24 22:01 ` Frank Rowand
2022-10-24 17:34 ` [PATCH v2 3/7] of: overlay: rename overlay source files from .dts to .dtso Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-10-24 22:01 ` Frank Rowand
2022-10-24 22:01 ` Frank Rowand
2022-10-24 17:34 ` [PATCH v2 4/7] arm64: dts: freescale: Rename DTB " Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-11-19 6:32 ` Shawn Guo
2022-11-19 6:32 ` Shawn Guo
2022-10-24 17:34 ` [PATCH v2 5/7] arm64: dts: renesas: " Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-10-24 17:34 ` [PATCH v2 6/7] arm64: dts: xilinx: " Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-11-30 16:50 ` Michal Simek
2022-11-30 16:50 ` Michal Simek
2022-10-24 17:34 ` [PATCH v2 7/7] staging: pi433: overlay: Rename overlay source file " Andrew Davis
2022-10-24 17:34 ` Andrew Davis
2022-10-25 6:57 ` Geert Uytterhoeven
2022-10-25 6:57 ` Geert Uytterhoeven
2022-10-24 22:04 ` [PATCH v2 0/7] Rename DTB overlay source files Frank Rowand
2022-10-24 22:04 ` Frank Rowand
2022-10-26 14:11 ` Rob Herring
2022-10-26 14:11 ` Rob Herring
2022-11-11 19:39 ` Andy Shevchenko
2022-11-11 19:39 ` Andy Shevchenko
2022-11-11 19:40 ` Andy Shevchenko
2022-11-11 19:40 ` Andy Shevchenko
2022-11-11 21:05 ` Andrew Davis
2022-11-11 21:05 ` Andrew Davis
2022-11-13 12:20 ` Andy Shevchenko
2022-11-13 12:20 ` Andy Shevchenko
2022-11-13 12:36 ` Andy Shevchenko
2022-11-13 12:36 ` Andy Shevchenko
2022-11-14 16:06 ` Andy Shevchenko
2022-11-14 16:06 ` Andy Shevchenko
2022-11-14 20:43 ` Andrew Davis
2022-11-14 20:43 ` Andrew Davis
2022-11-15 11:29 ` Andy Shevchenko
2022-11-15 11:29 ` Andy Shevchenko
2022-11-14 14:39 ` Andy Shevchenko
2022-11-14 14:39 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cc34d10-a087-5ccf-ec0e-df87ff0d95f9@gmail.com \
--to=frowand.list@gmail.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.