From: jsmart2021@gmail.com (James Smart)
Subject: [PATCH 05/17] lpfc: NVME Initiator: Base modifications Part D
Date: Wed, 18 Jan 2017 19:00:44 -0800 [thread overview]
Message-ID: <8d1b6a73-df1a-1fd1-5059-7ce6a7e91c6f@gmail.com> (raw)
In-Reply-To: <20170118133959.GE3514@linux-x5ow.site>
On 1/18/2017 5:39 AM, Johannes Thumshirn wrote:
> I know this might be annoying by now, but it's really hard to follow
> code that
> is so much indented and lpfc really needs some love in the readability case.
> Please don't misunderstand me, it has nothing to do with you and lpfc is not
> the only driver that could need some refactoring. It's just I've spend a lot
> of time looking at lpfc since I've started working in the storage area and
> the code style is somewhat inconsistent with the reset of the kernel (as are
> other SCSI drivers, I know). If you and Martin/James B. don't mind I'd even
> volunteer to help you with cleaning it up a bit.
I agree with the idea but want to hold off a little while longer. first,
I want the driver to stabilize after adding a second protocol. second, I
want it to harden a bit.
-- james
WARNING: multiple messages have this Message-ID (diff)
From: James Smart <jsmart2021@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 05/17] lpfc: NVME Initiator: Base modifications Part D
Date: Wed, 18 Jan 2017 19:00:44 -0800 [thread overview]
Message-ID: <8d1b6a73-df1a-1fd1-5059-7ce6a7e91c6f@gmail.com> (raw)
In-Reply-To: <20170118133959.GE3514@linux-x5ow.site>
On 1/18/2017 5:39 AM, Johannes Thumshirn wrote:
> I know this might be annoying by now, but it's really hard to follow
> code that
> is so much indented and lpfc really needs some love in the readability case.
> Please don't misunderstand me, it has nothing to do with you and lpfc is not
> the only driver that could need some refactoring. It's just I've spend a lot
> of time looking at lpfc since I've started working in the storage area and
> the code style is somewhat inconsistent with the reset of the kernel (as are
> other SCSI drivers, I know). If you and Martin/James B. don't mind I'd even
> volunteer to help you with cleaning it up a bit.
I agree with the idea but want to hold off a little while longer. first,
I want the driver to stabilize after adding a second protocol. second, I
want it to harden a bit.
-- james
next prev parent reply other threads:[~2017-01-19 3:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 1:20 [PATCH 05/17] lpfc: NVME Initiator: Base modifications Part D James Smart
2017-01-18 1:20 ` James Smart
2017-01-18 7:21 ` Hannes Reinecke
2017-01-18 7:21 ` Hannes Reinecke
2017-01-18 13:39 ` Johannes Thumshirn
2017-01-18 13:39 ` Johannes Thumshirn
2017-01-19 3:00 ` James Smart [this message]
2017-01-19 3:00 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d1b6a73-df1a-1fd1-5059-7ce6a7e91c6f@gmail.com \
--to=jsmart2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.