Re: [PATCH 3/3] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/07/2025 16:31, Jonas Jelonek wrote:
> 
> 
> On 01.07.2025 15:17, Krzysztof Kozlowski wrote:
>> You have some very odd wrapping of emails.
> 
> Sorry for that, I'm not used to this workflow and obviously haven't configured
> my editor properly. I'm working on that.
> 
>> Anyway, you keep mentioning in multiple places rtl9311-9313, so that's
>> confusing. If you mention them, I would expect compatibles. They cannot
>> use rtl9310 compatible alone.
>>
>> I don't mind skipping them, but then just don't mention any sort of
>> treatment for other devices. You add this and only this hardware, if you
>> do not want to follow the make-binding-complete principle (see writing
>> bindings).
>>
> 
> I think I got. I'll adjust this in v2.
>>>>> +  scl-num:
>>>> No, you do not get own instance IDs.
>>> Is that meant for the wording/naming of the property and/or its
>>> description or for the general idea of this property?
>> You do not get such property. We don't accept it, it's generic rule.
>> Nowhere in the kernel... unless this is a standard, generic property
>> (there is no vendor prefix), but I could not find it. If it is standard
>> property, where is it defined in dtschema or common bindings?
>>
>> I don't get the need for this property and description does not help, so
>> just drop it.
> 
> Ok, I missed that this is seen as a generic rule then. Sorry for that.
> 
> For the purpose:
> RTL9310 changed the register layout compared to RTL9300. Activating
> the SCL line is done by setting bit 12 for master 1 and bit 13 for master 2
> in a global register which is located before the master-specific registers.
> Thus, the driver needs to know which master (1 or 2) it is currently doing
> something for. That is what this property is intended to be used, naming
> to-be-discussed.

There is no global register space here and no syscon, so I don't
understand how can you access it, especially when they are located
BEFORE your address space.

Best regards,
Krzysztof