Re: [PATCH 3/3] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9310 support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/07/2025 11:17, Jonas Jelonek wrote:
> This extends the dt-bindings for the I2C driver for RTL9300 to account

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> for the added support for RTL9310 series.
> 
> A new property is added to explicitly set the SCL num/hardware instance
> of the controller that is used. In contrast to RTL9300 the driver needs
> to know that explicitly for RTL9310 because the SCL selection is now in
> a global register instead of a master-specific register.
> 
> The regex for child-node address is adjusted to account for the fact
> that RTL9310 supports 12 instead of 8 SDA lines.
> 
> A single generic compatible "realtek,rtl9310-i2c" is added. To best
> knowledge, all existing SoCs of RTL9310 series (RTL9311, RTL9312,
> RTL9313) have equal I2C capabilities thus don't need special treatment.


You always need specific front compatible (and fallback if applicable).



> However, in the unlikely case of future differences with specific
> SoCs within this series, more can be added as needed.
> 
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
> ---
>  .../bindings/i2c/realtek,rtl9301-i2c.yaml     | 33 ++++++++++++++++---
>  1 file changed, 29 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> index eddfd329c67b..3b32da3de2af 100644
> --- a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> @@ -10,9 +10,11 @@ maintainers:
>    - Chris Packham <chris.packham@alliedtelesis.co.nz>
>  
>  description:
> -  The RTL9300 SoC has two I2C controllers. Each of these has an SCL line (which
> -  if not-used for SCL can be a GPIO). There are 8 common SDA lines that can be
> -  assigned to either I2C controller.
> +  The RTL9300 SoCs have two I2C controllers. Each of these has an SCL line
> +  (which if not-used for SCL can be a GPIO). There are 8 common SDA lines
> +  that can be assigned to either I2C controller.
> +  The RTL9310 SoCs have equal capabilities but support 12 common SDA lines
> +  which can be assigned to either I2C controller.
>  
>  properties:
>    compatible:
> @@ -24,6 +26,7 @@ properties:
>                - realtek,rtl9303-i2c
>            - const: realtek,rtl9301-i2c
>        - const: realtek,rtl9301-i2c
> +      - const: realtek,rtl9310-i2c
>  
>    reg:
>      description: Register offset and size this I2C controller.
> @@ -34,8 +37,18 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  scl-num:


No, you do not get own instance IDs.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof