From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Conor Dooley <Conor.Dooley@microchip.com>,
Horatiu Vultur <Horatiu.Vultur@microchip.com>,
Kavyasree Kotagiri <Kavyasree.Kotagiri@microchip.com>
Cc: <linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91
Date: Mon, 11 Jul 2022 14:03:07 +0200 [thread overview]
Message-ID: <8dbed370-c6d6-496c-eb41-efce2ee78286@microchip.com> (raw)
In-Reply-To: <9996cb86818d2e935494d6b414d549432f91797a.1657528504.git.geert+renesas@glider.be>
On 11/07/2022 at 10:36, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence
> add a dependency on ARCH_AT91, to prevent asking the user about this
> driver when configuring a kernel without AT91/Microchip SoC support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
I'm adding to the thread my colleagues from lan966 and mpfs if it
happens that they use this same IP on their SoC. Anyway, we can add them
afterwards.
Thanks for your heads-up Geert, Best regards,
Nicolas
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 63a89ff7865e374f..1852656d5eb248f6 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU
> tristate "SAMA5D2 PIOBU GPIO support"
> depends on MFD_SYSCON
> depends on OF_GPIO
> + depends on ARCH_AT91 || COMPILE_TEST
> select GPIO_SYSCON
> help
> Say yes here to use the PIOBU pins as GPIOs.
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Conor Dooley <Conor.Dooley@microchip.com>,
Horatiu Vultur <Horatiu.Vultur@microchip.com>,
Kavyasree Kotagiri <Kavyasree.Kotagiri@microchip.com>
Cc: <linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91
Date: Mon, 11 Jul 2022 14:03:07 +0200 [thread overview]
Message-ID: <8dbed370-c6d6-496c-eb41-efce2ee78286@microchip.com> (raw)
In-Reply-To: <9996cb86818d2e935494d6b414d549432f91797a.1657528504.git.geert+renesas@glider.be>
On 11/07/2022 at 10:36, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The SAMA5D2 PIOBU is only present on some AT91/Microchip SoCs. Hence
> add a dependency on ARCH_AT91, to prevent asking the user about this
> driver when configuring a kernel without AT91/Microchip SoC support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
I'm adding to the thread my colleagues from lan966 and mpfs if it
happens that they use this same IP on their SoC. Anyway, we can add them
afterwards.
Thanks for your heads-up Geert, Best regards,
Nicolas
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 63a89ff7865e374f..1852656d5eb248f6 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -553,6 +553,7 @@ config GPIO_SAMA5D2_PIOBU
> tristate "SAMA5D2 PIOBU GPIO support"
> depends on MFD_SYSCON
> depends on OF_GPIO
> + depends on ARCH_AT91 || COMPILE_TEST
> select GPIO_SYSCON
> help
> Say yes here to use the PIOBU pins as GPIOs.
> --
> 2.25.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-11 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 8:36 [PATCH] gpio: GPIO_SAMA5D2_PIOBU should depend on ARCH_AT91 Geert Uytterhoeven
2022-07-11 8:36 ` Geert Uytterhoeven
2022-07-11 12:03 ` Nicolas Ferre [this message]
2022-07-11 12:03 ` Nicolas Ferre
2022-07-11 12:08 ` Conor.Dooley
2022-07-11 12:08 ` Conor.Dooley
2022-07-12 10:23 ` Bartosz Golaszewski
2022-07-12 10:23 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dbed370-c6d6-496c-eb41-efce2ee78286@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.