All of lore.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH] arm64: dts: mediatek: Add cpufreq nodes for MT8192
Date: Mon, 20 Feb 2023 10:14:34 +0100	[thread overview]
Message-ID: <8df07281-e332-e25d-e0d7-035efbe3925b@collabora.com> (raw)
In-Reply-To: <20230220021915.9473-1-allen-kh.cheng@mediatek.com>

Il 20/02/23 03:19, Allen-KH Cheng ha scritto:
> Add the cpufreq nodes for MT8192 SoC.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> Fix a address warning on dtbs_check
> https://patchwork.kernel.org/project/linux-mediatek/patch/1609223471-24325-1-git-send-email-andrew-sh.cheng@mediatek.com/
> [Allen-KH Cheng <allen-kh.cheng@mediatek.com>]
> ---
> ---
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 424fc89cc6f7..181ec2db7a69 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -55,6 +55,7 @@ cpu0: cpu@0 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

There's a mistake here: this should be <&performance 0>;

>   			capacity-dmips-mhz = <530>;
>   		};
>   
> @@ -66,6 +67,7 @@ cpu1: cpu@100 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

Same here

>   			capacity-dmips-mhz = <530>;
>   		};
>   
> @@ -77,6 +79,7 @@ cpu2: cpu@200 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

and here

>   			capacity-dmips-mhz = <530>;
>   		};
>   
> @@ -88,6 +91,7 @@ cpu3: cpu@300 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

....and here.

Regards,
Angelo


WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>
Subject: Re: [PATCH] arm64: dts: mediatek: Add cpufreq nodes for MT8192
Date: Mon, 20 Feb 2023 10:14:34 +0100	[thread overview]
Message-ID: <8df07281-e332-e25d-e0d7-035efbe3925b@collabora.com> (raw)
In-Reply-To: <20230220021915.9473-1-allen-kh.cheng@mediatek.com>

Il 20/02/23 03:19, Allen-KH Cheng ha scritto:
> Add the cpufreq nodes for MT8192 SoC.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> Fix a address warning on dtbs_check
> https://patchwork.kernel.org/project/linux-mediatek/patch/1609223471-24325-1-git-send-email-andrew-sh.cheng@mediatek.com/
> [Allen-KH Cheng <allen-kh.cheng@mediatek.com>]
> ---
> ---
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 424fc89cc6f7..181ec2db7a69 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -55,6 +55,7 @@ cpu0: cpu@0 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

There's a mistake here: this should be <&performance 0>;

>   			capacity-dmips-mhz = <530>;
>   		};
>   
> @@ -66,6 +67,7 @@ cpu1: cpu@100 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

Same here

>   			capacity-dmips-mhz = <530>;
>   		};
>   
> @@ -77,6 +79,7 @@ cpu2: cpu@200 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

and here

>   			capacity-dmips-mhz = <530>;
>   		};
>   
> @@ -88,6 +91,7 @@ cpu3: cpu@300 {
>   			clock-frequency = <1701000000>;
>   			cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
>   			next-level-cache = <&l2_0>;
> +			performance-domains = <&performance 1>;

....and here.

Regards,
Angelo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-20  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20  2:19 [PATCH] arm64: dts: mediatek: Add cpufreq nodes for MT8192 Allen-KH Cheng
2023-02-20  2:19 ` Allen-KH Cheng
2023-02-20  9:14 ` AngeloGioacchino Del Regno [this message]
2023-02-20  9:14   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8df07281-e332-e25d-e0d7-035efbe3925b@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.