Re: [PATCH 2/2] io_uring/nop: use io_find_buf_node()

[Pavel Begunkov <asml.silence@gmail.com>]

On 3/1/25 01:58, Caleb Sander Mateos wrote:
> On Fri, Feb 28, 2025 at 5:40 PM Pavel Begunkov <asml.silence@gmail.com> wrote:
>>
>> On 3/1/25 00:16, Caleb Sander Mateos wrote:
>>> Call io_find_buf_node() to avoid duplicating it in io_nop().
>>
>> IORING_NOP_FIXED_BUFFER interface looks odd, instead of pretending
>> to use a buffer, it basically pokes directly into internal infra,
>> it's not something userspace should be able to do.
> 
> I assumed it was just for benchmarking the overhead of fixed buffer

Right

> lookup. Since a normal IORING_OP_NOP doesn't use any buffer, it makes
> sense for IORING_NOP_FIXED_BUFFER not to do anything with the fixed
> buffer either.

That's a special api that benchmarks internal details that no
other request knows about, no, that's not great.

-- 
Pavel Begunkov