From: Pavel Begunkov <asml.silence@gmail.com>
To: Caleb Sander Mateos <csander@purestorage.com>,
Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH 2/2] io_uring/nop: use io_find_buf_node()
Date: Sat, 1 Mar 2025 02:15:26 +0000 [thread overview]
Message-ID: <e84d5e50-617b-421e-bed6-628cacc28cf9@gmail.com> (raw)
In-Reply-To: <d4271290-2abb-49ee-a99a-bc8bb6dde558@gmail.com>
On 3/1/25 01:41, Pavel Begunkov wrote:
> On 3/1/25 00:16, Caleb Sander Mateos wrote:
>> Call io_find_buf_node() to avoid duplicating it in io_nop().
>
> IORING_NOP_FIXED_BUFFER interface looks odd, instead of pretending
> to use a buffer, it basically pokes directly into internal infra,
> it's not something userspace should be able to do.
>
> Jens, did use it anywhere? It's new, I'd rather kill it or align with
> how requests consume buffers, i.e. addr+len, and then do
> io_import_reg_buf() instead. That'd break the api though, but would
> anyone care?
3rd option is to ignore the flag and let the req succeed.
--
Pavel Begunkov
next prev parent reply other threads:[~2025-03-01 2:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 0:16 [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file Caleb Sander Mateos
2025-03-01 0:16 ` [PATCH 2/2] io_uring/nop: use io_find_buf_node() Caleb Sander Mateos
2025-03-01 1:41 ` Pavel Begunkov
2025-03-01 1:58 ` Caleb Sander Mateos
2025-03-01 2:10 ` Jens Axboe
2025-03-01 2:11 ` Pavel Begunkov
2025-03-01 2:15 ` Pavel Begunkov [this message]
2025-03-01 2:21 ` Jens Axboe
2025-03-01 2:36 ` Pavel Begunkov
2025-03-01 2:39 ` Jens Axboe
2025-03-01 3:02 ` Pavel Begunkov
2025-03-01 1:46 ` [PATCH 1/2] io_uring/rsrc: declare io_find_buf_node() in header file Pavel Begunkov
2025-03-01 2:04 ` Caleb Sander Mateos
2025-03-01 2:22 ` Jens Axboe
2025-03-01 2:31 ` Pavel Begunkov
2025-03-01 2:33 ` Jens Axboe
2025-03-01 2:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e84d5e50-617b-421e-bed6-628cacc28cf9@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.