* [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine
2026-05-14 19:23 [PATCH 0/3] Add support for qcrypto on shikra Kuldeep Singh
@ 2026-05-14 19:23 ` Kuldeep Singh
2026-05-15 11:00 ` Krzysztof Kozlowski
2026-05-14 19:23 ` [PATCH 2/3] dt-bindings: bam-dma: Increase maxItems to seven for iommus Kuldeep Singh
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Kuldeep Singh @ 2026-05-14 19:23 UTC (permalink / raw)
To: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Vinod Koul, Frank Li, Andy Gross
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, dmaengine,
Kuldeep Singh
Document the crypto engine on the Shikra platform.
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 69101cead3bc..ad0e1cd3a76a 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -53,6 +53,7 @@ properties:
- qcom,qcs8300-qce
- qcom,sa8775p-qce
- qcom,sc7280-qce
+ - qcom,shikra-qce
- qcom,sm6350-qce
- qcom,sm8250-qce
- qcom,sm8350-qce
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine
2026-05-14 19:23 ` [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
@ 2026-05-15 11:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-15 11:00 UTC (permalink / raw)
To: Kuldeep Singh, Thara Gopinath, Herbert Xu, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Vinod Koul, Frank Li, Andy Gross
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, dmaengine
On 14/05/2026 21:23, Kuldeep Singh wrote:
> Document the crypto engine on the Shikra platform.
>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
Same comments as for IPQ, Nord. I gave the same feedback internally more
than once.
NAK
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] dt-bindings: bam-dma: Increase maxItems to seven for iommus
2026-05-14 19:23 [PATCH 0/3] Add support for qcrypto on shikra Kuldeep Singh
2026-05-14 19:23 ` [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
@ 2026-05-14 19:23 ` Kuldeep Singh
2026-05-14 19:23 ` [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support Kuldeep Singh
2026-05-14 19:47 ` [PATCH 0/3] Add support for qcrypto on shikra Eric Biggers
3 siblings, 0 replies; 7+ messages in thread
From: Kuldeep Singh @ 2026-05-14 19:23 UTC (permalink / raw)
To: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Vinod Koul, Frank Li, Andy Gross
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, dmaengine,
Kuldeep Singh
Shikra bam dma engine support seven iommu entries.
Increase maxItems property for iommus to pass dtbs_check errors.
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
---
Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
index 6493a6968bb4..ffdb308352c3 100644
--- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
@@ -46,7 +46,7 @@ properties:
iommus:
minItems: 1
- maxItems: 6
+ maxItems: 7
num-channels:
$ref: /schemas/types.yaml#/definitions/uint32
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support
2026-05-14 19:23 [PATCH 0/3] Add support for qcrypto on shikra Kuldeep Singh
2026-05-14 19:23 ` [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
2026-05-14 19:23 ` [PATCH 2/3] dt-bindings: bam-dma: Increase maxItems to seven for iommus Kuldeep Singh
@ 2026-05-14 19:23 ` Kuldeep Singh
2026-05-15 10:28 ` Konrad Dybcio
2026-05-14 19:47 ` [PATCH 0/3] Add support for qcrypto on shikra Eric Biggers
3 siblings, 1 reply; 7+ messages in thread
From: Kuldeep Singh @ 2026-05-14 19:23 UTC (permalink / raw)
To: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Vinod Koul, Frank Li, Andy Gross
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, dmaengine,
Kuldeep Singh
Add qcrypto and cryptobam support for shikra target.
Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/shikra.dtsi | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
index 262c488add1e..dbac0e901d6e 100644
--- a/arch/arm64/boot/dts/qcom/shikra.dtsi
+++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
@@ -541,6 +541,41 @@ config_noc: interconnect@1900000 {
#interconnect-cells = <2>;
};
+ cryptobam: dma-controller@1b04000 {
+ compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+ reg = <0x0 0x01b04000 0x0 0x24000>;
+ interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ iommus = <&apps_smmu 0x84 0x0011>,
+ <&apps_smmu 0x86 0x0011>,
+ <&apps_smmu 0x92 0x0>,
+ <&apps_smmu 0x94 0x0011>,
+ <&apps_smmu 0x96 0x0011>,
+ <&apps_smmu 0x98 0x0001>,
+ <&apps_smmu 0x9F 0x0>;
+ qcom,ee = <0>;
+ qcom,controlled-remotely;
+ num-channels = <16>;
+ qcom,num-ees = <4>;
+ };
+
+ crypto: crypto@1b3a000 {
+ compatible = "qcom,shikra-qce", "qcom,sm8150-qce", "qcom,qce";
+ reg = <0x0 0x01b3a000 0x0 0x6000>;
+ dmas = <&cryptobam 4>, <&cryptobam 5>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x84 0x0011>,
+ <&apps_smmu 0x86 0x0011>,
+ <&apps_smmu 0x92 0x0>,
+ <&apps_smmu 0x94 0x0011>,
+ <&apps_smmu 0x96 0x0011>,
+ <&apps_smmu 0x98 0x0001>,
+ <&apps_smmu 0x9F 0x0>;
+ interconnects = <&system_noc MASTER_CRYPTO_CORE0 0
+ &mc_virt SLAVE_EBI_CH0 0>;
+ interconnect-names = "memory";
+ };
+
qfprom: efuse@1b44000 {
compatible = "qcom,shikra-qfprom", "qcom,qfprom";
reg = <0x0 0x01b44000 0x0 0x3000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support
2026-05-14 19:23 ` [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support Kuldeep Singh
@ 2026-05-15 10:28 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2026-05-15 10:28 UTC (permalink / raw)
To: Kuldeep Singh, Thara Gopinath, Herbert Xu, David S. Miller,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Vinod Koul, Frank Li, Andy Gross
Cc: linux-arm-msm, linux-crypto, devicetree, linux-kernel, dmaengine
On 5/14/26 9:23 PM, Kuldeep Singh wrote:
> Add qcrypto and cryptobam support for shikra target.
>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/shikra.dtsi | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 262c488add1e..dbac0e901d6e 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -541,6 +541,41 @@ config_noc: interconnect@1900000 {
> #interconnect-cells = <2>;
> };
>
> + cryptobam: dma-controller@1b04000 {
> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> + reg = <0x0 0x01b04000 0x0 0x24000>;
> + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + iommus = <&apps_smmu 0x84 0x0011>,
> + <&apps_smmu 0x86 0x0011>,
> + <&apps_smmu 0x92 0x0>,
> + <&apps_smmu 0x94 0x0011>,
> + <&apps_smmu 0x96 0x0011>,
These two entries are logically the same (SID & ~mask) as the first two,
does it still work if you remove them?
> + <&apps_smmu 0x98 0x0001>,
> + <&apps_smmu 0x9F 0x0>;
Let's keep lowercase hex
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/3] Add support for qcrypto on shikra
2026-05-14 19:23 [PATCH 0/3] Add support for qcrypto on shikra Kuldeep Singh
` (2 preceding siblings ...)
2026-05-14 19:23 ` [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support Kuldeep Singh
@ 2026-05-14 19:47 ` Eric Biggers
3 siblings, 0 replies; 7+ messages in thread
From: Eric Biggers @ 2026-05-14 19:47 UTC (permalink / raw)
To: Kuldeep Singh
Cc: Thara Gopinath, Herbert Xu, David S. Miller, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Vinod Koul, Frank Li, Andy Gross, linux-arm-msm, linux-crypto,
devicetree, linux-kernel, dmaengine
On Fri, May 15, 2026 at 12:53:35AM +0530, Kuldeep Singh wrote:
> Add qcrypto and cryptobam DT nodes for enabling qcrypto on kaanapali.
> Shikra bam dma supports 7 iommus so update dt-bindings accordingly.
>
> The patchset depends on below. There's recursive dependency so referred
> to base DT patch here.
> - https://lore.kernel.org/all/20260512-shikra-dt-v1-0-716438330dd0@oss.qualcomm.com/
>
> Validations:
> - make ARCH=arm64 DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml dt_binding_check
> - make ARCH=arm64 qcom/shikra-cqs-evk.dtb CHECK_DTBS=1 DT_SCHEMA_FILES=Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> - cryptobam and crypto driver probe
> - kcapi test
>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
What specific kernel features would this be useful for, and what
specific performance improvements are you seeing with those features?
- Eric
^ permalink raw reply [flat|nested] 7+ messages in thread