Re: [PATCH 10/12] bluetooth: hci_wilc: add wilc hci driver

["Alexis Lothoré" <alexis.lothore@bootlin.com>]

Hi Krzysztof,

On 2/13/25 10:24, Krzysztof Kozlowski wrote:
> On Wed, Feb 12, 2025 at 04:46:29PM +0100, Alexis Lothoré wrote:
>> +#include "linux/bitops.h"
>> +#include "linux/byteorder/generic.h"
>> +#include "linux/err.h"
>> +#include "linux/gfp_types.h"
>> +#include "net/bluetooth/bluetooth.h"
>> +#include "net/bluetooth/hci.h"
> 
> Keep some order here. Why some are <> some "", why net is mixed with
> linux...

[...]

>> +	wilc_adapter = kzalloc(sizeof(*wilc_adapter), GFP_KERNEL);
> 
> Why not devm?

[...]

>> +	if (IS_ERR(wlan)) {
>> +		pr_warn("Can not initialize bluetooth: %pe\n", wlan);
> 
> dev_warn or even dev_err_probe to handle deferral.

[...]

>> +	dev_info(&serdev->dev, "WILC hci interface registered");
> 
> Drop simple probe statuses. sysfs already provides this.

[...]

>> +static struct serdev_device_driver wilc_bt_serdev_driver = {
>> +	.probe = wilc_bt_serdev_probe,
>> +	.remove = wilc_bt_serdev_remove,
>> +	.driver = {
>> +		.name = "hci_uart_wilc",
>> +		.of_match_table = of_match_ptr(wilc_bt_of_match),
> 
> Drop of_match_tr, you have warnings here.

Thanks for the review, true for all raised points, which will be handled in next
rev.

Alexis
> 
> Best regards,
> Krzysztof
> 


-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com