All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Chen Wang <unicorn_wang@outlook.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Inochi Amaoto <inochiama@outlook.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac
Date: Mon, 28 Oct 2024 08:06:25 +0100	[thread overview]
Message-ID: <8eeb1f7c-3198-45ac-be9a-c3d4e5174f1f@kernel.org> (raw)
In-Reply-To: <mwlbdxw7yh5cqqi5mnbhelf4ihqihup4zkzppkxm7ggsb5itbb@mcbyevoat76d>

On 28/10/2024 00:32, Inochi Amaoto wrote:
> On Sun, Oct 27, 2024 at 09:38:00PM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Oct 25, 2024 at 09:09:58AM +0800, Inochi Amaoto wrote:
>>> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC
>>> with some extra clock.
>>>
>>> Add necessary compatible string for this device.
>>>
>>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>>> ---
>>
>> This should be squashed with a corrected previous patch 
> 
> Good, I will.
> 
>> (why do you need to select snps,dwmac-5.30a?), 
> 
> The is because the driver use the fallback versioned compatible 
> string to set up some common arguments. (This is what the patch

Nope. Driver never relies on schema doing select. That's just incorrect.

> 3 does). It is also better to have a accurate fallback compatible
> if we already know what it is.

Best regards,
Krzysztof



WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Chen Wang <unicorn_wang@outlook.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Inochi Amaoto <inochiama@outlook.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac
Date: Mon, 28 Oct 2024 08:06:25 +0100	[thread overview]
Message-ID: <8eeb1f7c-3198-45ac-be9a-c3d4e5174f1f@kernel.org> (raw)
In-Reply-To: <mwlbdxw7yh5cqqi5mnbhelf4ihqihup4zkzppkxm7ggsb5itbb@mcbyevoat76d>

On 28/10/2024 00:32, Inochi Amaoto wrote:
> On Sun, Oct 27, 2024 at 09:38:00PM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Oct 25, 2024 at 09:09:58AM +0800, Inochi Amaoto wrote:
>>> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC
>>> with some extra clock.
>>>
>>> Add necessary compatible string for this device.
>>>
>>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>>> ---
>>
>> This should be squashed with a corrected previous patch 
> 
> Good, I will.
> 
>> (why do you need to select snps,dwmac-5.30a?), 
> 
> The is because the driver use the fallback versioned compatible 
> string to set up some common arguments. (This is what the patch

Nope. Driver never relies on schema doing select. That's just incorrect.

> 3 does). It is also better to have a accurate fallback compatible
> if we already know what it is.

Best regards,
Krzysztof


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-10-28  7:08 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25  1:09 [PATCH v2 0/4] riscv: sophgo: Add ethernet support for SG2044 Inochi Amaoto
2024-10-25  1:09 ` Inochi Amaoto
2024-10-25  1:09 ` [PATCH v2 1/4] dt-bindings: net: snps,dwmac: Add dwmac-5.30a version Inochi Amaoto
2024-10-25  1:09   ` Inochi Amaoto
2024-10-27 20:35   ` Krzysztof Kozlowski
2024-10-27 20:35     ` Krzysztof Kozlowski
2024-10-25  1:09 ` [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044 dwmac Inochi Amaoto
2024-10-25  1:09   ` Inochi Amaoto
2024-10-27 20:38   ` Krzysztof Kozlowski
2024-10-27 20:38     ` Krzysztof Kozlowski
2024-10-27 23:32     ` Inochi Amaoto
2024-10-27 23:32       ` Inochi Amaoto
2024-10-28  7:06       ` Krzysztof Kozlowski [this message]
2024-10-28  7:06         ` Krzysztof Kozlowski
2024-10-28  7:16         ` Inochi Amaoto
2024-10-28  7:16           ` Inochi Amaoto
2024-10-29 13:27           ` Krzysztof Kozlowski
2024-10-29 13:27             ` Krzysztof Kozlowski
2024-10-30  0:43             ` Inochi Amaoto
2024-10-30  0:43               ` Inochi Amaoto
2024-10-25  1:09 ` [PATCH v2 3/4] net: stmmac: platform: Add snps,dwmac-5.30a IP compatible string Inochi Amaoto
2024-10-25  1:09   ` Inochi Amaoto
2024-10-25 14:44   ` Alexander Lobakin
2024-10-25 14:44     ` Alexander Lobakin
2024-10-25 23:32     ` Inochi Amaoto
2024-10-25 23:32       ` Inochi Amaoto
2024-10-25  1:10 ` [PATCH v2 4/4] net: stmmac: Add glue layer for Sophgo SG2044 SoC Inochi Amaoto
2024-10-25  1:10   ` Inochi Amaoto
2024-10-25 14:36   ` kernel test robot
2024-10-25 14:36     ` kernel test robot
2024-10-25 14:53   ` Alexander Lobakin
2024-10-25 14:53     ` Alexander Lobakin
2024-10-25 23:27     ` Inochi Amaoto
2024-10-25 23:27       ` Inochi Amaoto
2024-10-25 15:48   ` kernel test robot
2024-10-25 15:48     ` kernel test robot
2024-10-25 19:34   ` kernel test robot
2024-10-25 19:34     ` kernel test robot
2024-10-25 13:08 ` [PATCH v2 0/4] riscv: sophgo: Add ethernet support for SG2044 Simon Horman
2024-10-25 13:08   ` Simon Horman
2024-10-25 23:24   ` Inochi Amaoto
2024-10-25 23:24     ` Inochi Amaoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eeb1f7c-3198-45ac-be9a-c3d4e5174f1f@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=edumazet@google.com \
    --cc=inochiama@gmail.com \
    --cc=inochiama@outlook.com \
    --cc=joabreu@synopsys.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=looong.bin@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peppe.cavallaro@st.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.