From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Guanghui Yang <3497809730@qq.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix dentry folio leak in find_in_level
Date: Sun, 19 Jul 2026 15:17:45 +0800 [thread overview]
Message-ID: <8f354c53-18d9-4cf2-8ca6-e7476210c171@kernel.org> (raw)
In-Reply-To: <tencent_E3A22766836A9AE740D1CEF328C4DB8D0805@qq.com>
On 7/13/26 14:36, Guanghui Yang wrote:
> find_in_level() gets a dentry folio with f2fs_find_data_folio() before
> calling find_in_block(). If find_in_block() returns an error, the
> function stores the error in res_folio and breaks out of the loop without
> dropping the dentry folio.
>
> This leaks the folio reference on the find_in_block() error path. Drop
> the dentry folio before returning the error to the caller.
>
Need fixes and Cc stable lines.
> Signed-off-by: Guanghui Yang <3497809730@qq.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Guanghui Yang <3497809730@qq.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix dentry folio leak in find_in_level
Date: Sun, 19 Jul 2026 15:17:45 +0800 [thread overview]
Message-ID: <8f354c53-18d9-4cf2-8ca6-e7476210c171@kernel.org> (raw)
In-Reply-To: <tencent_E3A22766836A9AE740D1CEF328C4DB8D0805@qq.com>
On 7/13/26 14:36, Guanghui Yang wrote:
> find_in_level() gets a dentry folio with f2fs_find_data_folio() before
> calling find_in_block(). If find_in_block() returns an error, the
> function stores the error in res_folio and breaks out of the loop without
> dropping the dentry folio.
>
> This leaks the folio reference on the find_in_block() error path. Drop
> the dentry folio before returning the error to the caller.
>
Need fixes and Cc stable lines.
> Signed-off-by: Guanghui Yang <3497809730@qq.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2026-07-19 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 6:36 [PATCH] f2fs: fix dentry folio leak in find_in_level Guanghui Yang
2026-07-13 6:36 ` [f2fs-dev] " Guanghui Yang via Linux-f2fs-devel
2026-07-19 7:17 ` Chao Yu via Linux-f2fs-devel [this message]
2026-07-19 7:17 ` Chao Yu
2026-07-19 8:45 ` [PATCH v2] " Guanghui Yang
2026-07-19 8:45 ` [f2fs-dev] " Guanghui Yang via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f354c53-18d9-4cf2-8ca6-e7476210c171@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=3497809730@qq.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.