From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: turn off one_time when forcibly set to foreground GC
Date: Fri, 30 May 2025 22:35:03 +0800 [thread overview]
Message-ID: <8f56170c-d63a-41a2-a50a-a70de79965d3@kernel.org> (raw)
In-Reply-To: <20250529213750.1068920-1-daeho43@gmail.com>
On 2025/5/30 5:37, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> one_time mode is only for background GC. So, we need to set it back to
> false when foreground GC is enforced.
>
Need a fixes line?
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> fs/f2fs/gc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 2b8f9239bede..f752dec71e45 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1893,6 +1893,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control)
> /* Let's run FG_GC, if we don't have enough space. */
> if (has_not_enough_free_secs(sbi, 0, 0)) {
> gc_type = FG_GC;
> + gc_control->one_time = false;
>
> /*
> * For example, if there are many prefree_segments below given
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: chao@kernel.org, Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: turn off one_time when forcibly set to foreground GC
Date: Fri, 30 May 2025 22:35:03 +0800 [thread overview]
Message-ID: <8f56170c-d63a-41a2-a50a-a70de79965d3@kernel.org> (raw)
In-Reply-To: <20250529213750.1068920-1-daeho43@gmail.com>
On 2025/5/30 5:37, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
>
> one_time mode is only for background GC. So, we need to set it back to
> false when foreground GC is enforced.
>
Need a fixes line?
> Signed-off-by: Daeho Jeong <daehojeong@google.com>
> ---
> fs/f2fs/gc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 2b8f9239bede..f752dec71e45 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1893,6 +1893,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control)
> /* Let's run FG_GC, if we don't have enough space. */
> if (has_not_enough_free_secs(sbi, 0, 0)) {
> gc_type = FG_GC;
> + gc_control->one_time = false;
>
> /*
> * For example, if there are many prefree_segments below given
next prev parent reply other threads:[~2025-05-30 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 21:37 [f2fs-dev] [PATCH] f2fs: turn off one_time when forcibly set to foreground GC Daeho Jeong
2025-05-29 21:37 ` Daeho Jeong
2025-05-30 14:35 ` Chao Yu via Linux-f2fs-devel [this message]
2025-05-30 14:35 ` [f2fs-dev] " Chao Yu
-- strict thread matches above, loose matches on Subject: below --
2025-06-03 17:37 Daeho Jeong
2025-06-04 2:09 ` Chao Yu via Linux-f2fs-devel
2025-06-04 2:09 ` Chao Yu
2025-06-04 17:24 Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f56170c-d63a-41a2-a50a-a70de79965d3@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.