From: Hayes Wang <hayeswang@realtek.com>
To: "Limonciello, Mario" <mario.limonciello@amd.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: "edumazet@google.com" <edumazet@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Paul Menzel <pmenzel@molgen.mpg.de>
Subject: RE: Error 'netif_napi_add_weight() called with weight 256'
Date: Mon, 7 Aug 2023 09:57:15 +0000 [thread overview]
Message-ID: <8fcbab1aa2e14262bea79222bf7a4976@realtek.com> (raw)
In-Reply-To: <673bc252-2b34-6ef9-1765-9c7cac1e8658@amd.com>
Limonciello, Mario <mario.limonciello@amd.com>
> Sent: Tuesday, August 1, 2023 2:24 AM
[...]
>
> > The custom weight is probably due to a misunderstanding. We have 200G
> > adapters using the standard weight of 64, IDK why 2.5G adapter would
> > need anything special.
>
> Perhaps Hayes Wang can comment on this (as the author of 195aae321c82).
I test our devices on an Embedded system.
We find the throughput is low.
And it is caused by the weight.
Our NAPI function often uses the whole budget.
Finally, we increase the weight, and the throughput is good.
Best Regards,
Hayes
next prev parent reply other threads:[~2023-08-07 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:02 Error 'netif_napi_add_weight() called with weight 256' Limonciello, Mario
2023-07-31 18:13 ` Jakub Kicinski
2023-07-31 18:23 ` Limonciello, Mario
2023-07-31 20:47 ` Stephen Hemminger
2023-08-07 9:57 ` Hayes Wang [this message]
2023-08-07 16:37 ` Jakub Kicinski
2023-08-09 13:11 ` Hayes Wang
2023-08-09 18:37 ` Jakub Kicinski
2023-08-14 7:07 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fcbab1aa2e14262bea79222bf7a4976@realtek.com \
--to=hayeswang@realtek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.