From: David Brown <davidb@codeaurora.org>
To: Jamie Iles <jamie@jamieiles.com>
Cc: Stepan Moskovchenko <stepanm@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, rlove@google.com
Subject: Re: [PATCH 2/2] serial: msm: Add support for UARTDM cores
Date: Wed, 19 Jan 2011 11:52:02 -0800 [thread overview]
Message-ID: <8ya7he0r7rx.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <20110119173739.GE3341@pulham.picochip.com> (Jamie Iles's message of "Wed, 19 Jan 2011 17:37:39 +0000")
On Wed, Jan 19 2011, Jamie Iles wrote:
> On Wed, Jan 19, 2011 at 09:31:55AM -0800, David Brown wrote:
>> I'm not sure what would be a better name for the flag, though. The
>> block is called UARTDM.
>
> Ok, it was mainly out of curiosity. I guess it could be 'use_dma' or
> perhaps a comment to explain what DM is but my curiosity is now
> satisfied ;-)
I think use_dma would probably be even more confusing, since it isn't
using dma.
It's a flag indicating if the device has the capability of doing dma.
It's really a block version indicator, except that the blocks weren't
given different versions, but instead given a name based on the DMA.
I wonder if is_dma_capable would be better.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] serial: msm: Add support for UARTDM cores
Date: Wed, 19 Jan 2011 11:52:02 -0800 [thread overview]
Message-ID: <8ya7he0r7rx.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <20110119173739.GE3341@pulham.picochip.com> (Jamie Iles's message of "Wed, 19 Jan 2011 17:37:39 +0000")
On Wed, Jan 19 2011, Jamie Iles wrote:
> On Wed, Jan 19, 2011 at 09:31:55AM -0800, David Brown wrote:
>> I'm not sure what would be a better name for the flag, though. The
>> block is called UARTDM.
>
> Ok, it was mainly out of curiosity. I guess it could be 'use_dma' or
> perhaps a comment to explain what DM is but my curiosity is now
> satisfied ;-)
I think use_dma would probably be even more confusing, since it isn't
using dma.
It's a flag indicating if the device has the capability of doing dma.
It's really a block version indicator, except that the blocks weren't
given different versions, but instead given a name based on the DMA.
I wonder if is_dma_capable would be better.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-19 19:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 3:26 [PATCH 2/2] serial: msm: Add support for UARTDM cores Stepan Moskovchenko
2011-01-19 3:26 ` Stepan Moskovchenko
2011-01-19 8:25 ` Jamie Iles
2011-01-19 8:25 ` Jamie Iles
2011-01-19 17:31 ` David Brown
2011-01-19 17:31 ` David Brown
2011-01-19 17:37 ` Jamie Iles
2011-01-19 17:37 ` Jamie Iles
2011-01-19 19:52 ` David Brown [this message]
2011-01-19 19:52 ` David Brown
2011-01-19 22:08 ` Stepan Moskovchenko
2011-01-19 22:08 ` Stepan Moskovchenko
2011-01-19 22:24 ` Russell King - ARM Linux
2011-01-19 22:24 ` Russell King - ARM Linux
2011-01-20 0:11 ` Stepan Moskovchenko
2011-01-20 0:11 ` Stepan Moskovchenko
2011-01-20 2:38 ` Stepan Moskovchenko
2011-01-20 2:38 ` Stepan Moskovchenko
2011-01-20 9:04 ` Russell King - ARM Linux
2011-01-20 9:04 ` Russell King - ARM Linux
2011-01-20 21:56 ` [PATCH v2 " Stepan Moskovchenko
2011-01-20 21:56 ` Stepan Moskovchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ya7he0r7rx.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@google.com \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.