From: David Brown <davidb@codeaurora.org>
To: Daniel Walker <dwalker@codeaurora.org>
Cc: Stepan Moskovchenko <stepanm@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] msm: Clean up useless ifdefs
Date: Thu, 27 Jan 2011 12:50:25 -0800 [thread overview]
Message-ID: <8yaoc723wby.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1296161064.28965.10.camel@c-dwalke-linux.qualcomm.com> (Daniel Walker's message of "Thu, 27 Jan 2011 12:44:24 -0800")
On Thu, Jan 27 2011, Daniel Walker wrote:
> On Thu, 2011-01-27 at 12:13 -0800, Stepan Moskovchenko wrote:
>> Remove ifdefs that do nothing, either from having the code
>> between them previously removed, or from having been
>> accidentally added to the wrong file.
>>
>> Change-Id: I94aac2cb24e23ba7f8b4b158ce6653dc3b786989
>> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
>
> You need to drop the Change-Id: ..
If there aren't any other concerns raised, I can pull these off when I
pull in these changes. But, yes, in generall, they shouldn't be
present.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] msm: Clean up useless ifdefs
Date: Thu, 27 Jan 2011 12:50:25 -0800 [thread overview]
Message-ID: <8yaoc723wby.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <1296161064.28965.10.camel@c-dwalke-linux.qualcomm.com> (Daniel Walker's message of "Thu, 27 Jan 2011 12:44:24 -0800")
On Thu, Jan 27 2011, Daniel Walker wrote:
> On Thu, 2011-01-27 at 12:13 -0800, Stepan Moskovchenko wrote:
>> Remove ifdefs that do nothing, either from having the code
>> between them previously removed, or from having been
>> accidentally added to the wrong file.
>>
>> Change-Id: I94aac2cb24e23ba7f8b4b158ce6653dc3b786989
>> Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
>
> You need to drop the Change-Id: ..
If there aren't any other concerns raised, I can pull these off when I
pull in these changes. But, yes, in generall, they shouldn't be
present.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-27 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 20:13 [PATCH] msm: Clean up useless ifdefs Stepan Moskovchenko
2011-01-27 20:13 ` Stepan Moskovchenko
2011-01-27 20:44 ` Daniel Walker
2011-01-27 20:44 ` Daniel Walker
2011-01-27 20:50 ` David Brown [this message]
2011-01-27 20:50 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8yaoc723wby.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.