From: David Brown <davidb@codeaurora.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/7] msm: gpiomux: Move public API to public header
Date: Wed, 18 May 2011 16:06:26 -0700 [thread overview]
Message-ID: <8yay623libx.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269764D2F7405A@AUSP01VMBX24.collaborationhost.net> (H. Hartley Sweeten's message of "Wed, 18 May 2011 17:44:39 -0500")
On Wed, May 18 2011, H Hartley Sweeten wrote:
> On Wednesday, May 18, 2011 2:51 PM, David Brown wrote:
>>
>> The gpiomux.h header contains some SOC ifdefs. However, the API that
>> is actually used by the GPIO driver only uses two functions that are
>> general. Move these general definitions into a public header file.
>>
>> Signed-off-by: David Brown <davidb@codeaurora.org>
>> ---
>> arch/arm/mach-msm/gpio.c | 2 +-
>> arch/arm/mach-msm/gpiomux.h | 17 +----------------
>> include/linux/msm_gpiomux.h | 38 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 40 insertions(+), 17 deletions(-)
>> create mode 100644 include/linux/msm_gpiomux.h
>
> The msm_gpiomux.h header appears to be very "msm" specific, especially
> with the #ifdef CONFIG_MSM_GPIOMUX in it. Wouldn't it be cleaner to
> just move it to arch/arm/mach-msm/include/mach/msm_gpiomux.h?
>
> I don't see a reason why this header needs/should be available for
> the general public in /include/linux.
Agreed.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] msm: gpiomux: Move public API to public header
Date: Wed, 18 May 2011 16:06:26 -0700 [thread overview]
Message-ID: <8yay623libx.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269764D2F7405A@AUSP01VMBX24.collaborationhost.net> (H. Hartley Sweeten's message of "Wed, 18 May 2011 17:44:39 -0500")
On Wed, May 18 2011, H Hartley Sweeten wrote:
> On Wednesday, May 18, 2011 2:51 PM, David Brown wrote:
>>
>> The gpiomux.h header contains some SOC ifdefs. However, the API that
>> is actually used by the GPIO driver only uses two functions that are
>> general. Move these general definitions into a public header file.
>>
>> Signed-off-by: David Brown <davidb@codeaurora.org>
>> ---
>> arch/arm/mach-msm/gpio.c | 2 +-
>> arch/arm/mach-msm/gpiomux.h | 17 +----------------
>> include/linux/msm_gpiomux.h | 38 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 40 insertions(+), 17 deletions(-)
>> create mode 100644 include/linux/msm_gpiomux.h
>
> The msm_gpiomux.h header appears to be very "msm" specific, especially
> with the #ifdef CONFIG_MSM_GPIOMUX in it. Wouldn't it be cleaner to
> just move it to arch/arm/mach-msm/include/mach/msm_gpiomux.h?
>
> I don't see a reason why this header needs/should be available for
> the general public in /include/linux.
Agreed.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: David Brown <davidb@codeaurora.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-arm-msm\@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/7] msm: gpiomux: Move public API to public header
Date: Wed, 18 May 2011 16:06:26 -0700 [thread overview]
Message-ID: <8yay623libx.fsf@huya.qualcomm.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269764D2F7405A@AUSP01VMBX24.collaborationhost.net> (H. Hartley Sweeten's message of "Wed, 18 May 2011 17:44:39 -0500")
On Wed, May 18 2011, H Hartley Sweeten wrote:
> On Wednesday, May 18, 2011 2:51 PM, David Brown wrote:
>>
>> The gpiomux.h header contains some SOC ifdefs. However, the API that
>> is actually used by the GPIO driver only uses two functions that are
>> general. Move these general definitions into a public header file.
>>
>> Signed-off-by: David Brown <davidb@codeaurora.org>
>> ---
>> arch/arm/mach-msm/gpio.c | 2 +-
>> arch/arm/mach-msm/gpiomux.h | 17 +----------------
>> include/linux/msm_gpiomux.h | 38 ++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 40 insertions(+), 17 deletions(-)
>> create mode 100644 include/linux/msm_gpiomux.h
>
> The msm_gpiomux.h header appears to be very "msm" specific, especially
> with the #ifdef CONFIG_MSM_GPIOMUX in it. Wouldn't it be cleaner to
> just move it to arch/arm/mach-msm/include/mach/msm_gpiomux.h?
>
> I don't see a reason why this header needs/should be available for
> the general public in /include/linux.
Agreed.
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-05-18 23:06 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 21:50 [PATCH 0/7] Move Qualcomm gpio drivers into drivers dir David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` [PATCH 1/7] msm: gpio: Remove unsupported devices David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` [PATCH 2/7] msm: Remove chip-ifdefs for GPIO io mappings David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` [PATCH 3/7] msm: gpio: Remove chip-specific register definitions David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` [PATCH 4/7] msm: gpio: Remove ifdefs on gpio chip registers David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` [PATCH 5/7] msm: gpiomux: Move public API to public header David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 22:44 ` H Hartley Sweeten
2011-05-18 22:44 ` H Hartley Sweeten
2011-05-18 23:06 ` David Brown [this message]
2011-05-18 23:06 ` David Brown
2011-05-18 23:06 ` David Brown
2011-05-18 21:50 ` [PATCH 6/7] gpio_msm: Move Qualcomm v6 MSM driver into drivers David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` [PATCH 7/7] gpio_msm: Move Qualcomm MSM v2 gpio " David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 21:50 ` David Brown
2011-05-18 22:35 ` Stephen Boyd
2011-05-18 22:35 ` Stephen Boyd
2011-05-18 22:43 ` David Brown
2011-05-18 22:43 ` David Brown
2011-05-18 22:25 ` [PATCH 0/7] Move Qualcomm gpio drivers into drivers dir Linus Walleij
2011-05-18 22:25 ` Linus Walleij
2011-05-19 19:34 ` Nicolas Pitre
2011-05-19 19:34 ` Nicolas Pitre
2011-05-27 3:13 ` Grant Likely
2011-05-27 3:13 ` Grant Likely
2011-05-27 16:29 ` David Brown
2011-05-27 16:29 ` David Brown
2011-05-27 16:35 ` David Brown
2011-05-27 16:35 ` David Brown
2011-05-27 19:31 ` Nicolas Pitre
2011-05-27 19:31 ` Nicolas Pitre
2011-05-27 21:19 ` David Brown
2011-05-27 21:19 ` David Brown
2011-06-03 22:44 ` [PATCH v2 " David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` [PATCH v2 1/7] msm: gpio: Remove unsupported devices David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` [PATCH v2 2/7] msm: Remove chip-ifdefs for GPIO io mappings David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` [PATCH v2 3/7] msm: gpio: Remove chip-specific register definitions David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` [PATCH v2 4/7] msm: gpio: Remove ifdefs on gpio chip registers David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` [PATCH v2 5/7] msm: gpiomux: Move public API to public header David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` [PATCH v2 6/7] gpio_msm: Move Qualcomm v6 MSM driver into drivers David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` David Brown
2011-06-04 6:44 ` Grant Likely
2011-06-04 6:44 ` Grant Likely
2011-06-03 22:44 ` [PATCH v2 7/7] gpio_msm: Move Qualcomm MSM v2 gpio " David Brown
2011-06-03 22:44 ` David Brown
2011-06-03 22:44 ` David Brown
2011-06-04 6:45 ` Grant Likely
2011-06-04 6:45 ` Grant Likely
2011-06-04 0:15 ` [PATCH v2 0/7] Move Qualcomm gpio drivers into drivers dir David Brown
2011-06-04 0:15 ` David Brown
2011-06-06 21:51 ` [PATCH v3 0/8] " David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 1/8] msm: gpio: Remove unsupported devices David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 2/8] msm: Remove chip-ifdefs for GPIO io mappings David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 3/8] msm: gpio: Remove chip-specific register definitions David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 4/8] msm: gpio: Remove ifdefs on gpio chip registers David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 5/8] msm: gpiomux: Move public API to public header David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 6/8] msm: gpio: Fold register defs into C file David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 7/8] gpio_msm: Move Qualcomm v6 MSM driver into drivers David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` David Brown
2011-06-06 21:51 ` [PATCH v3 8/8] gpio_msm: Move Qualcomm MSM v2 gpio " David Brown
2011-06-06 21:51 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8yay623libx.fsf@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.