From: Andy King <acking@vmware.com>
To: Joe Perches <joe@perches.com>
Cc: pv-drivers@vmware.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
George Zhang <georgezhang@vmware.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.
Date: Wed, 21 Nov 2012 13:10:18 -0800 (PST) [thread overview]
Message-ID: <904751617.29421555.1353532218495.JavaMail.root@vmware.com> (raw)
In-Reply-To: <1353531886.24807.43.camel@joe-AO722>
Hi Joe,
> Just some trivial notes.
Thanks for taking a look!
> > + pr_warn("Failed to allocate memory for VMCI context.\n");
>
> OOM logging messages aren't necessary as alloc failures
> are already logged with a stack trace.
Noted, we'll remove all such occurrences.
> Maybe just use
> struct vmci_event_msg e_msg;
> struct vmci_event_payld_ctx ev_payload;
> and change the addressing or use a cast as appropriate?
It does seem inelegant, we'll take a look.
> You also have some inconsistency in whether or not your
> logging messages use a terminating period. I suggest
> you just delete all the periods.
> s/\.\\n"/\\n"/g
Gah, that's ugly. We'll remove all of them as you suggest.
Thanks!
- Andy
WARNING: multiple messages have this Message-ID (diff)
From: Andy King <acking@vmware.com>
To: Joe Perches <joe@perches.com>
Cc: pv-drivers@vmware.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
George Zhang <georgezhang@vmware.com>
Subject: Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.
Date: Wed, 21 Nov 2012 13:10:18 -0800 (PST) [thread overview]
Message-ID: <904751617.29421555.1353532218495.JavaMail.root@vmware.com> (raw)
In-Reply-To: <1353531886.24807.43.camel@joe-AO722>
Hi Joe,
> Just some trivial notes.
Thanks for taking a look!
> > + pr_warn("Failed to allocate memory for VMCI context.\n");
>
> OOM logging messages aren't necessary as alloc failures
> are already logged with a stack trace.
Noted, we'll remove all such occurrences.
> Maybe just use
> struct vmci_event_msg e_msg;
> struct vmci_event_payld_ctx ev_payload;
> and change the addressing or use a cast as appropriate?
It does seem inelegant, we'll take a look.
> You also have some inconsistency in whether or not your
> logging messages use a terminating period. I suggest
> you just delete all the periods.
> s/\.\\n"/\\n"/g
Gah, that's ugly. We'll remove all of them as you suggest.
Thanks!
- Andy
next prev parent reply other threads:[~2012-11-21 21:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:31 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-21 21:04 ` Joe Perches
2012-11-21 21:04 ` Joe Perches
2012-11-21 21:10 ` Andy King [this message]
2012-11-21 21:10 ` [Pv-drivers] " Andy King
2012-11-21 21:29 ` Dmitry Torokhov
2012-11-21 21:29 ` Dmitry Torokhov
2012-11-21 21:35 ` Joe Perches
2012-11-21 21:35 ` Joe Perches
2012-11-21 20:32 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-21 20:32 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-11-21 20:33 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-11-21 20:33 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-11-21 20:34 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-11-21 20:34 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-21 20:34 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-11-21 20:35 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-11-21 20:35 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-11-21 20:35 ` [PATCH 11/12] VMCI: host " George Zhang
2012-11-21 20:36 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-26 22:37 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
2012-11-26 22:37 ` Greg KH
2012-11-26 23:01 ` [Pv-drivers] " Dmitry Torokhov
2012-11-26 23:01 ` Dmitry Torokhov
2012-11-26 23:23 ` Greg KH
2012-11-26 23:23 ` Greg KH
2012-11-26 23:36 ` Dmitry Torokhov
2012-11-26 23:36 ` Dmitry Torokhov
2012-11-26 23:44 ` Greg KH
2012-11-26 23:44 ` Greg KH
2012-11-26 23:52 ` Dmitry Torokhov
2012-11-26 23:52 ` Dmitry Torokhov
2012-11-26 23:56 ` George Zhang
2012-11-26 23:56 ` George Zhang
2012-11-27 0:03 ` Greg KH
2012-11-27 0:03 ` Greg KH
2012-11-27 0:27 ` Woody Suwalski
2012-11-27 0:27 ` Woody Suwalski
2012-11-27 0:47 ` Dmitry Torokhov
2012-11-27 0:47 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2012-10-30 1:03 George Zhang
2012-10-30 1:03 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-10-30 2:10 ` Greg KH
2012-10-30 4:01 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 4:01 ` Dmitry Torokhov
2012-10-30 15:46 ` Greg KH
2012-10-30 15:46 ` Greg KH
2012-10-30 15:56 ` Dmitry Torokhov
2012-10-30 15:56 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=904751617.29421555.1353532218495.JavaMail.root@vmware.com \
--to=acking@vmware.com \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.