From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Aradhya Bhatia <a-bhatia1@ti.com>,
Devarsh Thakkar <devarsht@ti.com>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Jyri Sarha <jyri.sarha@iki.fi>
Subject: Re: [PATCH 09/10] drm/tidss: IRQ code cleanup
Date: Thu, 2 Nov 2023 09:00:11 +0200 [thread overview]
Message-ID: <90b38d40-d71e-4b0e-af35-047dcc5c5b41@ideasonboard.com> (raw)
In-Reply-To: <20231101145243.GY12764@pendragon.ideasonboard.com>
On 01/11/2023 16:52, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wed, Nov 01, 2023 at 11:17:46AM +0200, Tomi Valkeinen wrote:
>> The IRQ setup code is overly complex. All we really need to do is
>> initialize the related fields in struct tidss_device, and request the
>> IRQ.
>>
>> We can drop all the HW accesses, as they are pointless: the driver will
>> set the IRQs correctly when it needs any of the IRQs, and at probe time
>> we have done a reset, so we know that all the IRQs are masked by default
>> in the hardware.
>
> Even for K2G ?
Good point. I'll add a simple manual reset for k2g, masking the IRQs and
disabling the VPs.
Tomi
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Aradhya Bhatia <a-bhatia1@ti.com>,
Devarsh Thakkar <devarsht@ti.com>, Jyri Sarha <jyri.sarha@iki.fi>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] drm/tidss: IRQ code cleanup
Date: Thu, 2 Nov 2023 09:00:11 +0200 [thread overview]
Message-ID: <90b38d40-d71e-4b0e-af35-047dcc5c5b41@ideasonboard.com> (raw)
In-Reply-To: <20231101145243.GY12764@pendragon.ideasonboard.com>
On 01/11/2023 16:52, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Wed, Nov 01, 2023 at 11:17:46AM +0200, Tomi Valkeinen wrote:
>> The IRQ setup code is overly complex. All we really need to do is
>> initialize the related fields in struct tidss_device, and request the
>> IRQ.
>>
>> We can drop all the HW accesses, as they are pointless: the driver will
>> set the IRQs correctly when it needs any of the IRQs, and at probe time
>> we have done a reset, so we know that all the IRQs are masked by default
>> in the hardware.
>
> Even for K2G ?
Good point. I'll add a simple manual reset for k2g, masking the IRQs and
disabling the VPs.
Tomi
next prev parent reply other threads:[~2023-11-02 7:00 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 9:17 [PATCH 00/10] drm/tidss: Probe related fixes and cleanups Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 9:17 ` [PATCH 01/10] drm/tidss: Use pm_runtime_resume_and_get() Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 13:47 ` Laurent Pinchart
2023-11-01 13:47 ` Laurent Pinchart
2023-11-01 9:17 ` [PATCH 02/10] drm/tidss: Use PM autosuspend Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 13:54 ` Laurent Pinchart
2023-11-01 13:54 ` Laurent Pinchart
2023-11-02 6:34 ` Tomi Valkeinen
2023-11-02 6:34 ` Tomi Valkeinen
2023-11-05 22:53 ` Laurent Pinchart
2023-11-05 22:53 ` Laurent Pinchart
2023-11-06 7:54 ` Tomi Valkeinen
2023-11-06 7:54 ` Tomi Valkeinen
2023-11-01 9:17 ` [PATCH 03/10] drm/tidss: Drop useless variable init Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 13:54 ` Laurent Pinchart
2023-11-01 13:54 ` Laurent Pinchart
2023-11-01 9:17 ` [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init() Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 13:57 ` Laurent Pinchart
2023-11-01 13:57 ` Laurent Pinchart
2023-11-02 6:40 ` Tomi Valkeinen
2023-11-02 6:40 ` Tomi Valkeinen
2023-11-05 22:54 ` Laurent Pinchart
2023-11-05 22:54 ` Laurent Pinchart
2023-11-06 11:56 ` Tomi Valkeinen
2023-11-06 11:56 ` Tomi Valkeinen
2023-11-01 9:17 ` [PATCH 05/10] drm/tidss: Return error value from from softreset Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 13:59 ` Laurent Pinchart
2023-11-01 13:59 ` Laurent Pinchart
2023-11-02 6:44 ` Tomi Valkeinen
2023-11-02 6:44 ` Tomi Valkeinen
2023-11-01 9:17 ` [PATCH 06/10] drm/tidss: Check for K2G in in dispc_softreset() Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 14:22 ` Laurent Pinchart
2023-11-01 14:22 ` Laurent Pinchart
2023-11-01 9:17 ` [PATCH 07/10] drm/tidss: Fix dss reset Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 14:30 ` Laurent Pinchart
2023-11-01 14:30 ` Laurent Pinchart
2023-11-02 7:33 ` Tomi Valkeinen
2023-11-02 7:33 ` Tomi Valkeinen
2023-11-02 14:54 ` Francesco Dolcini
2023-11-02 14:54 ` Francesco Dolcini
2023-11-01 9:17 ` [PATCH 08/10] drm/tidss: Add dispc_is_idle() Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 14:32 ` Laurent Pinchart
2023-11-01 14:32 ` Laurent Pinchart
2023-11-02 7:03 ` Tomi Valkeinen
2023-11-02 7:03 ` Tomi Valkeinen
2023-11-01 9:17 ` [PATCH 09/10] drm/tidss: IRQ code cleanup Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 14:52 ` Laurent Pinchart
2023-11-01 14:52 ` Laurent Pinchart
2023-11-02 7:00 ` Tomi Valkeinen [this message]
2023-11-02 7:00 ` Tomi Valkeinen
2023-11-01 9:17 ` [PATCH 10/10] drm/tidss: Fix atomic_flush check Tomi Valkeinen
2023-11-01 9:17 ` Tomi Valkeinen
2023-11-01 14:56 ` Laurent Pinchart
2023-11-01 14:56 ` Laurent Pinchart
2023-11-02 8:23 ` Tomi Valkeinen
2023-11-02 8:23 ` Tomi Valkeinen
2023-11-02 14:55 ` Francesco Dolcini
2023-11-02 14:55 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90b38d40-d71e-4b0e-af35-047dcc5c5b41@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.