* your change "serial: 8250: move RSA functions to 8250_rsa.c"
@ 2025-10-21 6:22 Jan Beulich
2025-11-07 6:23 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2025-10-21 6:22 UTC (permalink / raw)
To: Jiri Slaby; +Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman
Jiri,
in this change you moved code from 8250_base to 8250. The latter has always
had a dependency on the former. Now the former has gained a dependency on
the latter, i.e. a circular dependency was introduced. Maybe modern module
loading tools can handle that; on the first (older) system I tried they
can't, and I had to resort to setting SERIAL_8250_RSA=n as a workaround.
One related question that came to mind: Seeing that both drivers are built
depending on the SERIAL_8250 setting, why are they separate modules anyway?
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: your change "serial: 8250: move RSA functions to 8250_rsa.c"
2025-10-21 6:22 your change "serial: 8250: move RSA functions to 8250_rsa.c" Jan Beulich
@ 2025-11-07 6:23 ` Jiri Slaby
2025-11-07 7:02 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2025-11-07 6:23 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman
On 21. 10. 25, 8:22, Jan Beulich wrote:
> Jiri,
>
> in this change you moved code from 8250_base to 8250. The latter has always
> had a dependency on the former. Now the former has gained a dependency on
> the latter, i.e. a circular dependency was introduced. Maybe modern module
> loading tools can handle that; on the first (older) system I tried they
> can't, and I had to resort to setting SERIAL_8250_RSA=n as a workaround.
>
> One related question that came to mind: Seeing that both drivers are built
> depending on the SERIAL_8250 setting, why are they separate modules anyway?
Thanks,
could you give a try to:
https://lore.kernel.org/all/ddfbc4bf-658f-3eda-5b4f-f111ecd932f5@linux.intel.com/
(It moves rsa from 8250 into 8250_base.)
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: your change "serial: 8250: move RSA functions to 8250_rsa.c"
2025-11-07 6:23 ` Jiri Slaby
@ 2025-11-07 7:02 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2025-11-07 7:02 UTC (permalink / raw)
To: Jiri Slaby; +Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman
On 07.11.2025 07:23, Jiri Slaby wrote:
> On 21. 10. 25, 8:22, Jan Beulich wrote:
>> in this change you moved code from 8250_base to 8250. The latter has always
>> had a dependency on the former. Now the former has gained a dependency on
>> the latter, i.e. a circular dependency was introduced. Maybe modern module
>> loading tools can handle that; on the first (older) system I tried they
>> can't, and I had to resort to setting SERIAL_8250_RSA=n as a workaround.
>>
>> One related question that came to mind: Seeing that both drivers are built
>> depending on the SERIAL_8250 setting, why are they separate modules anyway?
>
> Thanks,
>
> could you give a try to:
> https://lore.kernel.org/all/ddfbc4bf-658f-3eda-5b4f-f111ecd932f5@linux.intel.com/
>
> (It moves rsa from 8250 into 8250_base.)
That'll certainly do, I don't think it actually needs trying. The broader question
remains though: Why are there two "core" modules in the first place?
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-07 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-21 6:22 your change "serial: 8250: move RSA functions to 8250_rsa.c" Jan Beulich
2025-11-07 6:23 ` Jiri Slaby
2025-11-07 7:02 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.