Re: [PATCH TRIVIAL] treewide: use qemu_dup() instead of dup()

[Filip Hejsek <filip.hejsek@gmail.com>]

Hello,

On Mon, 2026-10-12 at 23:54 +0400, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Oct 12, 2026 at 11:44 PM Filip Hejsek <filip.hejsek@gmail.com> wrote:
> > 
> > Make the use of qemu_dup() more consistent and eliminate the possibility
> > of accidentally creating non-cloexec fds.
> > 
> 
> Not so trivial, in my humble opinion, as there might have been some
> reason it was avoided.
> 

You're right, I shouldn't have tagged this as TRIVIAL.

I've actually intentionally left some dup()s unchanged for exactly this
reason. They are the ones in qemu-nbd.c, migration/cpr-exec.c, and
under linux-user/ and bsd-user/. I also didn't touch the tests, as I
didn't consider evaluating them to be worth the effort.

I should have put this info in the commit message...

> > [...]
> 
> After review I think these changes are valid. These changes shouldn't
> impact the exec() code paths in qemu.
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 

Thanks for reviewing this.

Filip