Re: [PATCH TRIVIAL] treewide: use qemu_dup() instead of dup()

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Oct 12, 2026 at 10:12:34PM +0200, Filip Hejsek wrote:
> Hello,
> 
> On Mon, 2026-10-12 at 23:54 +0400, Marc-André Lureau wrote:
> > Hi
> > 
> > On Mon, Oct 12, 2026 at 11:44 PM Filip Hejsek <filip.hejsek@gmail.com> wrote:
> > > 
> > > Make the use of qemu_dup() more consistent and eliminate the possibility
> > > of accidentally creating non-cloexec fds.
> > > 
> > 
> > Not so trivial, in my humble opinion, as there might have been some
> > reason it was avoided.
> > 
> 
> You're right, I shouldn't have tagged this as TRIVIAL.
> 
> I've actually intentionally left some dup()s unchanged for exactly this
> reason. They are the ones in qemu-nbd.c, migration/cpr-exec.c, and
> under linux-user/ and bsd-user/. I also didn't touch the tests, as I
> didn't consider evaluating them to be worth the effort.

IMHO, everything must be switched to use qemu_dup.  If a few callers
actually want the FD to remain open across execve, then they should
explicitly call qemu_clear_cloexec().  THis makes the intended
behaviour clear, as opposed to looking like a potential mistake.

> 
> I should have put this info in the commit message...
> 
> > > [...]
> > 
> > After review I think these changes are valid. These changes shouldn't
> > impact the exec() code paths in qemu.
> > 
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > 
> 
> Thanks for reviewing this.
> 
> Filip
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|