From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <Jianyong.Wu@arm.com>
Cc: Justin He <Justin.He@arm.com>,
kvm@vger.kernel.org, netdev@vger.kernel.org,
richardcochran@gmail.com, linux-kernel@vger.kernel.org,
sean.j.christopherson@intel.com,
Steven Price <Steven.Price@arm.com>,
Andre Przywara <Andre.Przywara@arm.com>,
john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com,
tglx@linutronix.de, nd <nd@arm.com>,
will@kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp.
Date: Tue, 24 Nov 2020 09:07:06 +0000 [thread overview]
Message-ID: <9133f26699c5fc08d0ea72acfa9aca3b@kernel.org> (raw)
In-Reply-To: <HE1PR0802MB255534CF7A04FB5A6CE99A67F4FB0@HE1PR0802MB2555.eurprd08.prod.outlook.com>
On 2020-11-24 05:20, Jianyong Wu wrote:
> Hi Marc,
[...]
>> > +/* ptp_kvm counter type ID */
>> > +#define ARM_PTP_VIRT_COUNTER 0
>> > +#define ARM_PTP_PHY_COUNTER 1
>> > +#define ARM_PTP_NONE_COUNTER 2
>>
>> The architecture definitely doesn't have this last counter.
>
> Yeah, this is just represent no counter data needed from guest.
> Some annotation should be added here.
I'd rather you remove it entirely, or explain why you really cannot
do without a fake counter.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <Jianyong.Wu@arm.com>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
Justin He <Justin.He@arm.com>,
kvm@vger.kernel.org, Suzuki Poulose <Suzuki.Poulose@arm.com>,
netdev@vger.kernel.org, richardcochran@gmail.com,
Steve Capper <Steve.Capper@arm.com>,
linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com,
Steven Price <Steven.Price@arm.com>,
Andre Przywara <Andre.Przywara@arm.com>,
john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com,
tglx@linutronix.de, nd <nd@arm.com>,
will@kernel.org, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp.
Date: Tue, 24 Nov 2020 09:07:06 +0000 [thread overview]
Message-ID: <9133f26699c5fc08d0ea72acfa9aca3b@kernel.org> (raw)
In-Reply-To: <HE1PR0802MB255534CF7A04FB5A6CE99A67F4FB0@HE1PR0802MB2555.eurprd08.prod.outlook.com>
On 2020-11-24 05:20, Jianyong Wu wrote:
> Hi Marc,
[...]
>> > +/* ptp_kvm counter type ID */
>> > +#define ARM_PTP_VIRT_COUNTER 0
>> > +#define ARM_PTP_PHY_COUNTER 1
>> > +#define ARM_PTP_NONE_COUNTER 2
>>
>> The architecture definitely doesn't have this last counter.
>
> Yeah, this is just represent no counter data needed from guest.
> Some annotation should be added here.
I'd rather you remove it entirely, or explain why you really cannot
do without a fake counter.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jianyong Wu <Jianyong.Wu@arm.com>
Cc: netdev@vger.kernel.org, yangbo.lu@nxp.com,
john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com,
sean.j.christopherson@intel.com, richardcochran@gmail.com,
Mark Rutland <Mark.Rutland@arm.com>,
will@kernel.org, Suzuki Poulose <Suzuki.Poulose@arm.com>,
Andre Przywara <Andre.Przywara@arm.com>,
Steven Price <Steven.Price@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Steve Capper <Steve.Capper@arm.com>,
Justin He <Justin.He@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp.
Date: Tue, 24 Nov 2020 09:07:06 +0000 [thread overview]
Message-ID: <9133f26699c5fc08d0ea72acfa9aca3b@kernel.org> (raw)
In-Reply-To: <HE1PR0802MB255534CF7A04FB5A6CE99A67F4FB0@HE1PR0802MB2555.eurprd08.prod.outlook.com>
On 2020-11-24 05:20, Jianyong Wu wrote:
> Hi Marc,
[...]
>> > +/* ptp_kvm counter type ID */
>> > +#define ARM_PTP_VIRT_COUNTER 0
>> > +#define ARM_PTP_PHY_COUNTER 1
>> > +#define ARM_PTP_NONE_COUNTER 2
>>
>> The architecture definitely doesn't have this last counter.
>
> Yeah, this is just represent no counter data needed from guest.
> Some annotation should be added here.
I'd rather you remove it entirely, or explain why you really cannot
do without a fake counter.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-11-24 9:07 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 6:22 [PATCH v15 0/9] Enable ptp_kvm for arm/arm64 Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 1/9] arm64: Probe for the presence of KVM hypervisor Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 10:38 ` kernel test robot
2020-11-11 12:23 ` kernel test robot
2020-11-11 16:54 ` kernel test robot
2020-11-11 6:22 ` [PATCH v15 2/9] arm/arm64: KVM: Advertise KVM UID to guests via SMCCC Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 13:10 ` kernel test robot
2020-11-11 14:36 ` kernel test robot
2020-11-11 6:22 ` [PATCH v15 4/9] time: Add mechanism to recognize clocksource in time_get_snapshot Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 5/9] clocksource: Add clocksource id for arm arch counter Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-23 10:44 ` Marc Zyngier
2020-11-23 10:44 ` Marc Zyngier
2020-11-23 10:44 ` Marc Zyngier
2020-11-23 11:59 ` Marc Zyngier
2020-11-23 11:59 ` Marc Zyngier
2020-11-23 11:59 ` Marc Zyngier
2020-11-24 5:11 ` Jianyong Wu
2020-11-24 5:11 ` Jianyong Wu
2020-11-24 5:11 ` Jianyong Wu
2020-11-24 5:20 ` Jianyong Wu
2020-11-24 5:20 ` Jianyong Wu
2020-11-24 5:20 ` Jianyong Wu
2020-11-24 9:07 ` Marc Zyngier [this message]
2020-11-24 9:07 ` Marc Zyngier
2020-11-24 9:07 ` Marc Zyngier
2020-11-24 10:14 ` Jianyong Wu
2020-11-24 10:14 ` Jianyong Wu
2020-11-24 10:14 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 8:52 ` kernel test robot
2020-11-11 13:44 ` kernel test robot
2020-12-04 9:46 ` Jianyong Wu
2020-11-23 10:49 ` Marc Zyngier
2020-11-23 10:49 ` Marc Zyngier
2020-11-23 10:49 ` Marc Zyngier
2020-11-24 5:37 ` Jianyong Wu
2020-11-24 5:37 ` Jianyong Wu
2020-11-24 5:37 ` Jianyong Wu
2020-11-24 9:04 ` Marc Zyngier
2020-11-24 9:04 ` Marc Zyngier
2020-11-24 9:04 ` Marc Zyngier
2020-11-24 10:18 ` Jianyong Wu
2020-11-24 10:18 ` Jianyong Wu
2020-11-24 10:18 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 8/9] doc: add ptp_kvm introduction for arm64 support Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-23 10:58 ` Marc Zyngier
2020-11-23 10:58 ` Marc Zyngier
2020-11-23 10:58 ` Marc Zyngier
2020-11-24 5:21 ` Jianyong Wu
2020-11-24 5:21 ` Jianyong Wu
2020-11-24 5:21 ` Jianyong Wu
2020-11-11 6:22 ` [PATCH v15 9/9] arm64: Add kvm capability check extension for ptp_kvm Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-11 6:22 ` Jianyong Wu
2020-11-23 9:26 ` [PATCH v15 0/9] Enable ptp_kvm for arm/arm64 Jianyong Wu
2020-11-23 9:26 ` Jianyong Wu
2020-11-23 9:26 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9133f26699c5fc08d0ea72acfa9aca3b@kernel.org \
--to=maz@kernel.org \
--cc=Andre.Przywara@arm.com \
--cc=Jianyong.Wu@arm.com \
--cc=Justin.He@arm.com \
--cc=Steven.Price@arm.com \
--cc=john.stultz@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.