From: Heiko Stuebner <heiko@sntech.de>
To: Frank Wunderlich <linux@fw-web.de>,
Frank Wunderlich <frank-w@public-files.de>
Cc: linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Aw: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb
Date: Sat, 09 Apr 2022 12:23:31 +0200 [thread overview]
Message-ID: <9183927.T7Z3S40VBb@phil> (raw)
In-Reply-To: <trinity-71c38625-1a00-47d7-8e23-4f33f25a997a-1649499268581@3c-app-gmx-bap35>
Am Samstag, 9. April 2022, 12:14:28 CEST schrieb Frank Wunderlich:
> Hi,
>
> > Gesendet: Samstag, 09. April 2022 um 09:51 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
>
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
> > phy_type = "utmi_wide";
> > power-domains = <&power RK3568_PD_PIPE>;
> > @@ -280,8 +280,8 @@ usb_host1_xhci: usb@fd000000 {
> > interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cru CLK_USB3OTG1_REF>, <&cru CLK_USB3OTG1_SUSPEND>,
> > <&cru ACLK_USB3OTG1>;
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
>
> this is the patch breaking it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=33fb697ec7e58c4f9b6a68d2786441189cd2df92
>
> suspend clock needs to be renamed too from "suspend_clk" to "suspend"
>
> else i get this error on poweroff
>
> xhci-hcd xhci-hcd.1.auto: Host halt failed, -110
>
> regards Frank
ok, so do you want to send a v2 including that change?
Alternatively I can also add this change when applying.
Also for educational purposes, the format for referencing a commit
you're fixing would be
Fixes: 33fb697ec7e5 ("usb: dwc3: Get clocks individually")
Signed-off-by: ....
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Frank Wunderlich <linux@fw-web.de>,
Frank Wunderlich <frank-w@public-files.de>
Cc: linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Aw: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb
Date: Sat, 09 Apr 2022 12:23:31 +0200 [thread overview]
Message-ID: <9183927.T7Z3S40VBb@phil> (raw)
In-Reply-To: <trinity-71c38625-1a00-47d7-8e23-4f33f25a997a-1649499268581@3c-app-gmx-bap35>
Am Samstag, 9. April 2022, 12:14:28 CEST schrieb Frank Wunderlich:
> Hi,
>
> > Gesendet: Samstag, 09. April 2022 um 09:51 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
>
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
> > phy_type = "utmi_wide";
> > power-domains = <&power RK3568_PD_PIPE>;
> > @@ -280,8 +280,8 @@ usb_host1_xhci: usb@fd000000 {
> > interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cru CLK_USB3OTG1_REF>, <&cru CLK_USB3OTG1_SUSPEND>,
> > <&cru ACLK_USB3OTG1>;
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
>
> this is the patch breaking it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=33fb697ec7e58c4f9b6a68d2786441189cd2df92
>
> suspend clock needs to be renamed too from "suspend_clk" to "suspend"
>
> else i get this error on poweroff
>
> xhci-hcd xhci-hcd.1.auto: Host halt failed, -110
>
> regards Frank
ok, so do you want to send a v2 including that change?
Alternatively I can also add this change when applying.
Also for educational purposes, the format for referencing a commit
you're fixing would be
Fixes: 33fb697ec7e5 ("usb: dwc3: Get clocks individually")
Signed-off-by: ....
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Frank Wunderlich <linux@fw-web.de>,
Frank Wunderlich <frank-w@public-files.de>
Cc: linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Michael Riesch <michael.riesch@wolfvision.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Aw: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb
Date: Sat, 09 Apr 2022 12:23:31 +0200 [thread overview]
Message-ID: <9183927.T7Z3S40VBb@phil> (raw)
In-Reply-To: <trinity-71c38625-1a00-47d7-8e23-4f33f25a997a-1649499268581@3c-app-gmx-bap35>
Am Samstag, 9. April 2022, 12:14:28 CEST schrieb Frank Wunderlich:
> Hi,
>
> > Gesendet: Samstag, 09. April 2022 um 09:51 Uhr
> > Von: "Frank Wunderlich" <linux@fw-web.de>
>
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
> > phy_type = "utmi_wide";
> > power-domains = <&power RK3568_PD_PIPE>;
> > @@ -280,8 +280,8 @@ usb_host1_xhci: usb@fd000000 {
> > interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cru CLK_USB3OTG1_REF>, <&cru CLK_USB3OTG1_SUSPEND>,
> > <&cru ACLK_USB3OTG1>;
> > - clock-names = "ref_clk", "suspend_clk",
> > - "bus_clk";
> > + clock-names = "ref", "suspend_clk",
> > + "bus_early";
> > dr_mode = "host";
>
> this is the patch breaking it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=33fb697ec7e58c4f9b6a68d2786441189cd2df92
>
> suspend clock needs to be renamed too from "suspend_clk" to "suspend"
>
> else i get this error on poweroff
>
> xhci-hcd xhci-hcd.1.auto: Host halt failed, -110
>
> regards Frank
ok, so do you want to send a v2 including that change?
Alternatively I can also add this change when applying.
Also for educational purposes, the format for referencing a commit
you're fixing would be
Fixes: 33fb697ec7e5 ("usb: dwc3: Get clocks individually")
Signed-off-by: ....
Heiko
next prev parent reply other threads:[~2022-04-09 10:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 7:51 [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb Frank Wunderlich
2022-04-09 7:51 ` Frank Wunderlich
2022-04-09 7:51 ` Frank Wunderlich
2022-04-09 10:14 ` Aw: " Frank Wunderlich
2022-04-09 10:14 ` Frank Wunderlich
2022-04-09 10:14 ` Frank Wunderlich
2022-04-09 10:23 ` Heiko Stuebner [this message]
2022-04-09 10:23 ` Heiko Stuebner
2022-04-09 10:23 ` Heiko Stuebner
2022-04-09 10:32 ` Aw: " Frank Wunderlich
2022-04-09 10:32 ` Frank Wunderlich
2022-04-09 10:32 ` Frank Wunderlich
2022-04-09 10:40 ` Dan Johansen
2022-04-09 10:40 ` Dan Johansen
2022-04-09 10:40 ` Dan Johansen
2022-04-09 10:57 ` Aw: " Frank Wunderlich
2022-04-09 10:57 ` Frank Wunderlich
2022-04-09 10:57 ` Frank Wunderlich
2022-04-09 11:01 ` Heiko Stuebner
2022-04-09 11:01 ` Heiko Stuebner
2022-04-09 11:01 ` Heiko Stuebner
2022-04-09 11:13 ` Aw: " Frank Wunderlich
2022-04-09 11:13 ` Frank Wunderlich
2022-04-09 11:13 ` Frank Wunderlich
2022-04-09 11:14 ` Aw: " Peter Geis
2022-04-09 11:14 ` Peter Geis
2022-04-09 11:14 ` Peter Geis
2022-04-09 11:30 ` Peter Geis
2022-04-09 11:30 ` Peter Geis
2022-04-09 11:30 ` Peter Geis
2022-04-09 11:35 ` Heiko Stuebner
2022-04-09 11:35 ` Heiko Stuebner
2022-04-09 11:35 ` Heiko Stuebner
2022-04-09 11:51 ` Peter Geis
2022-04-09 11:51 ` Peter Geis
2022-04-09 11:51 ` Peter Geis
2022-04-09 11:56 ` Aw: " Frank Wunderlich
2022-04-09 11:56 ` Frank Wunderlich
2022-04-09 11:56 ` Frank Wunderlich
2022-04-09 15:26 ` Peter Geis
2022-04-09 15:26 ` Peter Geis
2022-04-09 15:26 ` Peter Geis
2022-04-10 16:53 ` Heiko Stuebner
2022-04-10 16:53 ` Heiko Stuebner
2022-04-10 16:53 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9183927.T7Z3S40VBb@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.