From: Heiko Stuebner <heiko@sntech.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/12] i2c: rk3x: account for const type of of_device_id.data
Date: Wed, 17 Jan 2018 11:00:01 +0000 [thread overview]
Message-ID: <9191715.Ndy7U9z6f6@phil> (raw)
In-Reply-To: <20180115182456.zkx2ehdlxzrc2scu@ninjato>
Am Montag, 15. Januar 2018, 19:24:56 CET schrieb Wolfram Sang:
> On Tue, Jan 02, 2018 at 02:28:03PM +0100, Julia Lawall wrote:
> > This driver creates a number of const structures that it stores in
> > the data field of an of_device_id array.
> >
> > The data field of an of_device_id structure has type const void *, so
> > there is no need for a const-discarding cast when putting const values
> > into such a structure.
> >
> > Furthermore, adding const to the declaration of the location that
> > receives a const value from such a field ensures that the compiler
> > will continue to check that the value is not modified. The
> > const-discarding cast on the extraction from the data field is thus
> > no longer needed.
> >
> > Done using Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Heiko, you okay with the patch?
Looks good to me and does not seem to contain any changes related
to actual functionality, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/12] i2c: rk3x: account for const type of of_device_id.data
Date: Wed, 17 Jan 2018 12:00:01 +0100 [thread overview]
Message-ID: <9191715.Ndy7U9z6f6@phil> (raw)
In-Reply-To: <20180115182456.zkx2ehdlxzrc2scu@ninjato>
Am Montag, 15. Januar 2018, 19:24:56 CET schrieb Wolfram Sang:
> On Tue, Jan 02, 2018 at 02:28:03PM +0100, Julia Lawall wrote:
> > This driver creates a number of const structures that it stores in
> > the data field of an of_device_id array.
> >
> > The data field of an of_device_id structure has type const void *, so
> > there is no need for a const-discarding cast when putting const values
> > into such a structure.
> >
> > Furthermore, adding const to the declaration of the location that
> > receives a const value from such a field ensures that the compiler
> > will continue to check that the value is not modified. The
> > const-discarding cast on the extraction from the data field is thus
> > no longer needed.
> >
> > Done using Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Heiko, you okay with the patch?
Looks good to me and does not seem to contain any changes related
to actual functionality, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/12] i2c: rk3x: account for const type of of_device_id.data
Date: Wed, 17 Jan 2018 12:00:01 +0100 [thread overview]
Message-ID: <9191715.Ndy7U9z6f6@phil> (raw)
In-Reply-To: <20180115182456.zkx2ehdlxzrc2scu@ninjato>
Am Montag, 15. Januar 2018, 19:24:56 CET schrieb Wolfram Sang:
> On Tue, Jan 02, 2018 at 02:28:03PM +0100, Julia Lawall wrote:
> > This driver creates a number of const structures that it stores in
> > the data field of an of_device_id array.
> >
> > The data field of an of_device_id structure has type const void *, so
> > there is no need for a const-discarding cast when putting const values
> > into such a structure.
> >
> > Furthermore, adding const to the declaration of the location that
> > receives a const value from such a field ensures that the compiler
> > will continue to check that the value is not modified. The
> > const-discarding cast on the extraction from the data field is thus
> > no longer needed.
> >
> > Done using Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Heiko, you okay with the patch?
Looks good to me and does not seem to contain any changes related
to actual functionality, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2018-01-17 11:00 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 13:27 [PATCH 00/12] account for const type of of_device_id.data Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` [PATCH 01/12] PM / AVS: rockchip-io: " Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` [PATCH 02/12] pinctrl: at91-pio4: " Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-03 7:58 ` Linus Walleij
2018-01-03 7:58 ` Linus Walleij
2018-01-03 7:58 ` Linus Walleij
2018-01-02 13:27 ` [PATCH 03/12] spi: sirf: " Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-02 13:27 ` Julia Lawall
2018-01-03 12:15 ` Applied "spi: sirf: account for const type of of_device_id.data" to the spi tree Mark Brown
2018-01-03 12:15 ` Mark Brown
2018-01-03 12:15 ` Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-02 13:28 ` [PATCH 04/12] PCI: qcom: account for const type of of_device_id.data Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-03 12:22 ` Lorenzo Pieralisi
2018-01-03 12:22 ` Lorenzo Pieralisi
2018-01-03 12:38 ` Stanimir Varbanov
2018-01-03 12:38 ` Stanimir Varbanov
2018-01-03 12:38 ` Julia Lawall
2018-01-03 12:38 ` Julia Lawall
2018-01-03 18:23 ` Lorenzo Pieralisi
2018-01-03 18:23 ` Lorenzo Pieralisi
2018-01-02 13:28 ` [PATCH 05/12] pinctrl: armada-37xx: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-02 15:36 ` Gregory CLEMENT
2018-01-02 15:36 ` Gregory CLEMENT
2018-01-02 15:36 ` Gregory CLEMENT
2018-01-03 8:03 ` Linus Walleij
2018-01-03 8:03 ` Linus Walleij
2018-01-03 8:03 ` Linus Walleij
2018-01-02 13:28 ` [PATCH 06/12] power: supply: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-09 16:22 ` Sebastian Reichel
2018-01-09 16:22 ` Sebastian Reichel
2018-01-02 13:28 ` [PATCH 07/12] i2c: rk3x: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-15 18:24 ` Wolfram Sang
2018-01-15 18:24 ` Wolfram Sang
2018-01-15 18:24 ` Wolfram Sang
2018-01-17 11:00 ` Heiko Stuebner [this message]
2018-01-17 11:00 ` Heiko Stuebner
2018-01-17 11:00 ` Heiko Stuebner
2018-01-17 23:12 ` Wolfram Sang
2018-01-17 23:12 ` Wolfram Sang
2018-01-17 23:12 ` Wolfram Sang
2018-01-02 13:28 ` [PATCH 08/12] pinctrl: axp209: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-03 7:59 ` Linus Walleij
2018-01-03 7:59 ` Linus Walleij
2018-01-02 13:28 ` [PATCH 09/12] mtd: fsl-quadspi: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-07 18:08 ` Cyrille Pitchen
2018-01-07 18:08 ` Cyrille Pitchen
2018-01-02 13:28 ` [PATCH 10/12] spi: spi-fsl-dspi: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
[not found] ` <1514899688-27844-11-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2018-01-03 12:22 ` Applied "spi: spi-fsl-dspi: account for const type of of_device_id.data" to the spi tree Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-03 12:22 ` Mark Brown
2018-01-02 13:28 ` [PATCH 11/12] iio: common: ssp_sensors: account for const type of of_device_id.data Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-06 12:23 ` Jonathan Cameron
2018-01-06 12:23 ` Jonathan Cameron
2018-01-02 13:28 ` [PATCH 12/12] power: reset: " Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-02 13:28 ` Julia Lawall
2018-01-05 13:24 ` Alexandre Belloni
2018-01-05 13:24 ` Alexandre Belloni
2018-01-05 13:24 ` Alexandre Belloni
2018-01-09 16:22 ` Sebastian Reichel
2018-01-09 16:22 ` Sebastian Reichel
2018-01-09 16:22 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9191715.Ndy7U9z6f6@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.