From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Petr Oros <poros@redhat.com>, netdev@vger.kernel.org
Cc: Ivan Vecera <ivecera@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Rinitha S <sx.rinitha@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
linux-kernel@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Simon Horman <horms@kernel.org>,
intel-wired-lan@lists.osuosl.org,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net v6 1/2] dpll: export __dpll_pin_change_ntf() for use under dpll_lock
Date: Thu, 16 Apr 2026 18:50:09 +0100 [thread overview]
Message-ID: <919ce78a-45fc-4f4c-817b-154dd7c1cd00@linux.dev> (raw)
In-Reply-To: <20260416113952.389405-2-poros@redhat.com>
On 16/04/2026 12:39, Petr Oros wrote:
> From: Ivan Vecera <ivecera@redhat.com>
>
> Export __dpll_pin_change_ntf() so that drivers can send pin change
> notifications from within pin callbacks, which are already called
> under dpll_lock. Using dpll_pin_change_ntf() in that context would
> deadlock.
>
> Add lockdep_assert_held() to catch misuse without the lock held.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Petr Oros <poros@redhat.com>
Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
WARNING: multiple messages have this Message-ID (diff)
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Petr Oros <poros@redhat.com>, netdev@vger.kernel.org
Cc: Ivan Vecera <ivecera@redhat.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
Rinitha S <sx.rinitha@intel.com>,
Michal Schmidt <mschmidt@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net v6 1/2] dpll: export __dpll_pin_change_ntf() for use under dpll_lock
Date: Thu, 16 Apr 2026 18:50:09 +0100 [thread overview]
Message-ID: <919ce78a-45fc-4f4c-817b-154dd7c1cd00@linux.dev> (raw)
In-Reply-To: <20260416113952.389405-2-poros@redhat.com>
On 16/04/2026 12:39, Petr Oros wrote:
> From: Ivan Vecera <ivecera@redhat.com>
>
> Export __dpll_pin_change_ntf() so that drivers can send pin change
> notifications from within pin callbacks, which are already called
> under dpll_lock. Using dpll_pin_change_ntf() in that context would
> deadlock.
>
> Add lockdep_assert_held() to catch misuse without the lock held.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> Signed-off-by: Petr Oros <poros@redhat.com>
Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2026-04-16 17:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 11:39 [Intel-wired-lan] [PATCH net v6 0/2] ice: fix missing dpll notifications for SW pins Petr Oros
2026-04-16 11:39 ` Petr Oros
2026-04-16 11:39 ` [Intel-wired-lan] [PATCH net v6 1/2] dpll: export __dpll_pin_change_ntf() for use under dpll_lock Petr Oros
2026-04-16 11:39 ` Petr Oros
2026-04-16 17:50 ` Vadim Fedorenko [this message]
2026-04-16 17:50 ` Vadim Fedorenko
2026-04-16 11:39 ` [Intel-wired-lan] [PATCH net v6 2/2] ice: fix missing dpll notifications for SW pins Petr Oros
2026-04-16 11:39 ` Petr Oros
2026-04-16 11:43 ` [Intel-wired-lan] " Jiri Pirko
2026-04-16 11:43 ` Jiri Pirko
2026-04-16 11:46 ` [Intel-wired-lan] " Jiri Pirko
2026-04-16 11:46 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=919ce78a-45fc-4f4c-817b-154dd7c1cd00@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sx.rinitha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.