All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Conor Dooley <conor@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 2/4] dt-bindings: arm64: marvell: add solidrun cn9132 CEX-7 evaluation board
Date: Thu, 9 May 2024 16:10:53 +0000	[thread overview]
Message-ID: <91e87a18-9b94-4c5e-9930-80bd72646413@solid-run.com> (raw)
In-Reply-To: <20240509-recycler-flask-0b3b7e2802f9@spud>

Am 09.05.24 um 18:00 schrieb Conor Dooley:
> On Thu, May 09, 2024 at 10:49:13AM +0000, Josua Mayer wrote:
>> Am 09.05.24 um 12:46 schrieb Josua Mayer:
>>> Add bindings for the SolidRun CN9132 COM-Express Type 7 evaluation board.
>>> The CEX is based on CN9130 SoC and includes two southbridges.
>>>
>>> Because CN9132 and 9131 are just names for different designs around the
>>> same SoC, no soc compatibles beside marvell,cn9130 are needed.
>>>
>>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>>> ---
>>>  Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
>>> index 74d935ea279c..538d91be8857 100644
>>> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
>>> @@ -92,4 +92,12 @@ properties:
>>>            - const: solidrun,cn9130-sr-som
>>>            - const: marvell,cn9130
>>>  
>>> +      - description:
>>> +          SolidRun CN9132 COM-Express Type 7 based single-board computers
>>> +        items:
>>> +          - enum:
>>> +              - solidrun,cn9132-clearfog
>>> +          - const: solidrun,cn9132-sr-cex7
>>> +          - const: marvell,cn9130
>>> +
>>>  additionalProperties: true
>>>
>> It appears I will not be able to submit actual device-tree for this
>> board. Therefore when applying this patch-set, it may be skipped.
>>
>> I am not sure about the policy in this case,
>> if it is better to pick or skip.
> What do you mean my "not be able to"? Does the device exist? If it does
> then, I at least, have no objection to documenting a compatible for it.
Yes, it exists, and we do have a (low quality) dts for it.
I may not be able to do it in time for closing of merge window.

If it can go with actual dts, that's great!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Josua Mayer <josua@solid-run.com>
To: Conor Dooley <conor@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 2/4] dt-bindings: arm64: marvell: add solidrun cn9132 CEX-7 evaluation board
Date: Thu, 9 May 2024 16:10:53 +0000	[thread overview]
Message-ID: <91e87a18-9b94-4c5e-9930-80bd72646413@solid-run.com> (raw)
In-Reply-To: <20240509-recycler-flask-0b3b7e2802f9@spud>

Am 09.05.24 um 18:00 schrieb Conor Dooley:
> On Thu, May 09, 2024 at 10:49:13AM +0000, Josua Mayer wrote:
>> Am 09.05.24 um 12:46 schrieb Josua Mayer:
>>> Add bindings for the SolidRun CN9132 COM-Express Type 7 evaluation board.
>>> The CEX is based on CN9130 SoC and includes two southbridges.
>>>
>>> Because CN9132 and 9131 are just names for different designs around the
>>> same SoC, no soc compatibles beside marvell,cn9130 are needed.
>>>
>>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>>> ---
>>>  Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
>>> index 74d935ea279c..538d91be8857 100644
>>> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
>>> @@ -92,4 +92,12 @@ properties:
>>>            - const: solidrun,cn9130-sr-som
>>>            - const: marvell,cn9130
>>>  
>>> +      - description:
>>> +          SolidRun CN9132 COM-Express Type 7 based single-board computers
>>> +        items:
>>> +          - enum:
>>> +              - solidrun,cn9132-clearfog
>>> +          - const: solidrun,cn9132-sr-cex7
>>> +          - const: marvell,cn9130
>>> +
>>>  additionalProperties: true
>>>
>> It appears I will not be able to submit actual device-tree for this
>> board. Therefore when applying this patch-set, it may be skipped.
>>
>> I am not sure about the policy in this case,
>> if it is better to pick or skip.
> What do you mean my "not be able to"? Does the device exist? If it does
> then, I at least, have no objection to documenting a compatible for it.
Yes, it exists, and we do have a (low quality) dts for it.
I may not be able to do it in time for closing of merge window.

If it can go with actual dts, that's great!


  reply	other threads:[~2024-05-09 16:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 10:46 [PATCH v5 0/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer
2024-05-09 10:46 ` Josua Mayer
2024-05-09 10:46 ` [PATCH v5 1/4] dt-bindings: arm64: marvell: add solidrun cn9130 som based boards Josua Mayer
2024-05-09 10:46   ` Josua Mayer
2024-05-09 10:46 ` [PATCH v5 2/4] dt-bindings: arm64: marvell: add solidrun cn9132 CEX-7 evaluation board Josua Mayer
2024-05-09 10:46   ` Josua Mayer
2024-05-09 10:49   ` Josua Mayer
2024-05-09 10:49     ` Josua Mayer
2024-05-09 16:00     ` Conor Dooley
2024-05-09 16:00       ` Conor Dooley
2024-05-09 16:10       ` Josua Mayer [this message]
2024-05-09 16:10         ` Josua Mayer
2024-05-09 16:15       ` Josua Mayer
2024-05-09 16:15         ` Josua Mayer
2024-05-09 10:46 ` [PATCH v5 3/4] arm64: dts: add description for solidrun cn9130 som and clearfog boards Josua Mayer
2024-05-09 10:46   ` Josua Mayer
2024-05-09 10:46 ` [PATCH v5 4/4] arm64: dts: add description for solidrun cn9131 solidwan board Josua Mayer
2024-05-09 10:46   ` Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91e87a18-9b94-4c5e-9930-80bd72646413@solid-run.com \
    --to=josua@solid-run.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.