From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] net: spider_net: avoid using signed char for bitops
Date: Fri, 03 Oct 2014 17:15:05 +0200 [thread overview]
Message-ID: <9201792.OAu7xPjvdN@wuerfel> (raw)
In-Reply-To: <1412348517-20352-4-git-send-email-antoine.tenart@free-electrons.com>
On Friday 03 October 2014 17:01:56 Antoine Tenart wrote:
> Signedness bugs may occur when using signed char for bitops,
> depending on if the highest bit is ever used.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
>
It's probably worth mentioning here that this cannot happen in this
driver because it's only used in one powerpc-specific chip, and 'char'
is always 'unsigned' on powerpc.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
dan.carpenter@oracle.com, kou.ishizaki@toshiba.co.jp,
jens@de.ibm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: spider_net: avoid using signed char for bitops
Date: Fri, 03 Oct 2014 17:15:05 +0200 [thread overview]
Message-ID: <9201792.OAu7xPjvdN@wuerfel> (raw)
In-Reply-To: <1412348517-20352-4-git-send-email-antoine.tenart@free-electrons.com>
On Friday 03 October 2014 17:01:56 Antoine Tenart wrote:
> Signedness bugs may occur when using signed char for bitops,
> depending on if the highest bit is ever used.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
>
It's probably worth mentioning here that this cannot happen in this
driver because it's only used in one powerpc-specific chip, and 'char'
is always 'unsigned' on powerpc.
Arnd
next prev parent reply other threads:[~2014-10-03 15:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:01 [PATCH 0/2] net: spider_net: fix possible bitops errors Antoine Tenart
2014-10-03 15:01 ` Antoine Tenart
2014-10-03 15:01 ` [PATCH] net: pxa168_eth: avoid using signed char for bitops Antoine Tenart
2014-10-03 15:01 ` Antoine Tenart
2014-10-03 15:01 ` Antoine Tenart
2014-10-03 15:07 ` Antoine Tenart
2014-10-03 15:07 ` Antoine Tenart
2014-10-03 15:01 ` [PATCH 1/2] net: spider_net: do not read mac address again after setting it Antoine Tenart
2014-10-03 15:01 ` Antoine Tenart
2014-10-03 15:01 ` [PATCH 2/2] net: spider_net: avoid using signed char for bitops Antoine Tenart
2014-10-03 15:01 ` Antoine Tenart
2014-10-03 15:15 ` Arnd Bergmann [this message]
2014-10-03 15:15 ` Arnd Bergmann
2014-10-03 15:17 ` Antoine Tenart
2014-10-03 15:17 ` Antoine Tenart
2014-10-06 1:15 ` [PATCH 0/2] net: spider_net: fix possible bitops errors David Miller
2014-10-06 1:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9201792.OAu7xPjvdN@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.