All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel-gpu-top: Support for client stats
Date: Fri, 22 Jan 2021 11:36:48 +0000	[thread overview]
Message-ID: <92e11d23-a4f8-da09-5f90-6a0b0ca6614f@linux.intel.com> (raw)
In-Reply-To: <161126484631.3166.17704076104258866952@build.alporthouse.com>


On 21/01/2021 21:34, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2021-01-21 18:10:05)
>> +static struct clients *init_clients(const char *drm_card)
>> +{
>> +       struct clients *clients = malloc(sizeof(*clients));
>> +       const char *slash;
>> +       ssize_t ret;
>> +
>> +       memset(clients, 0, sizeof(*clients));
>> +
>> +       if (drm_card) {
>> +               slash = rindex(drm_card, '/');
>> +               assert(slash);
>> +       } else {
>> +               slash = "card0";
>> +       }
>> +
>> +       ret = snprintf(clients->sysfs_root, sizeof(clients->sysfs_root),
>> +                      "/sys/class/drm/%s/clients/", slash);
>> +       assert(ret > 0 && ret < sizeof(clients->sysfs_root));
> 
> Afaict, igt_device_card_match_pci et al are not guaranteed to fill in
> dev->drm_card and may leave it blank instead of finding the
> corresponding /dev/dri/cardN.

I did the rest but this is giving me trouble - can't see locally that it 
doesn't populate it. Do you know how to trigger that?

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] intel-gpu-top: Support for client stats
Date: Fri, 22 Jan 2021 11:36:48 +0000	[thread overview]
Message-ID: <92e11d23-a4f8-da09-5f90-6a0b0ca6614f@linux.intel.com> (raw)
In-Reply-To: <161126484631.3166.17704076104258866952@build.alporthouse.com>


On 21/01/2021 21:34, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2021-01-21 18:10:05)
>> +static struct clients *init_clients(const char *drm_card)
>> +{
>> +       struct clients *clients = malloc(sizeof(*clients));
>> +       const char *slash;
>> +       ssize_t ret;
>> +
>> +       memset(clients, 0, sizeof(*clients));
>> +
>> +       if (drm_card) {
>> +               slash = rindex(drm_card, '/');
>> +               assert(slash);
>> +       } else {
>> +               slash = "card0";
>> +       }
>> +
>> +       ret = snprintf(clients->sysfs_root, sizeof(clients->sysfs_root),
>> +                      "/sys/class/drm/%s/clients/", slash);
>> +       assert(ret > 0 && ret < sizeof(clients->sysfs_root));
> 
> Afaict, igt_device_card_match_pci et al are not guaranteed to fill in
> dev->drm_card and may leave it blank instead of finding the
> corresponding /dev/dri/cardN.

I did the rest but this is giving me trouble - can't see locally that it 
doesn't populate it. Do you know how to trigger that?

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-01-22 11:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 18:10 [igt-dev] [PATCH i-g-t] intel-gpu-top: Support for client stats Tvrtko Ursulin
2021-01-21 18:10 ` [Intel-gfx] " Tvrtko Ursulin
2021-01-21 19:56 ` [igt-dev] ✗ Fi.CI.BAT: failure for intel-gpu-top: Support for client stats (rev2) Patchwork
2021-01-21 21:34 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] intel-gpu-top: Support for client stats Chris Wilson
2021-01-21 21:34   ` Chris Wilson
2021-01-22 11:36   ` Tvrtko Ursulin [this message]
2021-01-22 11:36     ` Tvrtko Ursulin
2021-01-22 11:41     ` [igt-dev] " Chris Wilson
2021-01-22 11:41       ` Chris Wilson
2021-01-22 11:55 ` [igt-dev] [PATCH i-g-t v6] " Tvrtko Ursulin
2021-01-22 11:55   ` [Intel-gfx] " Tvrtko Ursulin
2021-01-22 12:15   ` [igt-dev] " Chris Wilson
2021-01-22 12:15     ` [Intel-gfx] " Chris Wilson
2021-01-22 12:17     ` Tvrtko Ursulin
2021-01-22 12:17       ` [Intel-gfx] " Tvrtko Ursulin
2021-01-22 12:21   ` Chris Wilson
2021-01-22 12:21     ` [Intel-gfx] " Chris Wilson
2021-01-22 13:12 ` [igt-dev] [PATCH i-g-t v7] " Tvrtko Ursulin
2021-01-22 13:12   ` [Intel-gfx] " Tvrtko Ursulin
2021-01-22 14:13 ` [igt-dev] ✓ Fi.CI.BAT: success for intel-gpu-top: Support for client stats (rev4) Patchwork
2021-01-22 22:21 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92e11d23-a4f8-da09-5f90-6a0b0ca6614f@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.