From: merez@codeaurora.org
To: YueHaibing <yuehaibing@huawei.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] wil6210: remove set but not used variable 'wdev'
Date: Sat, 08 Dec 2018 18:08:42 +0000 [thread overview]
Message-ID: <93252d599bfcf6073c612d4386e2b7bc@codeaurora.org> (raw)
In-Reply-To: <1543996743-137124-1-git-send-email-yuehaibing@huawei.com>
On 2018-12-05 09:59, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/main.c: In function
> '_wil6210_disconnect':
> drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
> variable 'wdev' set but not used [-Wunused-but-set-variable]
>
> It never used since commit ("e1b43407c034 wil6210: refactor disconnect
> flow")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/ath/wil6210/main.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Maya Erez <merez@codeaurora.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: merez@codeaurora.org
To: YueHaibing <yuehaibing@huawei.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] wil6210: remove set but not used variable 'wdev'
Date: Sat, 08 Dec 2018 20:08:42 +0200 [thread overview]
Message-ID: <93252d599bfcf6073c612d4386e2b7bc@codeaurora.org> (raw)
In-Reply-To: <1543996743-137124-1-git-send-email-yuehaibing@huawei.com>
On 2018-12-05 09:59, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/wil6210/main.c: In function
> '_wil6210_disconnect':
> drivers/net/wireless/ath/wil6210/main.c:407:23: warning:
> variable 'wdev' set but not used [-Wunused-but-set-variable]
>
> It never used since commit ("e1b43407c034 wil6210: refactor disconnect
> flow")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/ath/wil6210/main.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Maya Erez <merez@codeaurora.org>
--
Maya Erez
Qualcomm Israel, Inc. on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-12-08 18:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 12:32 [PATCH] wil6210: remove set but not used variable 'start' YueHaibing
2018-09-11 12:32 ` YueHaibing
2018-09-11 19:04 ` merez
2018-09-11 19:04 ` merez-sgV2jX0FEOL9JmXXK+q4OQ
2018-09-11 19:04 ` merez
2018-10-01 14:08 ` Kalle Valo
2018-10-01 14:08 ` Kalle Valo
2018-12-05 7:59 ` [PATCH] wil6210: remove set but not used variable 'wdev' YueHaibing
2018-12-05 7:59 ` YueHaibing
2018-12-08 18:08 ` merez [this message]
2018-12-08 18:08 ` merez
2018-12-20 7:45 ` Kalle Valo
2018-12-20 7:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93252d599bfcf6073c612d4386e2b7bc@codeaurora.org \
--to=merez@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.