From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jilin Yuan <yuanjilin@cdjrlc.com>,
robdclark@gmail.com, quic_abhinavk@quicinc.com, airlied@linux.ie,
daniel@ffwll.ch
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] msm/adreno: fix repeated words in comments
Date: Fri, 26 Aug 2022 12:45:30 +0300 [thread overview]
Message-ID: <9396ac0b-e8a1-e82d-65db-8abc0ee75491@linaro.org> (raw)
In-Reply-To: <20220823115654.58725-1-yuanjilin@cdjrlc.com>
On 23/08/2022 14:56, Jilin Yuan wrote:
> Delete the redundant word 'power'.
> Delete the redundant word 'in'.
> Delete the redundant word 'for'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the beginning of the commit message,
- add a correct Fixes tag.
Thank you
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 9f76f5b15759..32ecb783c3c1 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -352,7 +352,7 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
> gmu_write(gmu, REG_A6XX_GMU_HOST2GMU_INTR_SET, 1 << bit);
> }
>
> -/* Enable CPU control of SPTP power power collapse */
> +/* Enable CPU control of SPTP power collapse */
> static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
> {
> int ret;
> @@ -374,7 +374,7 @@ static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
> return 0;
> }
>
> -/* Disable CPU control of SPTP power power collapse */
> +/* Disable CPU control of SPTP power collapse */
> static void a6xx_sptprac_disable(struct a6xx_gmu *gmu)
> {
> u32 val;
> @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
> }
>
> /*
> - * Look for a level in in the secondary list that matches. If
> + * Look for a level in the secondary list that matches. If
> * nothing fits, use the maximum non zero vote
> */
>
> @@ -1559,7 +1559,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
> goto err_memory;
> }
>
> - /* Allocate memory for for the HFI queues */
> + /* Allocate memory for the HFI queues */
> ret = a6xx_gmu_memory_alloc(gmu, &gmu->hfi, SZ_16K, 0, "hfi");
> if (ret)
> goto err_memory;
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Jilin Yuan <yuanjilin@cdjrlc.com>,
robdclark@gmail.com, quic_abhinavk@quicinc.com, airlied@linux.ie,
daniel@ffwll.ch
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] msm/adreno: fix repeated words in comments
Date: Fri, 26 Aug 2022 12:45:30 +0300 [thread overview]
Message-ID: <9396ac0b-e8a1-e82d-65db-8abc0ee75491@linaro.org> (raw)
In-Reply-To: <20220823115654.58725-1-yuanjilin@cdjrlc.com>
On 23/08/2022 14:56, Jilin Yuan wrote:
> Delete the redundant word 'power'.
> Delete the redundant word 'in'.
> Delete the redundant word 'for'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the beginning of the commit message,
- add a correct Fixes tag.
Thank you
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 9f76f5b15759..32ecb783c3c1 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -352,7 +352,7 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
> gmu_write(gmu, REG_A6XX_GMU_HOST2GMU_INTR_SET, 1 << bit);
> }
>
> -/* Enable CPU control of SPTP power power collapse */
> +/* Enable CPU control of SPTP power collapse */
> static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
> {
> int ret;
> @@ -374,7 +374,7 @@ static int a6xx_sptprac_enable(struct a6xx_gmu *gmu)
> return 0;
> }
>
> -/* Disable CPU control of SPTP power power collapse */
> +/* Disable CPU control of SPTP power collapse */
> static void a6xx_sptprac_disable(struct a6xx_gmu *gmu)
> {
> u32 val;
> @@ -1277,7 +1277,7 @@ static int a6xx_gmu_rpmh_arc_votes_init(struct device *dev, u32 *votes,
> }
>
> /*
> - * Look for a level in in the secondary list that matches. If
> + * Look for a level in the secondary list that matches. If
> * nothing fits, use the maximum non zero vote
> */
>
> @@ -1559,7 +1559,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
> goto err_memory;
> }
>
> - /* Allocate memory for for the HFI queues */
> + /* Allocate memory for the HFI queues */
> ret = a6xx_gmu_memory_alloc(gmu, &gmu->hfi, SZ_16K, 0, "hfi");
> if (ret)
> goto err_memory;
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-08-26 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 11:56 [PATCH] msm/adreno: fix repeated words in comments Jilin Yuan
2022-08-23 11:56 ` Jilin Yuan
2022-08-26 9:45 ` Dmitry Baryshkov [this message]
2022-08-26 9:45 ` Dmitry Baryshkov
-- strict thread matches above, loose matches on Subject: below --
2022-07-24 7:36 wangjianli
2022-07-24 7:36 ` wangjianli
2022-08-26 9:45 ` Dmitry Baryshkov
2022-08-26 9:45 ` Dmitry Baryshkov
2022-08-26 9:53 ` Dan Carpenter
2022-08-26 9:53 ` Dan Carpenter
2022-08-26 10:05 ` Dmitry Baryshkov
2022-08-26 10:05 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9396ac0b-e8a1-e82d-65db-8abc0ee75491@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.