From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, qemu-s390x@nongnu.org,
Cornelia Huck <cohuck@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Igor Mammedov <imammedo@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v1 1/2] s390x/kvm: Get rid of legacy_s390_alloc()
Date: Wed, 3 Mar 2021 14:31:13 +0100 [thread overview]
Message-ID: <93a30708-e893-208b-3dd3-c8b617272966@redhat.com> (raw)
In-Reply-To: <20210303130916.22553-2-david@redhat.com>
On 03/03/2021 14.09, David Hildenbrand wrote:
> legacy_s390_alloc() was required for dealing with the absence of the ESOP
> feature -- on old HW (< gen 10) and old z/VM versions (< 6.3).
>
> As z/VM v6.2 (and even v6.3) is no longer supported since 2017 [1]
> and we don't expect to have real users on such old hardware, let's drop
> legacy_s390_alloc().
>
> Still check+report an error just in case someone still runs on
> such old z/VM environments, or someone runs under weird nested KVM
> setups (where we can manually disable ESOP via the CPU model).
>
> No need to check for KVM_CAP_GMAP - that should always be around on
> kernels that also have KVM_CAP_DEVICE_CTRL (>= v3.15).
Reviewed-by: Thomas Huth <thuth@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>,
Peter Xu <peterx@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v1 1/2] s390x/kvm: Get rid of legacy_s390_alloc()
Date: Wed, 3 Mar 2021 14:31:13 +0100 [thread overview]
Message-ID: <93a30708-e893-208b-3dd3-c8b617272966@redhat.com> (raw)
In-Reply-To: <20210303130916.22553-2-david@redhat.com>
On 03/03/2021 14.09, David Hildenbrand wrote:
> legacy_s390_alloc() was required for dealing with the absence of the ESOP
> feature -- on old HW (< gen 10) and old z/VM versions (< 6.3).
>
> As z/VM v6.2 (and even v6.3) is no longer supported since 2017 [1]
> and we don't expect to have real users on such old hardware, let's drop
> legacy_s390_alloc().
>
> Still check+report an error just in case someone still runs on
> such old z/VM environments, or someone runs under weird nested KVM
> setups (where we can manually disable ESOP via the CPU model).
>
> No need to check for KVM_CAP_GMAP - that should always be around on
> kernels that also have KVM_CAP_DEVICE_CTRL (>= v3.15).
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-03-04 0:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:09 [PATCH v1 0/2] Get rid of legacy_s390_alloc() and phys_mem_set_alloc() David Hildenbrand
2021-03-03 13:09 ` David Hildenbrand
2021-03-03 13:09 ` [PATCH v1 1/2] s390x/kvm: Get rid of legacy_s390_alloc() David Hildenbrand
2021-03-03 13:09 ` David Hildenbrand
2021-03-03 13:31 ` Thomas Huth [this message]
2021-03-03 13:31 ` Thomas Huth
2021-03-03 14:07 ` Christian Borntraeger
2021-03-03 14:07 ` Christian Borntraeger
2021-03-03 16:13 ` Igor Mammedov
2021-03-03 16:13 ` Igor Mammedov
2021-03-03 13:09 ` [PATCH v1 2/2] exec: Get rid of phys_mem_set_alloc() David Hildenbrand
2021-03-03 13:09 ` David Hildenbrand
2021-03-03 14:38 ` Thomas Huth
2021-03-03 14:38 ` Thomas Huth
2021-03-03 16:18 ` Igor Mammedov
2021-03-03 16:18 ` Igor Mammedov
2021-03-04 13:44 ` [PATCH v1 0/2] Get rid of legacy_s390_alloc() and phys_mem_set_alloc() Cornelia Huck
2021-03-04 13:44 ` Cornelia Huck
2021-03-10 16:22 ` Cornelia Huck
2021-03-10 16:22 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a30708-e893-208b-3dd3-c8b617272966@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.