All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, viro@ZenIV.linux.org.uk,
	linux-fsdevel@vger.kernel.org
Subject: Questions about exportfs
Date: Thu, 27 Nov 2008 14:51:40 +0000	[thread overview]
Message-ID: <9428.1227797500@redhat.com> (raw)


Hi Christoph,

Can you answer some questions about exportfs please?

 (1) In linux/exportfs.h, the description of the encode_fh() op says that
     "encode_fh() should return the number of bytes stored or a negative error
     code such as %-ENOSPC".

     This, however, contradicts export_encode_fh(), which returns a member of
     enum fid_type instead.  I presume the docs are wrong, or at least,
     unclear.

 (2) Why does exportfs_encode_fh() return the type of the FID?  Why not embed
     it in the fid struct?  It seems that the value has to be handed back to
     the decode routine.

 (3) Is fat_encode_fh() allowed to return a value not in the fid_type enum?

David

             reply	other threads:[~2008-11-27 14:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27 14:51 David Howells [this message]
2008-11-27 23:20 ` Questions about exportfs Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9428.1227797500@redhat.com \
    --to=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.