Re: [Intel-wired-lan] [PATCH iwl-next v1 0/5] iavf: Add devlink and devlink rate support

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 7/26/2023 7:10 PM, Wenjun Wu wrote:
> To allow user to configure queue bandwidth, devlink port support
> is added to support devlink port rate API. [1]
> 
> Add devlink framework registration/unregistration on iavf driver
> initialization and remove, and devlink port of DEVLINK_PORT_FLAVOUR_VIRTUAL
> is created to be associated iavf netdevice.
> 
> iavf rate tree with root node, queue nodes, and leaf node is created
> and registered with devlink rate when iavf adapter is configured, and
> if PF indicates support of VIRTCHNL_VF_OFFLOAD_QOS through VF Resource /
> Capability Exchange.
> 
> [root@localhost ~]# devlink port function rate show
> pci/0000:af:01.0/txq_15: type node parent iavf_root
> pci/0000:af:01.0/txq_14: type node parent iavf_root
> pci/0000:af:01.0/txq_13: type node parent iavf_root
> pci/0000:af:01.0/txq_12: type node parent iavf_root
> pci/0000:af:01.0/txq_11: type node parent iavf_root
> pci/0000:af:01.0/txq_10: type node parent iavf_root
> pci/0000:af:01.0/txq_9: type node parent iavf_root
> pci/0000:af:01.0/txq_8: type node parent iavf_root
> pci/0000:af:01.0/txq_7: type node parent iavf_root
> pci/0000:af:01.0/txq_6: type node parent iavf_root
> pci/0000:af:01.0/txq_5: type node parent iavf_root
> pci/0000:af:01.0/txq_4: type node parent iavf_root
> pci/0000:af:01.0/txq_3: type node parent iavf_root
> pci/0000:af:01.0/txq_2: type node parent iavf_root
> pci/0000:af:01.0/txq_1: type node parent iavf_root
> pci/0000:af:01.0/txq_0: type node parent iavf_root
> pci/0000:af:01.0/iavf_root: type node
> 
> 
>                           +---------+
>                           |   root  |
>                           +----+----+
>                                |
>              |-----------------|-----------------|
>         +----v----+       +----v----+       +----v----+
>         |  txq_0  |       |  txq_1  |       |  txq_x  |
>         +----+----+       +----+----+       +----+----+
> 
> User can configure the tx_max and tx_share of each queue. Once any one of the
> queues are fully configured, VIRTCHNL opcodes of VIRTCHNL_OP_CONFIG_QUEUE_BW
> and VIRTCHNL_OP_CONFIG_QUANTA will be sent to PF to configure queues allocated
> to VF
> 
> Example:
> 
> 1.To Set the queue tx_share:
> devlink port function rate set pci/0000:af:01.0 txq_0 tx_share 100 MBps
> 
> 2.To Set the queue tx_max:
> devlink port function rate set pci/0000:af:01.0 txq_0 tx_max 200 MBps
> 
> 3.To Show Current devlink port rate info:
> devlink port function rate function show
> [root@localhost ~]# devlink port function rate show
> pci/0000:af:01.0/txq_15: type node parent iavf_root
> pci/0000:af:01.0/txq_14: type node parent iavf_root
> pci/0000:af:01.0/txq_13: type node parent iavf_root
> pci/0000:af:01.0/txq_12: type node parent iavf_root
> pci/0000:af:01.0/txq_11: type node parent iavf_root
> pci/0000:af:01.0/txq_10: type node parent iavf_root
> pci/0000:af:01.0/txq_9: type node parent iavf_root
> pci/0000:af:01.0/txq_8: type node parent iavf_root
> pci/0000:af:01.0/txq_7: type node parent iavf_root
> pci/0000:af:01.0/txq_6: type node parent iavf_root
> pci/0000:af:01.0/txq_5: type node parent iavf_root
> pci/0000:af:01.0/txq_4: type node parent iavf_root
> pci/0000:af:01.0/txq_3: type node parent iavf_root
> pci/0000:af:01.0/txq_2: type node parent iavf_root
> pci/0000:af:01.0/txq_1: type node parent iavf_root
> pci/0000:af:01.0/txq_0: type node tx_share 800Mbit tx_max 1600Mbit parent iavf_root
> pci/0000:af:01.0/iavf_root: type node
> 
> 
> [1]https://lore.kernel.org/netdev/20221115104825.172668-1-michal.wilczynski@intel.com/
> 
> 
> Jun Zhang (3):
>    iavf: Add devlink and devlink port support
>    iavf: Add devlink port function rate API support
>    iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting
> 
> Wenjun Wu (2):
>    virtchnl: support queue rate limit and quanta size configuration
>    ice: Support VF queue rate limit and quanta size configuration


This series does not apply.

>   drivers/net/ethernet/intel/Kconfig            |   1 +
>   drivers/net/ethernet/intel/iavf/Makefile      |   2 +-
>   drivers/net/ethernet/intel/iavf/iavf.h        |  20 +
>   .../net/ethernet/intel/iavf/iavf_devlink.c    | 388 ++++++++++++++++++
>   .../net/ethernet/intel/iavf/iavf_devlink.h    |  39 ++
>   drivers/net/ethernet/intel/iavf/iavf_main.c   |  60 ++-
>   .../net/ethernet/intel/iavf/iavf_virtchnl.c   | 228 +++++++++-
>   drivers/net/ethernet/intel/ice/ice.h          |   2 +
>   drivers/net/ethernet/intel/ice/ice_base.c     |   2 +
>   drivers/net/ethernet/intel/ice/ice_common.c   |  19 +
>   .../net/ethernet/intel/ice/ice_hw_autogen.h   |   8 +
>   drivers/net/ethernet/intel/ice/ice_txrx.h     |   2 +
>   drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
>   drivers/net/ethernet/intel/ice/ice_vf_lib.h   |   9 +
>   drivers/net/ethernet/intel/ice/ice_virtchnl.c | 317 ++++++++++++++
>   drivers/net/ethernet/intel/ice/ice_virtchnl.h |  11 +
>   .../intel/ice/ice_virtchnl_allowlist.c        |   6 +
>   include/linux/avf/virtchnl.h                  | 113 +++++
>   18 files changed, 1225 insertions(+), 3 deletions(-)
>   create mode 100644 drivers/net/ethernet/intel/iavf/iavf_devlink.c
>   create mode 100644 drivers/net/ethernet/intel/iavf/iavf_devlink.h
> 
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan